From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2E773546EC for ; Thu, 10 Sep 2026 01:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789004240; cv=none; b=bXHmX/RaGeLOzX9lvMCfTGy5KScioZSHvQxQIVvrd+WZnsO1kdodE3ag/NeO/Apr3ZntR3AmQviGVO7wzRdvZOjujZdtF36pQSLlak0WmZATtTyzSKkA2Rvp6l5yclwUJjNGs1schMXbq/SOOgP3pMLBlEPF32G0ulnkDfO+XcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789004240; c=relaxed/simple; bh=NQgzUm2oapDD9XOauvQ7sAF3oBMmE2JcTiMHT0AxIWo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NqozucwQeN3m6foCx2vUDhcXI8TeUnegeboUn2adFo2dZVZS6sb23ri8990tzNSH6UAyovH10JW/BcBL1+g62jpfU2vHxWmW7sKSJQYqFx2vUdA3ag/e8O0W19nSfhpmV8Ct8dNh8yDkKhVZterQUAe13+RLNoSrdVd55M5Wlu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X9qqchTF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cQ7RS0tP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X9qqchTF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cQ7RS0tP" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689MA5Rr3790339 for ; Thu, 10 Sep 2026 01:37:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U5296QULjbatYMz6kpvnqDY9ew8mUlm8s2jfQjulqY4=; b=X9qqchTFThwZILnx WLAh78kMLrph0xponvvrQXZohS+3D67K0JIwO7Prm2SRLb+rC2F6A2119+ztrj1Q ylXqkSIyJjtEGMRcpN/Fai9Sw4BNaWtS+BKTh72cQw3UTb1Vl11vz+QcpTzggSX5 t8j2DZg4jbOEC+6fkJ1NCCaGV7VT0f13EuJ64GrtWXi4LJfXyTUDg9zOegbUHJd5 6Juf6VhvzQAha7gvkmrnqmtbOC3u+U13LTdOLYJtAMkBPMD+3uh8mNPkmSc7VJAK JD2j7Fl68ZmlOR0jGE0XkxDroabXxYEce/9lHUj9gqeDNM5p8Qe2lDNbb75EnwI7 lWlNew== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gkcyghfk5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 10 Sep 2026 01:37:17 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-395543dc382so2499149a91.0 for ; Wed, 09 Sep 2026 18:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789004237; x=1789609037; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U5296QULjbatYMz6kpvnqDY9ew8mUlm8s2jfQjulqY4=; b=cQ7RS0tPOl2PLFHHVXTd1FNNZ5GKsnr0Es2dAwOuRmkSwsbmA5JVl2/OEPsFYPXoNP vRtzzNRc7F3HUAzUy9CFEypqRFMFqfG/Iw8faZL6s3ICBrpTf9w8lDu5Ltm9mmsMKbdZ 1+9BZAu9ltmy3VYZhPRBeyatijukAyld34YNldMFIIxO8Keokr/OyiIo4iyGRRtnt4vd wmlbrslyJVFfmeS+ftdNLBrNsJTuO2yqXHcKmGium3oezZ53FqKg1TtDAQPjUpIwV6Uf C8T4GYsdT6b1c+6+/iUvsQ0lSVa5RLRxaNNydXKHDEl/kmZF2IIxOrz7An0fb05yvvpc q28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789004237; x=1789609037; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U5296QULjbatYMz6kpvnqDY9ew8mUlm8s2jfQjulqY4=; b=pnyC/U55R1BZNc2MOwV/SxaP9S+1YZKLHtkAPfWQrmSmweUptvRlHPTIT33z0TT+82 m6QzIkoB7m083BkCbAuj34hwYfujUH1a/Z5owRM7XywDPBjjapUF/J4ECmHL0Y8hQdZp HgTFlcBMQ2UB0EwSrdT9MHIybb4gYOw/1S2OxlkTiAU32ZAEun5pPWklM7W9APbG5OxQ tFB2mqJozzp7HKnKl7Kxn9z/cs3+HrjgbYnmmyQFrhqGzZ6j9XfaLz/CE1eCIzIQ9rIb wE3rCwDRlLHkR+tFhcMKxspPdyuI55KRkDEOV2cnVHY1UgdDQocj8gHY5yXI08ML1K6X u2+w== X-Forwarded-Encrypted: i=1; AKwUvBxyvdHrjw4AoRJfapmgjBzw4ZXz5R3atNNHNPrRUvPX1WNDNn522iX74EVZuIDEk0phqJxXWnAsscTp8RY=@vger.kernel.org X-Gm-Message-State: AFuF++mEbfGiy2P9i49oEpYFOzj1zZN+kF/RFZZhWHGVSm2bfGS8zv9e F8PdW3nQf4UhQ/tJREX6pY/pKi75uWX/KAC9nPszQoxlTSyiNWrEV9TI9SsuS66op1tXW4JXDia hyBCLqnTlCcpuuLbR81TbPU7MtoI105j4shfb9RB5rxMuBSBXgUESSo28hmY3cSMc5T4= X-Gm-Gg: AYBFou3YiCj1a08ANv9K3NGwZX5leQQjHofGGAKyIbbuvm/4hypCY8pr70AvCVbdW9e Hi1RV6Xt3J/SyxoGPhF6Is9n+7PXcC49nrtML6BbW/nUWeeRhNbKpKx5d+VYm6JHHHrUmadT1rW krJmJoczC2aY8GhjhqPEz+o6hXQHVI4iiOdQHWLc+7Ruu/hDNqbiV4czhMASXBw+ZqkbeK0GEiH M9TVD8Er+UuwrQI4CbEx8dWK9/owLMoq9VqR055FBuzYYbRwSSoHEdo90dKYrdJ0FjR4A9aS1bv 3a31uGiNIFmSQtsvtBvKvCv3s23CCeHz5kBar3C7sVa+DwY8cvtDvQREnwkU+f9gBmHKmfLXdFV 8VDdGkm9h2A38wU3esL4K2oospY5qFg== X-Received: by 2002:a17:90b:380a:b0:39b:2b10:d05c with SMTP id 98e67ed59e1d1-39d709e73a6mr5758514a91.5.1789004236766; Wed, 09 Sep 2026 18:37:16 -0700 (PDT) X-Received: by 2002:a17:90b:380a:b0:39b:2b10:d05c with SMTP id 98e67ed59e1d1-39d709e73a6mr5758465a91.5.1789004236325; Wed, 09 Sep 2026 18:37:16 -0700 (PDT) Received: from [192.168.1.132] ([70.95.199.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1433171a97esm52774345c88.12.2026.09.09.18.37.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 18:37:15 -0700 (PDT) Message-ID: <2ea2d992-d14d-4b26-91f3-c36a87acf82a@oss.qualcomm.com> Date: Wed, 9 Sep 2026 18:37:14 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/8] usb: misc: qcom_eud: add role-based EUD control To: Konrad Dybcio , Bjorn Andersson , Conor Dooley , Dmitry Baryshkov , Greg Kroah-Hartman , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Chen References: <20260831030147.1500616-1-elson.serrao@oss.qualcomm.com> <20260831030147.1500616-7-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Elson Serrao In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDAxNSBTYWx0ZWRfXzJpdmzrNxs2b on/mdIhDtOKVVdzUonGxrB94mnJPFNNQLbGk5mGMPJCfWOHujuDYh4yWCoV8hznkM3yN2vWHxPF caZuGwPgKIP96i4q+jUFwzpSIIOjWWU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDAxNSBTYWx0ZWRfX8tak/DBORks2 0woGdw8JomVtYKifi6PTnn2VWlpHd2+rxJHoiINQ/RvCHfmKtyAKUTsinzwvPZecEBo1WXvHXpj KxHmQgL1/9Py0bsFjhxvtXSiwHn0tvhy6MptG2cH2kvZom+056OSKfAC35cR6xj8YgZ9oY2cojK DlTQH64zoFH0cBIzHIBP0M+f0EUHv6leN05vTcz6BLfhuY7cMFci5YcUCSadaqr+MDyGn+k9OF0 0CY5ztgw5L1hN13o3djKholTrKBUyIUiuS7eIKsc2ORIm+whYK2YWmqS9kX1GR8EoUNgAlLeCey qu609FjAS4yRiLLnnG5khcehTjprPtFqk9GhAE5YmLJdyMFT++TmOZbiNNaPcRfmoFVAskzy6yL PWvsmig83Y44pVVhkoie23d3w5EvQ5LnuZwwJhgDvzs0BL8hvXKooo36aevU7822Huhr0evTz/m SU5bnW28BdJR/19mrzw== X-Proofpoint-ORIG-GUID: i87XqmDmmoKZWOeuiurfBzxByXF6_wnL X-Proofpoint-GUID: i87XqmDmmoKZWOeuiurfBzxByXF6_wnL X-Authority-Analysis: v=2.4 cv=Z/F5j3RA c=1 sm=1 tr=0 ts=6aa209cd cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=uHxescsG3rBdxcXwcPaeSg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=c3QgA-9rzyVlc7GNB-wA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-09_02,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100015 On 9/1/2026 4:36 AM, Konrad Dybcio wrote: > On 8/31/26 5:01 AM, Elson Serrao wrote: >> EUD functions by presenting itself as a USB device to the host PC and is >> therefore only applicable when the port operates in device role. Keeping >> EUD enabled in other roles provides no benefit and unnecessarily keeps >> the associated PHY resources enabled. Furthermore, enabling EUD in host >> role can cause the USB controller to misbehave because the EUD hub >> supports only a single upstream-facing port. > > [...] > >> struct eud_chip *chip = dev_get_drvdata(dev); >> + struct eud_path *path; >> bool enable; >> int ret; >> >> if (kstrtobool(buf, &enable)) >> return -EINVAL; >> >> + guard(mutex)(&chip->state_lock); > > GPT suggests port_store() should also take this lock.. I think that's > a valid concern > Thanks for the review, and apologies for the delayed response. I'll address this as well as the other relevant feedback from Sashiko in v8. Thanks, Elson