From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6C6C2B9F4 for ; Fri, 18 Jun 2021 00:45:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5392613B9 for ; Fri, 18 Jun 2021 00:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbhFRArd (ORCPT ); Thu, 17 Jun 2021 20:47:33 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:7478 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233320AbhFRArc (ORCPT ); Thu, 17 Jun 2021 20:47:32 -0400 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G5g9s5XV1zZhKb; Fri, 18 Jun 2021 08:42:25 +0800 (CST) Received: from [10.67.100.138] (10.67.100.138) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 18 Jun 2021 08:45:22 +0800 Subject: Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue To: Andrew Lunn CC: , , , , , , , References: <1623941615-26966-1-git-send-email-lipeng321@huawei.com> <1623941615-26966-6-git-send-email-lipeng321@huawei.com> From: "lipeng (Y)" Message-ID: <2ea3967f-b4e4-323b-bf65-aac108c6d27f@huawei.com> Date: Fri, 18 Jun 2021 08:45:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.138] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/6/18 0:29, Andrew Lunn 写道: >> @@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d) >> static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd) >> { >> /* struct z8530_dev *sv11=dev_to_sv(d); >> - z8530_ioctl(d,&sv11->chanA,ifr,cmd) */ >> + * z8530_ioctl(d,&sv11->chanA,ifr,cmd) >> + */ >> return hdlc_ioctl(d, ifr, cmd); >> } > That looks more like dead code than anything else. I would suggest you > do a git blame to see if there is anything interesting about this, and > if not, remove it. > > Andrew > . Hi,  Andrew It's  dead code,  will remove it. Thanks for your advice.         Peng Li