mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mete Durlu <meted@linux.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>
Cc: ruanjinjie@huawei.com, sshegde@linux.ibm.com
Subject: Re: [PATCH] sched: dynamic: Fix preemption model strings
Date: Sun, 6 Sep 2026 21:28:24 +0200	[thread overview]
Message-ID: <2eaa56ab-7013-4fc1-99f0-db9c7e4b5c5f@linux.ibm.com> (raw)
In-Reply-To: <20260902101637.232129-1-mark.rutland@arm.com>

On 02/09/2026 12:16, Mark Rutland wrote:
> We recently removed the enum values 'preempt_dynamic_none' and
> 'preempt_dynamic_voluntary', but forgot to update preempt_modes[]
> accordingly. Due to this, preempt_model_str() and sched_dynamic_show()
> produce incorrect output, with the wrong preemption model string in
> backtraces, and empty output for /sys/kernel/debug/sched/preempt.
> 
> Update preempt_modes[] to account for the removed enum values. Given
> that CONFIG_PREEMPT_DYNAMIC now depends on CONFIG_ARCH_HAS_PREEMPT_LAZY,
> and given that only 'preempt_dynamic_full' and 'preempt_dynamic_lazy'
> remain, sched_dynamic_show() no longer needs to skip any model strings.
> 
> Reported-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Fixes: 9650ce11f2e3 ("sched: dynamic: Simplify preempt model accessors")
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Hi,

I did a quick test on s390.

$ echo full > preempt
$ cat preempt
(full) lazy

$ echo lazy > preempt
$ cat preempt
full (lazy)

The sched_dynamic_show() output looks correct now, and the
code looks much nicer without those conditional indices.
Feel free to put my tested by.

Tested-by: Mete Durlu <meted@linux.ibm.com>


      parent reply	other threads:[~2026-09-06 19:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 10:16 Mark Rutland
2026-09-02 10:59 ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-09-06 19:28 ` Mete Durlu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eaa56ab-7013-4fc1-99f0-db9c7e4b5c5f@linux.ibm.com \
    --to=meted@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=ruanjinjie@huawei.com \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®