From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0521EB64D9 for ; Wed, 14 Jun 2023 12:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243841AbjFNMP5 (ORCPT ); Wed, 14 Jun 2023 08:15:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238034AbjFNMPx (ORCPT ); Wed, 14 Jun 2023 08:15:53 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 398E81BF9; Wed, 14 Jun 2023 05:15:51 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qh4BF5q4szTl45; Wed, 14 Jun 2023 20:15:17 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 20:15:48 +0800 Subject: Re: [PATCH net-next v4 1/5] page_pool: frag API support for 32-bit arch with 64-bit DMA To: Alexander Lobakin CC: , , , , , Lorenzo Bianconi , Alexander Duyck , Saeed Mahameed , Leon Romanovsky , Eric Dumazet , Jesper Dangaard Brouer , Ilias Apalodimas , References: <20230612130256.4572-1-linyunsheng@huawei.com> <20230612130256.4572-2-linyunsheng@huawei.com> <483d7a70-3377-a241-4554-212662ee3930@intel.com> <6db097ba-c3fe-6e45-3c39-c21b4d9e16ef@huawei.com> <16cc3a9d-bd05-5a9f-cb2e-7c6790ebd9fe@intel.com> From: Yunsheng Lin Message-ID: <2eb57144-1e51-239b-07b2-b6b3737e7497@huawei.com> Date: Wed, 14 Jun 2023 20:15:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <16cc3a9d-bd05-5a9f-cb2e-7c6790ebd9fe@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/14 18:52, Alexander Lobakin wrote: > From: Yunsheng Lin > Date: Wed, 14 Jun 2023 11:36:28 +0800 > >> On 2023/6/13 21:30, Alexander Lobakin wrote: >>> From: Yunsheng Lin >>> Date: Mon, 12 Jun 2023 21:02:52 +0800 > > [...] > >>> I addressed this in my series, which I hope will land soon after yours >>> (sending new revision in 24-48 hours), so you can leave it as it is. Or >>> otherwise you can pick my solution (or come up with your own :D). >> >> Do you mean by removing "#include " as dma-mapping.h >> has included dma-direction.h? > > By "I addressed" I meant that I dropped including page_pool.h from > skbuff.h, as I also had to include dma-mapping.h to page_pool.h and this > implied that half of the kernel started including dma-mapping.h as well > for no profit. I see, thank for the explanation. I perfer that you can continue with that effort if that is ok.