From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933126AbdHVOos (ORCPT ); Tue, 22 Aug 2017 10:44:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51704 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932647AbdHVOoq (ORCPT ); Tue, 22 Aug 2017 10:44:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C3EA5C047B8F Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=prarit@redhat.com Subject: Re: [PATCH 2/2 v7] printk: Add monotonic, boottime, and realtime timestamps To: Petr Mladek References: <1502975739-21328-1-git-send-email-prarit@redhat.com> <1502975739-21328-3-git-send-email-prarit@redhat.com> <6b265b2b-130a-c19b-1f68-b12895e1c17e@android.com> <8eb770a9-1068-c239-6131-97b64c2944dc@redhat.com> <20170822142322.GD30286@pathway.suse.cz> Cc: Mark Salyzyn , linux-kernel@vger.kernel.org, Jonathan Corbet , Sergey Senozhatsky , Steven Rostedt , John Stultz , Thomas Gleixner , Stephen Boyd , Andrew Morton , Greg Kroah-Hartman , "Paul E. McKenney" , Christoffer Dall , Deepa Dinamani , Ingo Molnar , Joel Fernandes , Kees Cook , Peter Zijlstra , Geert Uytterhoeven , "Luis R. Rodriguez" , Nicholas Piggin , "Jason A. Donenfeld" , Olof Johansson , Josh Poimboeuf , linux-doc@vger.kernel.org From: Prarit Bhargava Message-ID: <2eb99e80-316b-fbe6-8acb-3f1f25fcf278@redhat.com> Date: Tue, 22 Aug 2017 10:44:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170822142322.GD30286@pathway.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 22 Aug 2017 14:44:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22/2017 10:23 AM, Petr Mladek wrote: > On Tue 2017-08-22 10:09:40, Prarit Bhargava wrote: >> >> >> On 08/17/2017 11:30 AM, Mark Salyzyn wrote: >>> On 08/17/2017 06:15 AM, Prarit Bhargava wrote: >>>> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock >>>> timestamp to printk messages. The local hardware clock loses time each >>>> day making it difficult to determine exactly when an issue has occurred in >>>> the kernel log, and making it difficult to determine how kernel and >>>> hardware issues relate to each other in real time. >>> Congrats, greatly eases merges into older kernels, and has eliminated the churn >>> this could place on all the configured systems out there. >>> >>> Sadly, one of my suggestions did not quite go the way I expected ;-} easy to >>> correct, and fix (I missed a spot in my original suggestion, as code changed >>> underfoot over the set ;-/). (see bottom) >> >> Added. I will send out v8 shortly. > > It might make sense to wait a bit. I am in the middle of v7 review and > have several comments. > > I would suggest to slow down this a bit anyway. You sent 7 versions > within three weeks. It improved nicely over time. But I think that > I am not the only one who has troubles to follow. > np Petr. I will hold off on v8. P. > Best Regards, > Petr >