From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F40C433EF for ; Wed, 15 Jun 2022 11:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344007AbiFOLhy (ORCPT ); Wed, 15 Jun 2022 07:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238902AbiFOLhv (ORCPT ); Wed, 15 Jun 2022 07:37:51 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD7C1DF24; Wed, 15 Jun 2022 04:37:48 -0700 (PDT) X-UUID: c550a61701c040059b400e38c022eb83-20220615 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:ffad2b5b-bc98-45b5-9434-7d55d7ba2b24,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71,CLOUDID:8ae09848-4c92-421c-ad91-b806c0f58b2a,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: c550a61701c040059b400e38c022eb83-20220615 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1136781896; Wed, 15 Jun 2022 19:37:45 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 15 Jun 2022 19:37:43 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 15 Jun 2022 19:37:42 +0800 Message-ID: <2ebaa25205d651b2f6a62e3a02c0ccab5199a165.camel@mediatek.com> Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: "yunfei.dong@mediatek.com" To: Nicolas Dufresne , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa CC: George Sun , Xiaoyong Lu , Hsin-Yi Wang , "Fritz Koenig" , Daniel Vetter , dri-devel , Irui Wang , "Steve Cho" , , , , , , Date: Wed, 15 Jun 2022 19:37:41 +0800 In-Reply-To: References: <20220512034620.30500-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, Thanks for your comments. On Mon, 2022-06-13 at 16:10 -0400, Nicolas Dufresne wrote: > > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > Firstly, add mt8186 compatible and private data, then add document > > for > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > > architecture, need to add new interface for h264 hardware decoder. > > Would be nice to take the habit of sharing fluster score for this new > HW, I > would expect no less then what the numbers you'd get from running > over MT8195 or > 92, remains nice to demonstrate that this was tested and document any > oops along > the way. For we don't setup mt8186 fluster test environment. So not to run fluster in mt8186. According to our plan, we will do fluster test for every project begin from mt8188. When I'm free, we continue to setup the fluster test environment for mt8186. Thanks, Yunfei Dong > > Patche 1 add mt8186 compatible and private data. > > Patche 2 add mt8186 compatible document. > > Patche 3 add h264 single core driver. > > --- > > This patch depends on "support for MT8192 decoder"[1] > > > > [1] > > https://patchwork.kernel.org/project/linux-mediatek/cover/20220512021950.29087-1-yunfei.dong@mediatek.com/ > > --- > > changed with v3: > > - fix __iomem not reasonable, align share memory to dram. > > changed with v2: > > - fix sparse and smatch check fail for patch 3 > > changed with v1: > > - rebase driver to the latest media_stage. > > --- > > Yunfei Dong (3): > > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings > > for > > mt8186 > > media: mediatek: vcodec: Support MT8186 > > media: mediatek: vcodec: add h264 decoder driver for mt8186 > > > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 > > +++++++++++++++++- > > 5 files changed, 203 insertions(+), 2 deletions(-) > > > >