From: "Arnd Bergmann" <arnd@arndb.de>
To: "Zhu Yanjun" <yanjun.zhu@linux.dev>,
"Arnd Bergmann" <arnd@kernel.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Yevgeny Kliteynik" <kliteyn@nvidia.com>,
"Alex Vesker" <valex@nvidia.com>,
"Hamdan Igbaria" <hamdani@nvidia.com>,
Netdev <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: fix possible stack overflows
Date: Thu, 15 Feb 2024 09:03:02 +0100 [thread overview]
Message-ID: <2ebe5a36-ce81-4d26-a12b-7affbd65c5e3@app.fastmail.com> (raw)
In-Reply-To: <84874528-daea-424d-af63-b9b86835fae6@linux.dev>
On Thu, Feb 15, 2024, at 01:18, Zhu Yanjun wrote:
> 在 2024/2/13 18:08, Arnd Bergmann 写道:
>> static int
>> -dr_dump_rule_rx_tx(struct seq_file *file, struct mlx5dr_rule_rx_tx *rule_rx_tx,
>> +dr_dump_rule_rx_tx(struct seq_file *file, char *buff,
>> + struct mlx5dr_rule_rx_tx *rule_rx_tx,
>> bool is_rx, const u64 rule_id, u8 format_ver)
>> {
>> struct mlx5dr_ste *ste_arr[DR_RULE_MAX_STES + DR_ACTION_MAX_STES];
>> @@ -533,7 +532,7 @@ dr_dump_rule_rx_tx(struct seq_file *file, struct mlx5dr_rule_rx_tx *rule_rx_tx,
>> return 0;
>>
>> while (i--) {
>> - ret = dr_dump_rule_mem(file, ste_arr[i], is_rx, rule_id,
>
> Before buff is reused, I am not sure whether buff should be firstly
> zeroed or not.
I don't see why it would, but if you want to zero it, that would be
a separate patch that is already needed on the existing code,
which never zeroes its buffers.
Arnd
next prev parent reply other threads:[~2024-02-15 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 10:08 Arnd Bergmann
2024-02-14 20:34 ` Jacob Keller
2024-02-15 0:18 ` Zhu Yanjun
2024-02-15 8:03 ` Arnd Bergmann [this message]
2024-02-16 0:43 ` Zhu Yanjun
2024-02-19 9:05 ` Hamdan Agbariya
2024-02-19 12:19 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ebe5a36-ce81-4d26-a12b-7affbd65c5e3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hamdani@nvidia.com \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=valex@nvidia.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®