From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B854E18EB0 for ; Mon, 30 Dec 2024 13:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565632; cv=none; b=W4K7eZ6bSLZqhI0Q4i2MA9d2R9aA9yodysfrkGTf79qob+X1QwiWtHeLyFenxQVSy9iULtXM+9YwqV+ejGiXDr+wNJeidfslgtzN+WwM4p2wpxZgJy1U8DKxL/qf+a+dUlflq52qhpYCRGyDwpiKhrB6YO969sAfhCXZN3K+/zs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565632; c=relaxed/simple; bh=HGb6bwX20d0y0kEwKOwOzl/emWna6kiI8/3r6L/10iE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DwB0V8sgafHSpEtld+cf8A1ParblSf/uNgoIpnsibfgb90f53DgsaUgnlLkeEgoONqZ22EXjpX83CpFisSheE5P0G5hDH/Dw0uVokaKmIfgAAOIQ3g/E7Awu7qIWpxaSrA9riIIDwcNoik1+P1+4nChJbo7LjoYoAR+WkNms4zU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G+bYM/6D; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G+bYM/6D" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BU7G7PK027918 for ; Mon, 30 Dec 2024 13:33:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EbOPV4gqNqmGQXQo27/FmMyL71tlrIDPYuT+OGI2Sig=; b=G+bYM/6DdengpT8b 5CBEFyjPWxkUzj/RlRVIY3xfSr9Td6RndRDg+gfILES/6qtsU5G58ukFgbN1l3Lh /0g+g+/Wp68kplJRlqcqRoBhzZm46eFK/ZOhCseBAMKTqBYJeUFEfNpBRutXUbaR hyEnqDftZf5ZGsJq8RIpuU75brqWJmWzM3lH6wxikM17J760nvcUbbItX06vqdUQ 1eu2wLHFT+xW+DHOAlbSR5/01vdOIiDWx6x3CdbEC2Bto2u2gqiuIPTXuAfEoZP1 SQxOQnf1X6ipD3NMIesmRWx5vXdV5l/UtqAV4RjHvkRzVQJyuoeU0UodmFHK8KW0 UJ7D9g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43upyr8r8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Dec 2024 13:33:49 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4679d6f9587so29734671cf.1 for ; Mon, 30 Dec 2024 05:33:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735565628; x=1736170428; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EbOPV4gqNqmGQXQo27/FmMyL71tlrIDPYuT+OGI2Sig=; b=shGxJw00DziZyx3XCY2OlqK+U+H+XIkyfcMp2mrzTx1qV3ALA2YC6kfJhfVWw6jLee bp52smJsMKE3CWV0hZ+haBc4WfC2JQNpBSd55TnuoZZ7PqUc0JOdDT8WPOx5FDqSDFDo JEYfOEPVC79d5+vJxFHnUKi0HJFnAY/jKTY+R57fih8Iez2lSh233qNV7pf/FYGMYjiP 3T6S+y+1Ug1/sTtUruq0saqYXRpEki8OXg3pr75dcK/AxmPEJKHy6VF9PGFuHl7KB2xh oT8AI8ZckczVWZsVtV1WvCMaTK/oIq+LpYGwmEUvkHqlqqAx6rOTiruQ2VHSlIo4GJFm KVYA== X-Forwarded-Encrypted: i=1; AJvYcCUwx7r9JvjFT75FkRd/DJ/YevQ6s+wpH+t1FMppFswuN/TYCERXzaQRQEjQW9kM75/P3LJjr2Jxs277bEk=@vger.kernel.org X-Gm-Message-State: AOJu0YzZeSg3ONVRRZ2CtVTwMMFC7yPPQLvUYTpV7+gm0NcsX/glYhg8 WbfCusvLEm8Kl/bCON51VH3uJurrawAFgckUAOSz/k4hQcy030XwamtbaQIkBvQm+f6uoMZnESs 0R02lsLjj4M8TNKmSuGWu1hdknc53GhDo1fkYWPJKoxJVh38tuK5F2VPiAW5ZX1k= X-Gm-Gg: ASbGncvAke5j8G3t3nJQYBa0wlWV3ongdV9Tmg5pr39Uif96yvXyOGoqJ82QEY6u4hK YLI9bwP0SgGXDM/RJurJWpU19ZXrZDxYF09CrdTbt1xQ4h7JiFCjpLxyO+Z9BOmcFiuBvWIzRIb 4gr6/YmYuHVDNBNSApbeHiJDALcGLkfKTTNFNhCOpznA6/trjneX1b9fPq0g0uG1TOmP8vb2Qyg 1ymChGi8IobdGlGBuFyaTZLq24eSE5Ww8mk7pPOfJPidIMxY3GJahiizpEEt/MC+FJZnHCmQaL0 fx8/Vye2619oTQPlQwp0eLsYxNGhqKsPUfE= X-Received: by 2002:ac8:5d07:0:b0:467:6eee:1138 with SMTP id d75a77b69052e-46a4a8cdd91mr216166371cf.6.1735565628552; Mon, 30 Dec 2024 05:33:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPKjPl0dgBxEjH5BKFomyDlmgGJotQE46CTwVku3D1K7pHx64/HPSVoHIJLOrxaV6ZMe8PzQ== X-Received: by 2002:ac8:5d07:0:b0:467:6eee:1138 with SMTP id d75a77b69052e-46a4a8cdd91mr216166171cf.6.1735565628178; Mon, 30 Dec 2024 05:33:48 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f06c7a8sm1485864566b.182.2024.12.30.05.33.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 05:33:47 -0800 (PST) Message-ID: <2ec46ef4-16d8-4421-a086-7a9177d5ea6d@oss.qualcomm.com> Date: Mon, 30 Dec 2024 14:33:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/19] Disable USB U1/U2 entry for QC targets To: Prashanth K , Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, cros-qcom-dts-watchers@chromium.org References: <20241218102707.76272-1-quic_prashk@quicinc.com> <756d26dc-da89-4478-acf9-136f662874d1@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <756d26dc-da89-4478-acf9-136f662874d1@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: X0gqkbfrwsRs2eWXWQ7IVRMxRhouug1U X-Proofpoint-ORIG-GUID: X0gqkbfrwsRs2eWXWQ7IVRMxRhouug1U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=674 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412300117 On 26.12.2024 5:55 AM, Prashanth K wrote: > > > On 26-12-24 10:13 am, Bjorn Andersson wrote: >> On Wed, Dec 18, 2024 at 03:56:48PM +0530, Prashanth K wrote: >>> Enabling U1 and U2 power-saving states can lead to stability and >>> performance issues, particularly for latency-sensitive or high- >>> throughput applications. These low-power link states are intended >>> to reduce power consumption by allowing the device to enter partial >>> low-power modes during idle periods. However, they can sometimes >>> result in unexpected behavior. Over the years, some of the issues >>> seen are as follows: > > [...] > >>> Krishna Kurapati (8): >>> arm64: dts: qcom: Disable USB U1/U2 entry for SM8350 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SM8450 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SM8150 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SM6125 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SM8250 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SM6350 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SC7280 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SA8775P >> >> Thank you for submitting this, changes looks good and this is very >> welcome corrections! >> >> But patch subject is not okay. The prefix should match other changes in >> these files, and no "for XYZ" suffix. >> >> As such, these should all look like: >> >> "arm64: dts: qcom: : Disable USB U1/U2 entry" >> >>> >>> Prashanth K (11): >>> arm64: dts: qcom: Disable USB U1/U2 entry for SDM630 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SDM845 >>> arm64: dts: qcom: Disable USB U1/U2 entry for SDX75 >>> ARM: dts: qcom: Disable USB U1/U2 entry for SDX65 >>> ARM: dts: qcom: Disable USB U1/U2 entry for SDX55 >> >> I merge Arm and Arm64 patches through different trees, so I would >> appreciate if you send these two as a separate series (also v4). >> > > Sure, will update the subject for all patches, and split it into 2 > series (v4 for for both arm and arm64). I hope its fine to keep the > Reviewed-by tag from Konrad on next version. Yes, you can usually feel free to keep tags, unless there's major changes Konrad