mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Brandt, Todd E" <todd.e.brandt@intel.com>
To: "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
	"xi.pardee@linux.intel.com" <xi.pardee@linux.intel.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/x86/intel/pmc Fix Arrow Lake U/H support to intel_pmc_core driver
Date: Tue, 20 May 2025 10:45:29 +0000	[thread overview]
Message-ID: <2ec5a9b0623e7f68ef37627f8f8a41b950a6c178.camel@intel.com> (raw)
In-Reply-To: <174773612605.1880.7682337143207967545.b4-ty@linux.intel.com>

On Tue, 2025-05-20 at 13:15 +0300, Ilpo Järvinen wrote:
> On Fri, 16 May 2025 10:05:07 -0700, Todd Brandt wrote:
> 
> > The ARL requires that the GMA and NPU devices both be in D3Hot in
> > order
> > for PC10 and S0iX to be achieved in S2idle. The original ARL-H/U
> > addition
> > to the intel_pmc_core driver attempted to do this by switching them
> > to D3
> > in the init and resume calls of the intel_pmc_core driver.
> > 
> > The problem is the ARL-H/U have a different NPU device and thus are
> > not
> > being properly set and thus S0iX does not work properly in ARL-H/U.
> > This
> > patch creates a new ARL-H specific device id that is correct and
> > also
> > adds the D3 fixup to the suspend callback. This way if the PCI
> > devies
> > drop from D3 to D0 after resume they can be corrected for the next
> > suspend. Thus there is no dropout in S0iX.
> > 
> > [...]
> 
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed
> my
> local branch there, which might take a while.

I've made one simplification that I'm about to push on Xi's suggestion.
> 
> The list of commits applied:
> [1/1] platform/x86/intel/pmc Fix Arrow Lake U/H support to
> intel_pmc_core driver
>       commit: 219aadc94ba0bddc1355ce5c5abba7fc96e758a2
> 
> --
>  i.
> 


      reply	other threads:[~2025-05-20 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 17:05 Todd Brandt
2025-05-20 10:15 ` Ilpo Järvinen
2025-05-20 10:45   ` Brandt, Todd E [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ec5a9b0623e7f68ef37627f8f8a41b950a6c178.camel@intel.com \
    --to=todd.e.brandt@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=xi.pardee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®