mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Philippe Simons <simons.philippe@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: axp20x: AXP717: set ramp_delay
Date: Fri, 6 Dec 2024 12:48:47 +0000	[thread overview]
Message-ID: <2ec677db-2db8-4a74-af76-d8ff1f4b2173@sirena.org.uk> (raw)
In-Reply-To: <20241206123751.981977-1-simons.philippe@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

On Fri, Dec 06, 2024 at 01:37:51PM +0100, Philippe Simons wrote:
> AXP717 datasheet says that regulator ramp delay is 15.625 us/step,
> which is 10mV in our case.

>  static const struct regulator_desc axp717_regulators[] = {
> +	AXP_DESC_RANGES_DELAY(AXP717, DCDC1, "dcdc1", "vin1",
> +			AXP717_DCDC_OUTPUT_CONTROL, BIT(0), 640),

This doesn't seem to match with the above - ramp_delay is in units of
uV/us?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2024-12-06 12:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 12:37 Philippe Simons
2024-12-06 12:48 ` Mark Brown [this message]
2024-12-06 12:54   ` Philippe Simons
2024-12-06 13:44     ` Mark Brown
2024-12-06 13:47       ` Philippe Simons
2024-12-07  3:58 ` Hironori KIKUCHI
2024-12-07  4:37 ` Chen-Yu Tsai
2024-12-07  9:18   ` Philippe Simons
2024-12-07 17:40 ` Chris Morgan
2024-12-10 13:00 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ec677db-2db8-4a74-af76-d8ff1f4b2173@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simons.philippe@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®