From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E431034D4D2; Thu, 2 Apr 2026 15:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775143267; cv=none; b=WUSAo5eIAViCTe/tekZhepaUGoD/ODfUwGiO199IgCuY7DRwOOG6JQ50i+ww9gMG7NLzRZZQ0aV/Ptv5/Ks4IM68wN5ysGhwYluZXmzEFSgFm1mMPhM+dxwbDMoORRufqsPeTd4m1k3ukMc9w80wnsv9Z8ALsv9T0mqUd3WHuOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775143267; c=relaxed/simple; bh=Atdp2Yq+vZCgGPsLZHwP7QsHnIJ5JB+7tYSeJ6kp9l0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JhWZASZUNZtYnVoegTQwEr1TpHnBnuA5y/P+sT1n/T1AK/JMB0NDtxQy4vJNNi+8/+M3r5PxtkjhgsomtsvUL7mMtTN1Yc8KlQHHjY5JDgCEhmI4dMHliqCOULctKhVuU0yRxSHawZM4Z2n8h6z5gjlDENpN7csptd+Cz0nH6BQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XmkF6trv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XmkF6trv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89CC9C116C6; Thu, 2 Apr 2026 15:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775143266; bh=Atdp2Yq+vZCgGPsLZHwP7QsHnIJ5JB+7tYSeJ6kp9l0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XmkF6trvPGaoNBOFUq8cHYVKBAwUkaJ9Ml+6u4twA2M2M5s3Q6gHycRVNkBOMJjZB mbJouLW2pyMHlWJQ7JdWPQnFRo/vp0Vkn9bLOdvDDPPUR3leEvl/Dv2uQP2PSfY3M+ k+L0/3DJGyLdJ2GwMM6e2GTcFrgl3Kgdm6W4G41Hk3qtvFmCzlH1kj3Oni0AyHqcEE av0fuXi5U1/HM1hXHLInEx9wPVU1obh20gFaNy9M7IPSoXJ9XyuTHxDJzZCNp8PndC 5mJWGTC4BEtruMawXBNMLaaO0NzykwxkDaig/BLYfl3uEhemeirthSRK+EeO9yehVF qdeNrnho5hDzg== Date: Thu, 2 Apr 2026 16:20:53 +0100 From: "Lorenzo Stoakes (Oracle)" To: Suren Baghdasaryan Cc: Andrew Morton , willy@infradead.org, david@kernel.org, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, vbabka@suse.cz, jannh@google.com, rppt@kernel.org, mhocko@suse.com, pfalcato@suse.de, kees@kernel.org, maddy@linux.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au, chleroy@kernel.org, borntraeger@linux.ibm.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, svens@linux.ibm.com, gerald.schaefer@linux.ibm.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v6 2/6] mm: use vma_start_write_killable() in mm syscalls Message-ID: <2ecac69c-9fe3-4c29-aea6-c20d21773940@lucifer.local> References: <20260327205457.604224-1-surenb@google.com> <20260327205457.604224-3-surenb@google.com> <5d90d998-9b8d-435c-b684-260600311797@lucifer.local> <20260331112921.854d4f6cc793dba0972ee9f1@linux-foundation.org> <495a4331-6575-4eb5-91a5-245ab0ad3637@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Apr 02, 2026 at 08:11:44AM -0700, Suren Baghdasaryan wrote: > On Thu, Apr 2, 2026 at 6:19 AM Lorenzo Stoakes (Oracle) wrote: > > > > On Tue, Mar 31, 2026 at 01:14:51PM -0700, Suren Baghdasaryan wrote: > > > On Tue, Mar 31, 2026 at 11:47 AM Lorenzo Stoakes (Oracle) > > > wrote: > > > > > > > > On Tue, Mar 31, 2026 at 11:29:21AM -0700, Andrew Morton wrote: > > > > > On Tue, 31 Mar 2026 08:01:11 -0700 Suren Baghdasaryan wrote: > > > > > > > > > > > > Instead? That is, assuming we really need to care about this at all. > > > > > > > > > > > > > > But I think I don't like this change at all? > > > > > > > > > > > > Yeah, this was the part I wasn't sure if it's worth adding. With your > > > > > > vote confirming my scepticism I'll go ahead and remove the parts I > > > > > > added to avoid extra vma_start_write_killable() call (3 instances in > > > > > > all) and will post v7. > > > > > > > > > > Thanks. I'll remove v6 from mm.git and shall await Lorenzo's advice on > > > > > v7. > > > > > > > > > > > > > Ack, if we just drop the problematic bits we might still be fine for 7.1 :) > > > > > > Let's get your cleanup first and then see where we are. I also hate > > > the way I have to report a fake error code, so with that cleanup the > > > patchset should be much nicer. > > > > Ack, yeah it's horrid, + _my fault_ :) > > No worries, I can wait. > > > > > I can put something together now perhaps that can potentially be queued up for > > 7.2 at 7.1-rc1. > > Thanks! That would be appreciated. This might not quite be 'now' as of course it's grown into something much bigger :P Cheers, Lorenzo