mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Brent Casavant <bcasavan@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: [PATCH 11/12] MISC: IOC4: Fix section mismatch / race condition.
Date: Mon, 27 Jun 2011 14:35:01 +0100	[thread overview]
Message-ID: <2ecba7369d1ac0d7b1ab08ccce65f240719f99c8.1309182743.git.ralf@linux-mips.org> (raw)
In-Reply-To: <17dd5038b15d7135791aadbe80464a13c80758d3.1309182742.git.ralf@linux-mips.org>

WARNING: drivers/misc/ioc4.o(.data+0x144): Section mismatch in reference from the variable ioc4_load_modules_work to the function .devinit.text:ioc4_load_modules()
The variable ioc4_load_modules_work references
the function __devinit ioc4_load_modules()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

This one is potencially fatal; by the time ioc4_load_modules is invoked
it may already have been freed.  For that reason ioc4_load_modules_work
can't be turned to __devinitdata but also because it's referenced in
ioc4_exit.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
To: Brent Casavant <bcasavan@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
---
 drivers/misc/ioc4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/ioc4.c b/drivers/misc/ioc4.c
index 668d41e..df03dd3 100644
--- a/drivers/misc/ioc4.c
+++ b/drivers/misc/ioc4.c
@@ -270,7 +270,7 @@ ioc4_variant(struct ioc4_driver_data *idd)
 	return IOC4_VARIANT_PCI_RT;
 }
 
-static void __devinit
+static void
 ioc4_load_modules(struct work_struct *work)
 {
 	request_module("sgiioc4");
-- 
1.7.4.4


  parent reply	other threads:[~2011-06-27 15:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26 11:19 [PATCH 00/12] Fix various section mismatches and build errors Ralf Baechle
2011-06-26 11:19 ` [PATCH 01/12] SCSI: sim710: Fix section mismatch Ralf Baechle
2011-06-26 11:21 ` [PATCH 02/12] NET: 3c509: " Ralf Baechle
2011-06-26 11:22 ` [PATCH 03/12] NET: 3c59x: " Ralf Baechle
2011-06-26 11:23 ` [PATCH 04/12] NET: depca: Fix bucketload full of section mismatches Ralf Baechle
2011-06-26 11:26 ` [PATCH 06/12] NET: ne3210: " Ralf Baechle
2011-06-26 11:28 ` [PATCH 07/12] NET: de4x5: Fix section mismatch Ralf Baechle
2011-06-26 11:30 ` [PATCH 08/12] LED: lp5521: Fix section mismatches Ralf Baechle
2011-06-26 11:31 ` [PATCH 09/12] LED: lp5523: " Ralf Baechle
2011-06-27 13:26 ` [PATCH 10/12] SERIAL: SC26xx: Fix link error Ralf Baechle
2011-06-28  8:25   ` Alan Cox
2011-06-27 13:35 ` Ralf Baechle [this message]
2011-06-27 15:57   ` [PATCH 11/12] MISC: IOC4: Fix section mismatch / race condition Brent Casavant
2011-06-27 13:40 ` [PATCH 12/12] DRM: Radeon: Fix section mismatch Ralf Baechle
2011-06-28  5:12 ` [PATCH 00/12] Fix various section mismatches and build errors David Miller
2011-06-29 13:07   ` Ralf Baechle
2011-06-29 13:58     ` James Bottomley
2011-06-29 15:14       ` Greg KH
2011-06-29 16:19         ` Ralf Baechle
2011-06-29 17:24           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ecba7369d1ac0d7b1ab08ccce65f240719f99c8.1309182743.git.ralf@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@linux-foundation.org \
    --cc=bcasavan@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®