From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7248729405 for ; Wed, 27 May 2026 15:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779896479; cv=none; b=ZUQRPfKe0ODv0csd2ouK6nkJzsy3dBQFDxk2Cp4HWzhnm73f6W6+ejykRpV7at2HeHn1VGXxCNOWyWNi0lWdfEkwCwTpHt2pHiq38ETHuPh1/YeRS678vfMQkljv4DsyinF8SIJvuwFpFcbRz4iudWx6J8BO+qSeZhQBmWKNcNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779896479; c=relaxed/simple; bh=3wvcIcwpDy8klqAi5rwKWE4KRZpXGJZL24M54fA5hdE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qVOKDof8zfwuR1cWO7mTdWAHh5beG1Ngl0gifngxS+ng1hoAhSgF8kXixs0EHPfZVUnLqEuKRMKu5NonRVlhi3CB7yoT+LPs46f8kW1NjPvfT3Bwm4Mg3IabTxO1GSwznSoC9UlFlicRyX8+MBxU6mCPFcgYMTU3UBN0tUQjH2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b=GEnwN/FA; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b="GEnwN/FA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oikUtBRFh/gGkdwzqzvGVc48zMkmVITOctUzSsP8HHk=; b=GEnwN/FAU0Tlq02oj3pLcpuzji +kRli8umqeCjmk8Bx0fB4zeC7dar9/rXPYOT9iER+KSmtPh1wZX4+bSxqA4A7QUFNbm/vuTPEoV0H t+p++TWHiGBpMD56VidMG/OxCEbW2JRkmZV0vrLZ1lil12Wua/81eniQsLDfhwXOYQ8+dclFv/6WE QecROif82UlI2ySdP/ogG91qgIRHgR13/TIRODYP/0DGv7qEz8KP8KGuMpqs4N3ksosySwP+/6BiN 60dh16nTjptoRt0k628WKTOiDJ3a3jaeIshOjc2WgtkQ1XneGkQMgYZxnR+sHVrjusWYuLDOTz/tP I4UOS1Xw==; Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1wSGNV-000000005VD-2o8E; Wed, 27 May 2026 11:41:05 -0400 Message-ID: <2ecf71858845e7d14c718b1a6845389cb78b986e.camel@surriel.com> Subject: Re: [RFC PATCH 05/40] mm: page_alloc: remove watermark boost mechanism From: Rik van Riel To: Usama Arif Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, david@kernel.org, willy@infradead.org, surenb@google.com, hannes@cmpxchg.org, ljs@kernel.org, ziy@nvidia.com, fvdl@google.com Date: Wed, 27 May 2026 11:41:05 -0400 In-Reply-To: <20260526140204.1390573-1-usama.arif@linux.dev> References: <20260526140204.1390573-1-usama.arif@linux.dev> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-05-26 at 07:02 -0700, Usama Arif wrote: > On Wed, 20 May 2026 10:59:11 -0400 Rik van Riel > wrote: >=20 > > @@ -7187,14 +7117,6 @@ static const struct ctl_table > > page_alloc_sysctl_table[] =3D { > > =C2=A0 .proc_handler =3D min_free_kbytes_sysctl_handler, > > =C2=A0 .extra1 =3D SYSCTL_ZERO, > > =C2=A0 }, > > - { > > - .procname =3D "watermark_boost_factor", > > - .data =3D &watermark_boost_factor, > > - .maxlen =3D > > sizeof(watermark_boost_factor), > > - .mode =3D 0644, > > - .proc_handler =3D proc_dointvec_minmax, > > - .extra1 =3D SYSCTL_ZERO, > > - }, >=20 >=20 > This is a userspace-visible removal. Writes to > /proc/sys/vm/watermark_boost_factor will now return -ENOENT instead > of being > accepted, breaking userspace. >=20 > I am not sure whats been done in the past, but we need to add a > Documentation/ABI/removed/ note explaining what replaces it (SPB > steering). > and also maybe keep the sysctl entry as a no-op with warning for a > few > cycles before deletion? I'll just drop this patch for now. While we no longer need it, and the watermark boosting can cause a little bit of harm at times, this probably isn't worth the extra code churn in this series. --=20 All Rights Reversed.