From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3AEC001DE for ; Sun, 13 Aug 2023 15:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbjHMPY7 (ORCPT ); Sun, 13 Aug 2023 11:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjHMPY5 (ORCPT ); Sun, 13 Aug 2023 11:24:57 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AF97E0; Sun, 13 Aug 2023 08:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=D6GK4r3g2pMNaj1/iMHxZq3AeQCZgFzlhT3OyuIGXJg=; b=uRaBb/AjtZ/XDK/WInjRB3JU3o 6m1Wl7WsYf6RGEtONjYbrd/7QyYu6c5BD4/xibXyQvgO7IhbBfjPnsfsQZcS6PI3yCfuYtqEjCSDc ila7+dAYUp4jG02OEh/FfPskHSsqoYuKlBRhuu983PnIRovYNRIDZ+tSL4tRFKt2iPc8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qVCxZ-003yRr-Jv; Sun, 13 Aug 2023 17:24:53 +0200 Date: Sun, 13 Aug 2023 17:24:53 +0200 From: Andrew Lunn To: Keguang Zhang Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Serge Semin , Kelvin Zhang Subject: Re: [PATCH 0/5] Move Loongson1 MAC arch-code to the driver dir Message-ID: <2ed268fd-113a-4da0-8f33-04d618053dca@lunn.ch> References: <20230812151135.1028780-1-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812151135.1028780-1-keguang.zhang@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 12, 2023 at 11:11:30PM +0800, Keguang Zhang wrote: > From: Kelvin Zhang > > In order to convert Loongson1 MAC platform devices to the devicetree > nodes, Loongson1 MAC arch-code should be moved to the driver dir. > > In other words, this patchset is a preparation for converting > Loongson1 platform devices to devicetree. It is a long time since i converted an ARM system from platform data to DT. But what we tended to do was to allow both for a period of time. Does a system using platform data still work after this change? The first patch seems to delete a lot of code, not just move it around. Can you restructure this patchset to add the glue layer and DT binding in parallel with platform data. Then have a patchset which convert all in tree machines to using DT. And then a patchset, submitted in maybe 6 months time, to remove support for platform data. Andrew