From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E7F6F06B; Sat, 2 Nov 2024 02:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730513695; cv=none; b=GaHCsJYERfcZ3zoKNIDRVwqE9EsjKpiyQpVe7DhC7CnVXNIlW0iDx5ieMsUpie/6/q1mWAfSUe2X1fTpa5amTKy9kWgiRsGinan3qrk5Rc3HQk5jIduzrkN1FB/PE8o8UPnuffKlFiTfvpFuS5FAEjxQDKIUIsPlo39DS1X/0HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730513695; c=relaxed/simple; bh=7hIetJ7ZLmuC8PhP+rP6R3U697SB2sqjDj/ChX+YRXo=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=vAgs29+pSW+foL/55ktMFAKhqgV+bebdsP6GpHi+e6dLF+s7K+U58inTm5R4ssi2BEhiBbRQgjeZoGMqHNe7Tzebri9YOXRfRSAXa6H50UgF4WD9vDmcjsQfnl9E50JreHodOm/VUW2/KcfuMqvpIAAEq0miSyxwe8NEsysY9mo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=squebb.ca; spf=pass smtp.mailfrom=squebb.ca; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b=hnqA5leK; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=E0vdTR9s; arc=none smtp.client-ip=202.12.124.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=squebb.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=squebb.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b="hnqA5leK"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="E0vdTR9s" Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 5B0D325400FC; Fri, 1 Nov 2024 22:14:52 -0400 (EDT) Received: from phl-imap-10 ([10.202.2.85]) by phl-compute-02.internal (MEProxy); Fri, 01 Nov 2024 22:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1730513692; x=1730600092; bh=CkrPl1J6C0IRjJJqxSDvwcu6yt6xdBEFuHH1XZwtxT4=; b= hnqA5leKwpfDw02iQCa76dsOowb09WlDqiQFWenoB/VjM0L/7gKBFk7EugXuXJcC FLuD9hKPuOxPSojdkiiuS2dkfBsdd5fb+uzLAz47y9bNHZsCia//MC+h/atm0bMD zuvZZIuL+IJfjocmCl6NtWBJnbB8aXHSVj0qgLRVu7Ou9REZhKdEnIq2EBStgqw5 tVjoZJAzzWHf1zalkhB5KYBVjZOD7HVc+esvCfoVoPnrZ70Vnn0AmMYxt0afPTwH EpNTpY2TsXUik2eU9nShcUQ3lg2GXIODam2uLUhJPs4oAJbxu+GxzyHzMAJu+MNP jQoDWOLeZTJnXsWHbgXpUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730513692; x= 1730600092; bh=CkrPl1J6C0IRjJJqxSDvwcu6yt6xdBEFuHH1XZwtxT4=; b=E 0vdTR9sQnVY1R8BWJXyoutjE/6jAeOnABNkeJYtuC6f4VufKx/m5l3+Izsphqixx TnCEvWDMo4cHZ2ioWhC3YzJPbepVWTYSkSMXar6IfiNwQAz0EpIoaiqSNWHEY0V8 OuV2BsYvQj3TjkzU9edUX0mJMeOCCE4AWc//RfB0g7A7SBqDlsTTjnc9+PgQbuWZ sJFgWZ150Kcw3nsMt69XWlMhTH2AnESGnZv81fox8vCPNZdbeNxq9cPc8acgHgmo OTiHbHQ6rvpxU8Ge4kISU8tNxbatMiaa/bUG4w6XwsjNVtKJTBcXii3azPxUnG4e Sp+X9qKABrfpDqR4J67YA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeltddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedfofgrrhhkucfrvggrrhhsohhnfdcuoehmphgvrghrshhonhdqlhgvnh hovhhosehsqhhuvggssgdrtggrqeenucggtffrrghtthgvrhhnpefhuedvheetgeehtdeh tdevheduvdejjefggfeijedvgeekhfefleehkeehvdffheenucevlhhushhtvghrufhiii gvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmphgvrghrshhonhdqlhgvnhhovhho sehsqhhuvggssgdrtggrpdhnsggprhgtphhtthhopedvuddpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepshhhhigrmhdqshhunhgurghrrdhsqdhksegrmhgurdgtohhmpdhr tghpthhtohepmhgrrhhiohdrlhhimhhonhgtihgvlhhlohesrghmugdrtghomhdprhgtph htthhopehikhgvrdhprghnsegtrghnohhnihgtrghlrdgtohhmpdhrtghpthhtoheprghl vgigsggvlhhmgeeksehgmhgrihhlrdgtohhmpdhrtghpthhtoheptghorhgvnhhtihhnrd gthhgrrhihsehgmhgrihhlrdgtohhmpdhrtghpthhtoheplhhuiihmrgigihhmihhlihgr nhesghhmrghilhdrtghomhdprhgtphhtthhopehhmhhhsehhmhhhrdgvnhhgrdgsrhdprh gtphhtthhopehsohihvghrsehirhhlrdhhuhdprhgtphhtthhopehlvghnsgeskhgvrhhn vghlrdhorhhg X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 051323C0066; Fri, 1 Nov 2024 22:14:52 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 01 Nov 2024 22:14:31 -0400 From: "Mark Pearson" To: "Limonciello, Mario" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: "Rafael J. Wysocki" , "Len Brown" , "Maximilian Luz" , "Lee Chun-Yi" , "Shyam Sundar S K" , "Corentin Chary" , "Luke D . Jones" , "Ike Panhc" , "Henrique de Moraes Holschuh" , "Alexis Belmonte" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Ai Chao" , "Gergo Koteles" , "open list" , "linux-acpi@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "open list:THINKPAD ACPI EXTRAS DRIVER" , "Matthew Schwartz" Message-Id: <2ed34c9d-bd75-4668-b1c8-ac663ad17b25@app.fastmail.com> In-Reply-To: <20241031040952.109057-15-mario.limonciello@amd.com> References: <20241031040952.109057-1-mario.limonciello@amd.com> <20241031040952.109057-15-mario.limonciello@amd.com> Subject: Re: [PATCH v3 14/22] ACPI: platform_profile: Notify change events on register and unregister Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Oct 31, 2024, at 12:09 AM, Mario Limonciello wrote: > As multiple platform profile handlers may come and go, send a notification > to userspace each time that a platform profile handler is registered or > unregistered. > > Tested-by: Matthew Schwartz > Signed-off-by: Mario Limonciello > --- > drivers/acpi/platform_profile.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/acpi/platform_profile.c > b/drivers/acpi/platform_profile.c > index 57c66d7dbf827..7bd32f1e8d834 100644 > --- a/drivers/acpi/platform_profile.c > +++ b/drivers/acpi/platform_profile.c > @@ -182,6 +182,7 @@ int platform_profile_register(struct > platform_profile_handler *pprof) > if (err) > return err; > list_add_tail(&pprof->list, &platform_profile_handler_list); > + sysfs_notify(acpi_kobj, NULL, "platform_profile"); > > cur_profile = pprof; > return 0; > @@ -195,6 +196,8 @@ int platform_profile_remove(struct > platform_profile_handler *pprof) > list_del(&pprof->list); > > cur_profile = NULL; > + > + sysfs_notify(acpi_kobj, NULL, "platform_profile"); > if (!platform_profile_is_registered()) > sysfs_remove_group(acpi_kobj, &platform_profile_group); > > -- > 2.43.0 Looks good to me. Reviewed-by: Mark Pearson Mark