From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2606A20FAAB for ; Thu, 26 Mar 2026 13:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774531932; cv=none; b=EAv/Cs/j6V7hgSXTb2HbZGQQW/c11oF11Lu5QrQYu6SD00BhZatmffJzCPX2hjPE3MvFyYdxBgfSCcdGHntAmwquWyPDzMxeWLMe0ag63BGf7109p7L5LCps9h6afwZLr1C20Y6sUC19u+UUvH4Ld22US0uI0a1GRvrRBC/zeCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774531932; c=relaxed/simple; bh=e2Y4kUvGQmv3yempSyUOwIYwIPOnZpWe7Gku6I1GxuY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d3a/sF+jLy6AKr7g3WFcIEv6wcsxv6bT3phBde3VZWyR2xzEKf2TUAA1Xhyb8IdjUTO3v++rPQHLwSzi2rRTcpmLZjpN48uuayceegy/jvfjt8uUhWnIXju6uxEq29WwV0s1NiBiZy2/YN9WAWctbH7nmefEgFVwem1okmBfaC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f1/1DyYY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RnZKbJjh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f1/1DyYY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RnZKbJjh" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QBaK0V1175797 for ; Thu, 26 Mar 2026 13:32:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gvpfj3DOGxiEiy85LKlrP3RfkspNDgFSSE3+aeFG5pY=; b=f1/1DyYYNortjJW8 c/SciHWSY/miKZlZFiM2Z/rtecDbCI85ycdHU3JJcHCllfQoDyFgXUr94TzWYeKs aMGvjbijQwFlyGXIar6EEnsSqBtylIGnw1PwCXf+4ZGaDE4l3SUJ6dpEKx3SKOvt JWYDcXo88V4ErDm9ch6SpvTXKbmBsCCgy8cMLE4nDvF6S+6WgjjQ4u07Tw3A66t5 E7c82lx/9u+0dhgTyEn8cVrnpouX10W4EO8lG1meFmZHO99j1dcwuwE4XlcTmZyp 5GeBiwrjQiAZqVhObSGl+JWarNyPhKDASRe24pRujpWDB32YBELG/w1NLlkH+rkK Iei4eA== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4q76tycj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 13:32:10 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-604ea7bd707so24550137.1 for ; Thu, 26 Mar 2026 06:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774531929; x=1775136729; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gvpfj3DOGxiEiy85LKlrP3RfkspNDgFSSE3+aeFG5pY=; b=RnZKbJjhN+A409sOdjdZ7NFNZJgr5ruv/tuTWETt+lXAcbNMwW2YrcEXCZb//797iR 9bV8qkOpJLPvrxnBnuhnmxhmz2wUiNvMtVFmNguso84kmC1wSEq5/Gc6e1jERa2bOvOm HH059LPLIXJrUyRBIPpn7NbQq/Vh/iveEdEPdl33VQCUlHh6uw5L2H2Z6MvWGHmQQnvg TBqFQZVS4YKALKvDcPXnlwwn4x+33MrtjNVQRZiIe5ZUVukADKdDIkHQmqO6vfcd5GDX CJywxaDtpSNRtKzgvZZSZuSdNU4uEFB5uZQc7enUTAOEi+cAjKzmARU2Bqy5J4hZ2z/1 4PIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774531929; x=1775136729; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gvpfj3DOGxiEiy85LKlrP3RfkspNDgFSSE3+aeFG5pY=; b=Lacu8HxG0JcJBP5jrRPiiWP4PzkPcw0teNMA9px32YeUu1bXcdPIen6NLP2DxqbEGJ fL0G/kiJvfI1MU7fljj3ykHasDvtFG1K3GXPCe+cANVmYD0WiWwP2CHgt/dlixv5xull JCfmE/9PYcpvmx/KBTu5Gz6Cd9xEQl7zYAuY/Sb9ROlMqU+SX6Xun2ax0vQT43UQdlRT qZaDlIShfDlkCLIFma888U6YR4aJbsoYtvkYMkOgG0e/DtRB3IClHaHCs0I76lLBJj0Y krvLhH2jMVsIHfUO1DbkjzfW8wgAqeDdG35KNQX/maUJoLwT1jPZWRjB2lNU7nHDsvIc 7JSA== X-Forwarded-Encrypted: i=1; AJvYcCUiIsZSbYDmrIEuztqx0JBAqtAOMPY+IkMfJqSvdA3CciKJkN/8kgqxs3mduQO6/C5hyeVNkrc+AM1vUnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxSzrkrNT33/w8wJSKJbzYwe74da105gfZFcIk3VlqfPlYqtB1B ovmUJgwwpGpe5IqBGdIPiasexnu+GYkC56CQ1squD/Y+yCOxHhWS79uJFPbONCXo2GVSAL9VPgk LzM2jH+NkaegM7aVLGCh0nK6O/+spNv0+EsllMmBcdTxfWeEQoyjEyFjbjlaZLlcyHn4= X-Gm-Gg: ATEYQzzqhqbIH7GjbgKNvw8cHD6lEhiXKWybX08rbB4OwW8Ax2p5XKma9ngPdwzREUD YZ1re2Fr0nAQKp0NhShfDjCHMYpe43/Xt5rt2HBYtrAhVRCh6PRGE9CmZIWL6nIYAQdDd3AhPlB G4cid4KprLthqCPJ6CF01fuW6JCKD295gz3ciTqbZoJze3F2xP7h9sUwvey/pIQU93g0PnOQIAW DrOYS5G4CG931eOIhnbXCl45qFxGHkFY/nsCGi9SLDmTC8v0HCb7hq3fyfIeS/nwFXzAVWOXbQQ iioDBTaB6pGN+0ykEnUoyNy6A+8xY6g+acF08rDgnjnoBExGHoZBrIsm6da5QdMisnDO9gLKhAJ 719Iru9X4RCu4DFLlzv1urJ6Zey1ry09PVCoMnYiPfDu+5V2NVTgikGlI6Tx1qaEDRHXaGrh/Rq xj1ks= X-Received: by 2002:a05:6102:2176:b0:604:f07b:efbd with SMTP id ada2fe7eead31-604f07bf4b9mr86940137.2.1774531929248; Thu, 26 Mar 2026 06:32:09 -0700 (PDT) X-Received: by 2002:a05:6102:2176:b0:604:f07b:efbd with SMTP id ada2fe7eead31-604f07bf4b9mr86919137.2.1774531928865; Thu, 26 Mar 2026 06:32:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b20218736sm120142066b.12.2026.03.26.06.32.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 06:32:07 -0700 (PDT) Message-ID: <2ed4c65d-92f7-4451-89b7-1e49c0a1ac6f@oss.qualcomm.com> Date: Thu, 26 Mar 2026 14:32:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] remoteproc: qcom: pas: Fix the dtb PAS context creation To: Mukesh Ojha , Bjorn Andersson , Mathieu Poirier , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325191301.164579-1-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260325191301.164579-1-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NOPYOk6g c=1 sm=1 tr=0 ts=69c5355a cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NHyXfb6j7ZaXbkreoXwA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-ORIG-GUID: Zm3LbwLZI9-9J0QkE-4gO1YU8K8PBvPk X-Proofpoint-GUID: Zm3LbwLZI9-9J0QkE-4gO1YU8K8PBvPk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA5NSBTYWx0ZWRfX8McafTiAofj3 uiYNEAlErvzxBEaiu9go0JZYeQ6hLzhnVXf4YeXKPes7eNqTr8Nemk6+1YmCh+CMjpJKP50Ov4p /9YxmpNssmUtTW+bxdDQFB11zPY+6IJgiarcs+51z6kKhoumcjUIn8lStb1heAalSE0NtFd9uL/ qQcGH5C8a9lQW2HdDQdl2atOIr7NZ9oSM//x1MiYm5HswCljul7+uxkwkPHmmmCalVH9P6pvSBG /TlH3/vzCD2hzj6M5KiLIPCRQ+H2H0BFdoUkVbD4ZJiAz5E8/BV1AqKsuEjKUul5NAMq+GFv7lt ziCNEjp0XrYLoTLo31L9rrfbUeMQ0JTtgO+0BaDnynUzuAVLnwSgq4mHDz1tUmrow4wmjamOv/Z Yz+Z5xQCWkcyD0LmwLK1TiZzxuhUGGGd74JgBiS8Rz+kuXZgdvJ/C8E3+48uvShnhMl9l/UilD5 ynw8548RJ5KBoSUBm1g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260095 On 3/25/26 8:12 PM, Mukesh Ojha wrote: > DTB PAS context creation should be done only for subsystems that support > a DTB firmware binary; otherwise, memory is wasted. Move the context > creation to the appropriate location and, while at it, fix the place > where the DTB PAS context was being released unconditionally. > > Fixes: b13d8baf5601 ("remoteproc: pas: Replace metadata context with PAS context structure") > Signed-off-by: Mukesh Ojha > --- > Changes in v2: https://lore.kernel.org/lkml/sxklpgc2rtr75maiu7lg4iukmaetvjyho7ytyyykmtdu2tov3k@gctoozxj7frl/ > - No change. > > drivers/remoteproc/qcom_q6v5_pas.c | 36 +++++++++++++++--------------- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 46204da046fa..3bde37ac510c 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -250,7 +250,9 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) > return 0; > > release_dtb_metadata: > - qcom_scm_pas_metadata_release(pas->dtb_pas_ctx); > + if (pas->dtb_pas_id) > + qcom_scm_pas_metadata_release(pas->dtb_pas_ctx); I suppose just checking for if (pas->dtb_pas_ctx) would be more obvious but this is effectively equal and other places check for pas_id too Reviewed-by: Konrad Dybcio Konrad