From: Logan Gunthorpe <logang@deltatee.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Tony Luck <tony.luck@intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Question Regarding ERMS memcpy
Date: Mon, 6 Mar 2017 10:12:41 -0700 [thread overview]
Message-ID: <2ed5cdac-7eb1-5444-c030-94e5504f7235@deltatee.com> (raw)
In-Reply-To: <471eb23d-40f2-0c66-c9db-c8b0b5204c07@zytor.com>
On 06/03/17 12:28 AM, H. Peter Anvin wrote:
> On 03/05/17 23:01, Logan Gunthorpe wrote:
>>
>> On 05/03/17 12:54 PM, Borislav Petkov wrote:
>>> Logan, wanna give that a try, see if it takes care of your issue?
>>
>> Well honestly my issue was solved by fixing my kernel config. I have no
>> idea why I had optimize for size in there in the first place.
>>
>
> Yes, to gcc "optimize for size" means exactly that... intended for cases
> where saving storage (e.g. ROM) or code download time is paramount.
I agree and understand, however placing a poorly performing _inline_
memcpy instead of a single call instruction to a performant memcopy
probably took more code space in the end. So like Linus, I just have to
scratch my head at the -Os optimization option.
Logan
next prev parent reply other threads:[~2017-03-06 17:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 20:08 Logan Gunthorpe
2017-03-04 22:43 ` Borislav Petkov
[not found] ` <c675a6c8-e87a-ece2-2350-cdd079b1b610@deltatee.com>
2017-03-04 23:55 ` hpa
2017-03-05 0:14 ` Borislav Petkov
2017-03-05 0:23 ` hpa
2017-03-05 0:33 ` Borislav Petkov
2017-03-05 0:56 ` hpa
2017-03-05 9:50 ` Borislav Petkov
2017-03-05 11:18 ` Borislav Petkov
2017-03-05 13:05 ` Borislav Petkov
2017-03-05 19:19 ` Linus Torvalds
2017-03-05 19:54 ` Borislav Petkov
2017-03-05 20:19 ` Linus Torvalds
2017-03-06 7:01 ` Logan Gunthorpe
2017-03-06 7:28 ` H. Peter Anvin
2017-03-06 17:12 ` Logan Gunthorpe [this message]
2017-03-06 18:53 ` hpa
2017-03-06 13:33 ` Borislav Petkov
2017-03-06 13:41 ` hpa
2017-03-06 14:00 ` Borislav Petkov
2017-03-05 4:58 ` Logan Gunthorpe
2017-03-05 9:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed5cdac-7eb1-5444-c030-94e5504f7235@deltatee.com \
--to=logang@deltatee.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®