From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBCEC74A4B for ; Sun, 12 Mar 2023 10:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbjCLKTA (ORCPT ); Sun, 12 Mar 2023 06:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbjCLKS4 (ORCPT ); Sun, 12 Mar 2023 06:18:56 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 943182687F for ; Sun, 12 Mar 2023 03:18:45 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id cy23so37524411edb.12 for ; Sun, 12 Mar 2023 03:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678616324; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o7Gs6qDlaESvs11l+kYvPQbwbdk54JOWluW/Ld0/AVo=; b=X4i1RRxNEXh1IpcHIyp8QXs6/zfvD+9wXUOm5PeRaSk/XW4TlQCCE32ds5WsVtCB8t covIhjuwKdTQ2hE+8km2s8tR/PQ+vlyNwvfks2ewQVfxfo9NekKT+1I2f9R/fqQs1bBM 06k2IfcmJHNq0YBmlCpZ7t6KE9KDHvb5yyZHHoI5mDzDK3PLmv0gTSArKFPySrO3XLbp 3PlzsSUql4Slax6ScVChw6dgD6iPjDq8KvaGB5sHOTC8nBkNo2Ls3/C77GcqsvftLLcU 7pP1mWFxU0jLKHL0CcKaq2z2xdHKwdbyaSK9weqVPKiJu1J/NMEfiDIHTc6TW6WGBD8T 4vrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678616324; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o7Gs6qDlaESvs11l+kYvPQbwbdk54JOWluW/Ld0/AVo=; b=6J4eGHi4BzEF87I/hpQChcG6NNg0iJKolVXufzm24OFVrb7j+2uDbvimaP+Ws2h7Q6 i4YFjDflD/pYnE7d2I/OYJleFDaizPvXPLwBqOsgSBfrjpmRGYPYCDT8x4y5dyydCruP NEdsy3kFkpECAZe1FxRoyDYLv8fGPHf2GgWqy5TD3NCQFnGN9Qe2ob2E875iWf/y9NaP oO6E9rucTYjgG3ddLhncwk2ZwIx6N96ZgWFYIBkG63wo99g3A71MWu9LOT19ad7bQa91 h/C8kcetJDpNpYOTdit+2EJFQOIk1IufMLGZZUJE89fP/b5bdButuil/ZzCXIH+P/vsj QkcA== X-Gm-Message-State: AO0yUKVuXq9PD3vTcDLZHsQ0UWWc4+y6EOqvPsCPrSzaxTTnhdmfknuT VD3LJIjY92/diJrvk5lA7eagCg== X-Google-Smtp-Source: AK7set9qrR9MMWaTv62j4SHAm8Oc3AdfWSUL1ixA9pQL14hL5A5Hr8N8FDJgu5Tf1eE9p94f3pdW0A== X-Received: by 2002:a17:907:980b:b0:88c:4f0d:85af with SMTP id ji11-20020a170907980b00b0088c4f0d85afmr39414596ejc.75.1678616324127; Sun, 12 Mar 2023 03:18:44 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d9f6:3e61:beeb:295a? ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id v12-20020a50a44c000000b004ac54d4da22sm2042218edb.71.2023.03.12.03.18.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 03:18:43 -0700 (PDT) Message-ID: <2edea81f-9ea1-5ede-8539-6aac88621670@linaro.org> Date: Sun, 12 Mar 2023 11:18:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/2] dt-bindings: synopsys-dw-mshc-common: add "fifo-access-32bit" property Content-Language: en-US To: Sergey Lisov , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1678558770.495747-1-sleirsgoevy@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <1678558770.495747-1-sleirsgoevy@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2023 19:15, Sergey Lisov wrote: > Some Samsung Exynos boards using the arm64 architecture have DW MMC > controllers configured for a 32-bit data bus but a 64-bit FIFO. On these > systems the 64-bit FIFO registers must be accessed in two 32-bit halves. > --- > .../devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) Missing changelog (I did not get cover letter, so no changelog there either). > diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > index 8dfad89c7..d025b38ca 100644 > --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml > @@ -57,6 +57,13 @@ properties: > force fifo watermark setting accordingly. > $ref: /schemas/types.yaml#/definitions/flag > > + fifo-access-32bit: > + description: > + Specifies that this device requires accesses to its 64-bit registers > + to be done as pairs of 32-bit accesses, even on architectures where > + readq is available. > + $ref: /schemas/types.yaml#/definitions/flag Anyway, I said last time this looks compatible-specific, so I don't think we need another property. Best regards, Krzysztof