From: Allen <allen.pais@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>, kvalo@codeaurora.org
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: fix a potential NULL pointer dereference
Date: Thu, 19 Sep 2019 20:59:48 +0530 [thread overview]
Message-ID: <2ee2c6b1-49e3-5050-23c4-a27c152b836c@oracle.com> (raw)
In-Reply-To: <ac6cea459c697db7aec99b8c0c5c0b3bf76b5877.camel@sipsolutions.net>
>>>
>>> + trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
>>> + WQ_HIGHPRI | WQ_UNBOUND, 1);
>>> + if (!trans_pcie->rba.alloc_wq) {
>>
>> I would like to stick to if(unlikely(!trans_pcie->rba.alloc_wq) just
>> for consistency.
>
> That's just clutter, this path gets called exactly once in the lifetime
> of most systems ...
>
>> Let me know if I could add your SOB and send out V2.
>
> No no, I've already sent the patch on the way internally :)
Great. Thank you.
prev parent reply other threads:[~2019-09-19 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 18:11 Allen Pais
2019-09-18 20:19 ` kbuild test robot
2019-09-19 7:08 ` Johannes Berg
2019-09-19 14:07 ` Allen
2019-09-19 14:47 ` Johannes Berg
2019-09-19 15:29 ` Allen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ee2c6b1-49e3-5050-23c4-a27c152b836c@oracle.com \
--to=allen.pais@oracle.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®