From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B64DC4332F for ; Tue, 13 Dec 2022 18:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236517AbiLMSiK (ORCPT ); Tue, 13 Dec 2022 13:38:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235699AbiLMSh6 (ORCPT ); Tue, 13 Dec 2022 13:37:58 -0500 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E62DEBD for ; Tue, 13 Dec 2022 10:37:58 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id d123so2179750iof.6 for ; Tue, 13 Dec 2022 10:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zVw/Ub8n925hTRnFdUzvOTA/UBWQnS0OdDCK00ziL7s=; b=XrBbWdcrYPzuedqF0FgemXWCGtU7UrqvPAsmrbFXqGYJ28FAp6XGTo5oEn8x273sqU 1n/9Yzgl1P7zdafD9gaHuWhGonKRYglyMefa//+e41c5/9SaL5CtXhV701foySxdl0f5 yRDHeGzCpWk0jJ3+phN5yr8QuFGKRgubk9o+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zVw/Ub8n925hTRnFdUzvOTA/UBWQnS0OdDCK00ziL7s=; b=BfzIPNa12WjNqw4csEhI2LBAAq7/1k8UmCgivhJdHlm50K92pq27Acf5yHFTB1YaMp DlUv6eM5zGAdp9BCy6MtnQbizgPPD6a7d+OOeaDzEsz9+2afVrhLVUd9tcCjGys5iAT6 Yf7SDq8+L802PMQFp+07Qt+ynDCAYWzUEfahX8RrUFrvLSBXjUlpPleIhSMfI6TI2m8q Z3cuml6mKwzeR25N3ROQioJqjPmgN5ImfRx+XW2hSrPh7MsPXaQ6+iLaZOXmnIPFgUmh 36gmdgxMjdF1WGVPInk8lW8ZeJ4iZ7eHiSJM5LCh8Q6+YEHJ7ERLj56yQcBJYPcFgizM w9Uw== X-Gm-Message-State: ANoB5pkY6/Y3Xm8vbV6DV2R1DpfvRnowva2rQDmUaXym5F4UnDvxMtNW bA2BYxbdQpehAmoeFQOMgT5Lw9xrleHI2N50 X-Google-Smtp-Source: AA0mqf7aJOMAxmp4CXqLPZfMIko49C01+d4Mm/IeX3PQ/xS4thygg7ozqQaxaFm0a2G0H35SvgIdew== X-Received: by 2002:a6b:500e:0:b0:6e2:d3f7:3b60 with SMTP id e14-20020a6b500e000000b006e2d3f73b60mr2036775iob.2.1670956677330; Tue, 13 Dec 2022 10:37:57 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id q18-20020a0566022f1200b006e2f42a30c2sm3596261iow.35.2022.12.13.10.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 10:37:56 -0800 (PST) Message-ID: <2ee34e21-44bd-71e7-6da2-f4bea9a35452@linuxfoundation.org> Date: Tue, 13 Dec 2022 11:37:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] kselftest/alsa: Increase kselftest timeout Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Mark Brown Cc: kernel@collabora.com, Jaroslav Kysela , Shuah Khan , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20221213183242.1908249-1-nfraprado@collabora.com> From: Shuah Khan In-Reply-To: <20221213183242.1908249-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/22 11:32, Nícolas F. R. A. Prado wrote: > The default timeout for kselftests is 45 seconds, but pcm-test can take > longer than that to run depending on the number of PCMs present on a > device. > > As a data point, running pcm-test on mt8192-asurada-spherion takes about > 1m15s. > > Set the timeout to 10 minutes, which should give enough slack to run the > test even on devices with many PCMs. > 10 minutes is way too long. > Signed-off-by: Nícolas F. R. A. Prado > > --- > > tools/testing/selftests/alsa/settings | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tools/testing/selftests/alsa/settings > > diff --git a/tools/testing/selftests/alsa/settings b/tools/testing/selftests/alsa/settings > new file mode 100644 > index 000000000000..a62d2fa1275c > --- /dev/null > +++ b/tools/testing/selftests/alsa/settings > @@ -0,0 +1 @@ > +timeout=600 Adding timeouts like this especially 10 minutes will increase the time it takes to run tests. We run the risk of people not wanting to run tests anymore. thanks, -- Shuah