From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630AbcHWTDs (ORCPT ); Tue, 23 Aug 2016 15:03:48 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:33314 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752809AbcHWTDi (ORCPT ); Tue, 23 Aug 2016 15:03:38 -0400 Subject: Re: [PATCH] net: phy: micrel: remove suspend/resume To: Christophe Leroy , "David S. Miller" References: <20160823111344.25FF41A2459@localhost.localdomain> Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xander.huff@ni.com, brad.mouring@ni.com, nathan.sullivan@ni.com From: Florian Fainelli Message-ID: <2ee9441d-1b3b-de6d-691d-b615c04c69d0@gmail.com> Date: Tue, 23 Aug 2016 12:03:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160823111344.25FF41A2459@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +others, On 08/23/2016 04:13 AM, Christophe Leroy wrote: > In ERRATA DS80000700A dated 05 May 2016, Microship recommends to > not use software power down mode on KSZ8041 family. s/Microship/Microchip/ > They say they have no plan to fix this ERRATA in future releases. The errata applies to specific revisions, is this revision present in the lower 4 bits of the MII_PHYSID2 register such that it could be used to key the disabling of the power down? > > http://ww1.microchip.com/downloads/en/DeviceDoc/80000700A.pdf > > Signed-off-by: Christophe Leroy > --- > drivers/net/phy/micrel.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 053e879..f456c55 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -837,8 +837,6 @@ static struct phy_driver ksphy_driver[] = { > .get_sset_count = kszphy_get_sset_count, > .get_strings = kszphy_get_strings, > .get_stats = kszphy_get_stats, > - .suspend = genphy_suspend, > - .resume = genphy_resume, > }, { > .phy_id = PHY_ID_KSZ8041RNLI, > .phy_id_mask = MICREL_PHY_ID_MASK, > @@ -856,8 +854,6 @@ static struct phy_driver ksphy_driver[] = { > .get_sset_count = kszphy_get_sset_count, > .get_strings = kszphy_get_strings, > .get_stats = kszphy_get_stats, > - .suspend = genphy_suspend, > - .resume = genphy_resume, > }, { > .phy_id = PHY_ID_KSZ8051, > .phy_id_mask = MICREL_PHY_ID_MASK, > -- Florian