From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBAD473451 for ; Mon, 5 Jan 2026 13:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767619240; cv=none; b=bL+bS5fZ5oV7aXe8k5Tfuxs6/85NSa+CupHDdOcuQXZP8FFLUsd8k8Y/bs4awgvn/r9SK9FzMHoS/nXR46VuikkRbX+3DvZaCKAX3ImdWfbpF2r0f8icvMmDHYwrzkDvUyIoXei4pBmtmsUbfG5ePuJlXz/t9gFLC1WtF70sStU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767619240; c=relaxed/simple; bh=INHzQ9ihPghFLLSlc6GXzXocc87ZT51I1nklEhpFYAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lEyJxJFNqZIhHxImr440FCpeYYdkVuWoueSuQgNaOBvmom8+ce1DKwKYpL/lDfKxmZMofjAE339/8qKlfccZBOeI94J8idy6R++S5mpH4rCo9Lby24D2MPJzGMGQnEDRE51ivOuDAKWpNG+n3oIhpKt4sdDIJ37KJItwbY+H/8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=fjY3TLbq; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="fjY3TLbq" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42e2e3c0dccso8660831f8f.2 for ; Mon, 05 Jan 2026 05:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1767619237; x=1768224037; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rOvK37qhu+VJDgxn4f4nBs5vnn5Qxut7RpMwZ1NlSvk=; b=fjY3TLbqaw9QHwUCIZiSYeFW7bfERHmGUs6uziYAoWAiocOwu+Crna9Wduhh+i4dBv U6unTLpqRKtr2HypxoqhmleuuYw5paDlXNs5Uu0GZra1AL2SS5NLckf2KIPxCxzKavys l0Ujy9ULXPujUsdbvUr9HvgH+lqdrVWsK+ydFYFORMVJ2o9uUXWVnFAN447nT4JsWo6n OjPblrcIYRfnoJ3uQb2bNprQzXodU5h2V/Qf0P+QHtNK175I3uitG6jLNSFnH4UTbsr0 ITigMfYRj4c64AHE85MK7iUxpZoPCv+0VzVkfaLC1VBqF0HiTrwNReEL1SjSwU6p31u8 2SXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767619237; x=1768224037; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rOvK37qhu+VJDgxn4f4nBs5vnn5Qxut7RpMwZ1NlSvk=; b=ejts6pU3zLq03vaUdBG0IoJ0PJ95essOf2papJekRVebU7PHp9WI+YsRtY7ytJMvYv C/vcgRhxHaNRE+HIXw4eU/j/klkJbdrRJsplRGlNZ16ALX0iGej44tnmyC5Rs+LPJH8U zugWzKPFIYEjaf30T+qQReMhN0ekFQeRzRQE6SHXMv3Qv2Z6GL5EUbFdNHOFdCQnOQ8N NFS1S+fEdI6mMvNv+3EXVTTQhW0r0S4IKfmuVdRJ2o4wBcZG1oBYMsbG/EdZ1VbtC2l8 ndysKZ/fu8CZRIIr8FlfAsHOo0X6utvnZ5+YMwCnbbh8n3xi1q6bzEWi8V2Qt7tVaxFa 85yw== X-Gm-Message-State: AOJu0YySF/Z34IuYwl3tOhWhAxNWlNaz8M4NPOvjbkjPTrqxTfM7xhb0 60LrN5SPBnd9Xu4RJrGKed4cOlhWeLOyJROqpQX2zj0JYZmCkzBjHd+Z+IHeOyf18aw= X-Gm-Gg: AY/fxX6Agi7jvbFAxNfxjCTvmNtfANsrksyQjGM51G4tfPgIgEUJ1m5Wg0fYB7OV1RQ K1++D0mMVyYSVVoi0OWP07dZrlxjNo/Lt38uVPcEC6M4N5Wtlo3nDJQOXuZwL1EhOpoHA4ClV+o Usxt5vlC2J5Dfb9dssg/K1rq/4WYQ7eA3ugB9fXsE1OdGhhBm7qM/BHLlcvD8BO5D9ZJQ3Pq59N t1quQpsmcj0oJAOmm/s6Yel5xMm3VhlGjh2YXBWO1oimCwNvQU7gTrtyUdZxUEVqX4cvh54vcwA ODqthsAVbOu6n+Vc4jnGTsEBqEOKxy1/fHTrKiEUekzlWDRd2gIxxIO7y8AgGoDRceI7RTReopV X7E8hcxImk7S+J1ntyi7j8ONUaDwFOaAiLRIK+m7VYMdxq93XWdusGu3Ax2GTrr+U2wG3Z7TmU8 YbMh9g0boq1ORi4BmyvvidO1TYucU2nfKNs1cp X-Google-Smtp-Source: AGHT+IFw/rgT1Enpl2B6AKnWCFAVY8X1CBwOPUlJR7hgtH/rfDNyLYkCCQ1CYGYojOCBxbNDLnYD+A== X-Received: by 2002:a5d:5f87:0:b0:431:327:5dd4 with SMTP id ffacd0b85a97d-4324e50db43mr58163265f8f.46.1767619237077; Mon, 05 Jan 2026 05:20:37 -0800 (PST) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [85.187.217.240]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa0908sm100403230f8f.31.2026.01.05.05.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 05:20:36 -0800 (PST) Message-ID: <2eee3670-6e0a-4f7d-8f6a-5226547bfe6e@suse.com> Date: Mon, 5 Jan 2026 15:20:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/CPU/AMD: Simplify the spectral chicken fix To: Borislav Petkov , X86 ML Cc: LKML , "Borislav Petkov (AMD)" References: <20251230110731.28108-1-bp@kernel.org> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20251230110731.28108-1-bp@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30.12.25 г. 13:07 ч., Borislav Petkov wrote: > From: "Borislav Petkov (AMD)" > > msr_set_bit() takes a bit number to set but MSR_ZEN2_SPECTRAL_CHICKEN_BIT > is a bit mask. The usual pattern that code uses is a _BIT-named type > macro instead of a mask. > > So convert it to a bit number to reflect that. > > Also, msr_set_bit() already does the reading and checking whether the > bit needs to be set so use that instead of a local variable. > > Fixup tabbing while at it. > > No functional changes. > > Signed-off-by: Borislav Petkov (AMD) Reviewed-by: Nikolay Borisov