From: Gavin Shan <gshan@redhat.com>
To: Keqian Zhu <zhukeqian1@huawei.com>, kvmarm@lists.cs.columbia.edu
Cc: maz@kernel.org, will@kernel.org, linux-kernel@vger.kernel.org,
shan.gavin@gmail.com
Subject: Re: [PATCH 2/4] KVM: arm64: Use find_vma_intersection()
Date: Mon, 15 Mar 2021 20:42:06 +1100 [thread overview]
Message-ID: <2eef2b42-13bd-2414-f748-551039677bf5@redhat.com> (raw)
In-Reply-To: <65dfdca3-af94-7d5a-86fe-24825301655b@huawei.com>
Hi Keqian,
On 3/15/21 7:04 PM, Keqian Zhu wrote:
> On 2021/3/15 12:18, Gavin Shan wrote:
>> find_vma_intersection() has been existing to search the intersected
>> vma. This uses the function where it's applicable, to simplify the
>> code.
>>
>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>> ---
>> arch/arm64/kvm/mmu.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
>> index 84e70f953de6..286b603ed0d3 100644
>> --- a/arch/arm64/kvm/mmu.c
>> +++ b/arch/arm64/kvm/mmu.c
>> @@ -421,10 +421,11 @@ static void stage2_unmap_memslot(struct kvm *kvm,
>> * +--------------------------------------------+
>> */
>> do {
>> - struct vm_area_struct *vma = find_vma(current->mm, hva);
>> + struct vm_area_struct *vma;
>> hva_t vm_start, vm_end;
>>
>> - if (!vma || vma->vm_start >= reg_end)
>> + vma = find_vma_intersection(current->mm, hva, reg_end);
> Nit: Keep a same style may be better(Assign vma when declare it).
> Other looks good to me.
>
Yeah, I agree. I will adjust the code in v2 and included your r-b.
Thanks for your time to review.
Thanks,
Gavin
>> + if (!vma)
>> break;
>>
>> /*
>> @@ -1330,10 +1331,11 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm,
>> * +--------------------------------------------+
>> */
>> do {
>> - struct vm_area_struct *vma = find_vma(current->mm, hva);
>> + struct vm_area_struct *vma;
>> hva_t vm_start, vm_end;
>>
>> - if (!vma || vma->vm_start >= reg_end)
>> + vma = find_vma_intersection(current->mm, hva, reg_end);
>> + if (!vma)
>> break;
>>
>> /*
>>
>
next prev parent reply other threads:[~2021-03-15 9:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 4:18 [PATCH 0/4] KVM: arm64: Minor page fault handler improvement Gavin Shan
2021-03-15 4:18 ` [PATCH 1/4] KVM: arm64: Hide kvm_mmu_wp_memory_region() Gavin Shan
2021-03-15 7:49 ` Keqian Zhu
2021-03-15 4:18 ` [PATCH 2/4] KVM: arm64: Use find_vma_intersection() Gavin Shan
2021-03-15 8:04 ` Keqian Zhu
2021-03-15 9:42 ` Gavin Shan [this message]
2021-03-16 3:52 ` Gavin Shan
2021-03-16 4:20 ` Keqian Zhu
2021-03-15 8:52 ` Marc Zyngier
2021-03-15 9:40 ` Gavin Shan
2021-03-15 4:18 ` [PATCH 3/4] KVM: arm64: Fix address check for memory slot Gavin Shan
2021-03-15 7:33 ` Keqian Zhu
2021-03-15 9:46 ` Gavin Shan
2021-03-15 4:18 ` [PATCH 4/4] KVM: arm64: Don't retrieve memory slot again in page fault handler Gavin Shan
2021-03-15 8:25 ` Keqian Zhu
2021-03-15 9:56 ` Gavin Shan
2021-03-15 10:46 ` Keqian Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eef2b42-13bd-2414-f748-551039677bf5@redhat.com \
--to=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®