From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=212.227.17.20 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794171831; b=Ihb9CgAHDUQNW8Ci4I9+imh1vy/SwOHpOOTK3at2KmtZSXxL/yfcJs0/q7AOSSn/Y2jg w5nIoEVDY/UBDYLdnWnKNGUyDZsAEWIxMo6IFh+bBN/E8tlf7DcH03ZbI6oSm/iHBigFq GdoMhDOMfEbiG4yVFsRhfhkjJMD4hG31YdbqcfJuvjW1KkTJMENuCVhvozH3DmbsOGaAS OthAYIfgASkFI71i6GqJkvXeOpnF3MTrWfd36C6M8J21Ja6U1y/NiYC6UrWXzGZ8Gi6Hd eksWFf4nPHtefuJU87m2GezYLp78T61D/sM/3cBHDiK8Z+T5zDIO5QgARoHHCdLsX4A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794171831; h=DMARC-Filter:DKIM-Signature:X-UI-Sender-Class:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Provags-ID:X-Spam-Flag:UI-OutboundReport; bh=qaMAMD5t7PsRjmYCSlDVMEcEPIkz6pncFlS6XYAgEbg=; b=Xu2WfCInDj4UVHH0iglVBEhyvtxn/ty+misbSjc223nHdu4kNvGuqFlpJ5ycUw+J9GhM unPtrfehLxBbl6enw0/nXPq82MeEtNIUZlJPY5D7e/CXtncaGOJej7/a+ZSBMMmwnvCN+ 5DvjRyJppKLRSqOc+boPGUPPA6s7vWSJFnTWdnrUpcYeidd6dXErkaAJIqssqqxqbHuHt DXPciXF/ys9bueQy2VIvvaxtBI7c1uQptM3VuGI6oHo8YFUme3MOcNVd7m3Mcst9iZQvy SNHT3be8GtFjYYOsuHcra8t18vkvwe59tdzFBDp7tj7mM5L8HBq0v2G2IXGRoqt+AOg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass header.d=gmx.net header.i=wahrenst@gmx.net header.a=rsa-sha256 header.s=s31663417 header.b=nmZLN9rU; arc=none smtp.remote-ip=212.227.17.20 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896AC606A321 for ; Sun, 8 Nov 2026 21:03:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 896AC606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmx.net header.i=wahrenst@gmx.net header.a=rsa-sha256 header.s=s31663417 header.b=nmZLN9rU DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1794171828; x=1794776628; i=wahrenst@gmx.net; bh=qaMAMD5t7PsRjmYCSlDVMEcEPIkz6pncFlS6XYAgEbg=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=nmZLN9rUwr9bA7F2q7M4R6WDoI/JyettyQPnlC0pG4pyOBQj1B0HAjnEz2x7C8zA ZQDFfrm3XQj03ny7EBUcsmGGNSIbalAjI/InML95vpa+NGJfm8AenWHoZ2urWxaj9 rfVwKRaAUcSFrb6gRCSuvWmeXLkWjpz11EelwFDKp2LTnFdVDbuOuLivg6cE5dERh wKXa0sE+O5/uhmKdkhMNTZ+W8CMDh9DvleLwNFaHPMyluXZya1DsZlui6vu8lVYnl m1KZslrQCVQS+AXh9PVJgxVE2s1IsrCbkM/eZT+DcYkS7rFJ5OeCt19SXz8phim3F UeXdzzfqzpM4KfRiCg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from client.hidden.invalid by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mk0NU-1wkCSK1WLQ-00ZNJS; Sun, 08 Nov 2026 22:03:48 +0100 Message-ID: <2eef459e-da8f-4db9-8e10-2711730d92de@gmx.net> Date: Sun, 8 Nov 2026 22:03:46 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] firmware: raspberrypi: Remove unnecessary braces in transaction helper To: Sander Speetjens , Florian Fainelli , Broadcom internal kernel review list , Eric Anholt , Stephen Boyd , Nicolas Saenz Julienne Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261107-fix-raspberrypi-firmware-v2-0-5bfe605a5cc5@gmail.com> <20261107-fix-raspberrypi-firmware-v2-4-5bfe605a5cc5@gmail.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20261107-fix-raspberrypi-firmware-v2-4-5bfe605a5cc5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jeN17wL2VBIYhUl575FhSoD4VxIiL3MR9co+jFU/tfdEGNrjB0a GjQxyth9lyfjudzJsW88ZZBqT6/8eqXjI5u0bAJBKCcYvJlWoUQu+1K+zpsUS9t0VqL4bkL CL3Doj+/fVXXyyAjZx9NHE6F0DC3MJ1rX8uYNNO3mtHUo7JEpguwih31d/4H0Ho9ef2UxVK 2ENVZy7CkbLnL0Pp1ukVQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BsqUcY7aAuw=;r3yC/5rORUNci0Q7I/TymKJX6Pz DsIDexuycQF7p6GBLNxtqBtZwvpxLFEaGr5JHPvXJxnETW3sUawr4unM0Kzk6qnynWZhygJJQ QZmFcCygaoGtAmKVTkfKeV1Tkh2hH97gmNBkKb1SnwELB6X4aMxARzlkY2L71Gn5vTc7IKQQB Llo7xUcliPnHWSCsirPVkUq47UstSPBXq0PB16BwsVinv27jRzBxCserYcvXl4HSldVWqR8cE LeZnNgF9EEB5Rhk+h0UWUiPXuYhf+OY5+UmpVD3eSgBOPpep65IzMgBTj3YW7wQQiyccvaNK9 yABywHOE8zEznEzQzMv96HlYvt83WN5LPlekfPhHCgfEj0tQigCSXYpSUqgerwJawHEHj+aRU me77IatO+pxFyfTz07b5wMkY9FabKZ3VRwZl8AARKs89vd+1tAV8wBSWTLd0CNcAamFeTPhZc Y7U2fjUPFqUZ/vsrtqs3CfNBhzdHx27p1lkqcmKAPx3q/7KFZRPN6JA3dyDJMkR5IHeqIBwW5 QHDB0rzvUvQ7Fs+/Xy8+JFXRaRQjdJN0zcgJH30SqTlJ8/nXhYpv6HGJyUNFXU/RVySSLCF4o COkZnUGAVazWES0BZ4vEIxl7fdHDnzLRopURc36Rgi/Dpru2mdjgzLV26w/S9addhHxNvKzbG iZkND93/IW05Ss0ubOCra6DiE9W9NogkaEjPryRSCnheyJ1FGS6gca//fr7PvtCpfLZmu7ioV nueOaWLzqdt262G0snBRQV6Mb00Rve4VmjcBearFLfVmb/jFpFdhvSbg9dX1MgKG/0b9vQn1C lZPygU9ZV2WHZ1wRJjjqFT5cKqy6mUwcab00I2KOYTE3xEY+vzUWG6z1ipnmSH/cYTE2EeEUb Ihv0JB35CNhdoTLW46+irJmdC0/PwvG5UoBWGZQucUWniCK0znYiQn/X1hxHduu2m5pgWsW81 xHwjQmw+00/00vDrsSUfZfLJJDK9hwbaykLvTwvQWZxxWAB2pwtM8i6pmk/BsLHdyvmEN2JhG rxOCIxLprXz2fdYz6iRvsLvyo3/SI5NyhBIDkE5V7P1U2vJ5gel9YGlg19tpxFd7UQAqxFtqK jyOWVpjJB35xIfpKlleS0QcraNSUUfi1yVT/cUSKYRTNIamDmzdBt9xSJPYOImzMO2U+v3zRg iPRGhhL75NoDQK1IhPwf4I9sUfIa3OejYB6k1myRQUpZgUoi3XGjz4v3mfsoP9MldQTE49HXj VOFbqE4gSg0LvagzjKRnmPrUkcAepma4DMeBdvrBBki1VgH4z3X3i489asjjEKUwAtCuwbIvp Mte/5mBi8SzjaVW9/7e7tOB/S4Xmv0gCbnaGjl/dNd35PtTwHTExu3NmPxPMN9zn/CPQDyX8t YlTvCrUN9zA0Siu1Ce7ASewW7PWZPvAWQSudKhPIyyP8O9KDA4/C7Q2AQ7AxaNejlO3PL0gir Gz77RIzw6apGkE4ww2Njzdjx0DTUwIDS9M8IsnvNDeEzwEPm1RR+oOSMzSNI2p5imet2YzhDK lQ6YWHq314DQJR0B0XIHif/ti8esukM7et3xXRtrQoTChYaZy/SJ9OWZRPCu0dQgii0OPceMt jJHRLUQZAWctq1soByGamkA8KO0xK/vV+794SwA/xyIg1qN0k0qO+AdrFjKJpA1PklDbbp0B7 +XTKaOmDl+rLrymo9yL/jdvAw8ZJ23R0MVWVsd6xoG1umHC5uPx/euiZ3St9umAjdQmcMLOCc To7n1cPw1dCrW+S/eqbCOlzNOZ6trx8l3U6WAIwDE6fZBA/r7SP2iSO0vRa+mQyugPLXh+Vxi 0OmWOIpDn9WVMqGAk3+dVpheOOC4SHNX496IZH3WlYjkLMXRrSJ8Ct+gzegi3EzOrQSY4qWkl w5x4DufZ8Nq76H7Bn78qa4TJX0qfAFyWxKAVPC86uUg3b1djye7K6u6ay73/NxKPG4r9oX7hs jXZUUOQsa00lLjH5I3VeD/19UdOSTRTVarMFxaqu+enMo8zw/zx9iOtx+6/F8lHrD24laZol0 a6rov/0j2YPIVVy7Q+zmr0frIK/kw+2FaxgdeVRZnLTTDpWCENYWGcRKu9y/kpfIRO7bq3doU FOv0EziZu+xB700KDWKPXxLYKDZ+tb4fPqwuQ8x/+S42hLohGt20P3lsReKSdCDxeW63XBx6x 6ewNqyAdh/jiixpNJNO+8HOfy4MvDsigAYLQ4qm31P7X6dajfYp0pQjlVGNId1abfLobTjrvb qYdF3O5ScWzVa2vXMc4KFvQC+mp7Py3DtT8y/uAxc6goAapStSIZ7HlFu7MMQnxeNLwTRS0Vy XURw8oTeVyUMIkG/BsUYLXpzit+1xQcN1apV5Ib7qTtUF65wIGR22xkHME7lKGCTAt+GX/DPo IJc7y4k+dgabPmQplGBrKuKZ0BEmikCGKfcu7lkrWR2zEnlSWKLcjrZd36sI1yoKfPYvD4EVC Jh6pw7PeQq9yTJj68JsSzVoP1h3c1lx4rrXWv+qPQeZ0p9PAZQcU+MBAFaAV5b1r/0qZwubpF TkCfRrcelQmiemaQXJ4mbjNE7muPJK8lReejbA4g4/BL6jt/TyJBgKVq35f+b88GMnr+8b8YX Yxleq49bDe4WnHGTUL+PBVlBHrCpv/cvCNK36y2tRQ2jyhWvxTrMH5FBL90s4f8xgCIFlzn78 tpePLay0A2eXbwFpQ8QJTLOlnYbGataDu5sWsMmMH3lqYIHWGEifGBLXCU+wOEs8iByljAkmK F7cJApdDA98gWgMNKNyA2gkCt4MwGW734TMYOvgZzuckNoJvgeSLmuVIfiYMMY4dIzDiTgCLo t4FSUy8rx3tIBaf5BTWc7MuIVSRjOCx++H7pDx8I6mCgsa4HTnBZ1uwNELj2HfoDbVpm6rapp m0A3Wbbi6sMCiqJmpzIYxr0y7RmwLYOSEVWg3al3wVV67k2xZcz7ccV2ARCU/e4TPMGDgKXpV C05h7P42MumEKruGJnFRTZKDNDlxURSroYEjl4BT/zFkeh4/tE2oeijE9WavQhUGGFVWoD884 8KVpm03/LTbhP3WKMHOu15OzVbwpqJg93EsP80/mAO/0GIMIesCP9dwxeW5HvmQbonkfG4Tg6 LPaTMIpdlJasVS0IjpXKSyCpQJrNJHngZowzuzWKkYXOAZAd1dvSujQVIPd7yQ9ZJpVZB0xFP fGp5ZmTxmYFwiwbnJDtlDiTJ8cDcvVQUzpzF2VbbRHEvMCSgpc0oKnAWaMmSNcdP8ua53XzOv qCLWRKHe1EtW8znTcfWA0FhYrCU+KwQjdY5fTVptHCmV0Xk4hF9GX2ZfzOD3xpw/uZCOMnpZZ Wjcw3IcNHCmssDBgAvheqc0BtWx4g1OZxYwo6lGfYray6oxXsO0uTxmdjlGkFhCG66vscgBTg yvxEnlntDEHMcctn+MMhwyYAHV/FrLb3Px0270lCY0Oy+2+si8q0otC+/6cLMtqG0PxO/cyRh DObdCfRy2ZaHERD43kHOXGiYeyxQsSLDM6wH7lZbyZEbi0PERkrBGTZuQU8D+MEn3MfivyHIZ vMZ0zLsetUf36PXA0g9+5gmWAwxkQ6g0RRiGyLe4q5t+MvPr0iMldPGDNHb23GIzXlnxNzpJj ljysF7Ls6C3d2f6tGRyHdaQZFRdiF+aDMEf2t1VTXR0UP5ytfbmOUa948o2EFDsQVzXXZoTVI 2PMFy9sMy8v49M07abtExZTtoYnj3fs7l+UN9REuhkKUpF8yPt97UwHNNynzHLGqMXoODnLQn kgoSIryKknV8eKlbKAASy2n2/JhMRdtjsjLTybz7BaMoak06HK1N4F0HNHLE8Am24fVI/SRVP 9W5NZMECLTcABa8DG2de+as3zEaM6XlWB3X5dSyVDi4ti4IWQWrnD2Od5vhloIYx++EGdIh4C QMwqoQZ5CJHLwNpOVgTk+VKT7CFBGDz2w6yxnqtrS/jc1SMrYNdhE7VDE9fWFB0UVB8epKdPa doPho5Nql4SkKCC3pzOYX7nx+FhCVRwIr21jP7o8YY/m6Iap0e1JOjbvp+lOpG6KAzu8jwhdZ hJiOzkjXauRrtdgH6DQPqizB3A6APhflR5qDJnQdZ/5k5rP1p0LL8zuQlYiRdFW0riHvAD/BR WB5PipMKPjT6zIt2o0Ql2KIsieybckUX2UeX3kRmlXN0lG34j/Hky2oCLRE32X7O1zbzhp/TM 1Xm57ydQ9Vt/vqLWaJHoJqcIt8juxB0prHNg3DjY8SxYutWoUEJepGD4H/dyovYKlB8N00R8k cJe7NPjitTUJmHbvLO/dBqG4n09/FDr14hoJg8vLqkI7/aM+rkz0+7X/Lf4xiyjcFC1wL+uZF s5v6mrWp1CVoWsmdYt/FMn0vSgI4/Ssfd/AwXboaspo7rnhw5n7NBxIiA4xHjHtH5S34stiyH MtQq4p023BH9ryDfFH2tA27EIl910GxlYS0lRlTxY5A0Oj5I+JeWFXdCZS1R2phq5eT5QFfwE Sv6CvFqqlfFU+j675VjYLqLXWRzghRmuz+GHfnym+DnxDNIEK6EjOnTjJL9fGbuEvBk0zkcYp rhaJw3c0p7Rtql7qsy/k07DJm5h9r1s4SSQH+8h119V27f9xugkkH1ORWUMFCxpM18/tfCO5D fmy0Cc2eWIG+o0MUZk8rRUl15NEXzLfaj06dTFlsuwBLkelyv6rB92nBADfys+LmPFGNKe8IT dlF21gNV4nv7yzg83GkMFVPeGpQsxBcKcUksKrkH/IGOX1uNh9Q9MQdRry5O3xAWYqt2VdThT +FH5aw9XXsiagjZW1rlNm1OZshnE9Ho1WwAeK7o21aBmrddnMVroNJK3wfPEjbcj7z5CsRhwE /pQOLYjSPp7sKmmn75qOyK5DQbAiMfuIKpkWFFBrjI0gajJ9FTzNSkXjGHH9+7ZbnGbG+h0xR UY/2vz4/4gZmcYKICK2x9bTQ78PMqTCiH5miGpf6gHxUnZdm7Xp5S6sdx9wx1FXe9xoJHAi3d Dba8ugh/mY6Hlpm8pj6KSm0bHIZR3E7NVV/petyYrx/7xQUVJwmpt048PPUY74TH6hyyeJdpj MI3ktPV6iXHGKVR7rYXJG2P8keuF23xr9l5uD481q7Z366jPlNdHIUjSISj/DLDgDV/WlJAcd 0McqSxJgzYBS2icYyHBDKNc6AOqeerdxMZTb47GFk6UT0d27y7nYEQse/A1itYo5RUiIazTx4 iq3B7vFFGoGEVixTIdJq6rLpX7PfTvbO//S288fCCHajkK9CQU/PkvnU4FrR8O8Hmu8B46hBe o+w6PSUVQ5s3jwpsafncXRllgSnBwe1XPIJPSgEOIec7qAQJMw7Q2qwlYQeN1p/UZruid7RDZ /zLTIYsyO4yPYoCgw6ItC3Y9/2+9JO8LsOIu88ya4VCXZYpJlKW4/Ibaf+aG/Z3ixKi012wPZ 2KjUwCGyrhFPq2xLOR1L27rkxA9/Jcf7/tSQ6IklZ6Anz6wu1YpMNSkwgbDlDDzhPTBCLBaGs nlcKnA6CZVylRL+ysjRGMt0qsQtSEzRI2Nerf++1iYrL2tXebxWcjBc9dNJtadRobqOx0UJ94 RA0VTbALBSNkSAIjgDrvXUcNjhVWpN3pOylF4bwDPNy1/S96woq6YeudIuyBuyxVYjIFK2/uP d4L+DTirlz9ZfX/qfHflVw5RrmFuNry9NjnRtQ6V5SNvAsE60gN98UAESxjDuSUlmnYiEVqFY DCqMf2FCo9yhfHFZKtEXPPULVh/bh7WN1Y3yi4jKds94tAw+/6dx3J81N3+ieosIBLMSeDqR2 ISHkrJKr9tSRpUHxXxeYN3/dWih4Ig3JeEsJpyE3N4UtyhAkQnDn+9D8ausaR17s2VLkAqCGM 9ViDTIbskF3BW8tQEJcHVDp1AsY2o9w+kMR37e1dutg4r5JkL+N4QVIknoozCzm3TTh9ZfuL2 NGauMoCPBtcC8qiFSk1jxoWiHwCOp+f7k1LhCwKge1ZpNk7D+AKlIE4MYnMjv3ksQE2XfiWJ0 wc3yZBta/4bEsxWODpHi3rPzZ4V+3HFtTE+a85SCvNRbc+x/lCBqapCbDo6JNXozvsSpQOMnZ 2U6Nc0p4LZ672zKAnQhZSAlcidtA8pOO+wo1a+ynMSpsTCIcckZYiJT/cI31KNfp6t1vPEQmE jfOqBHCC+CjO3pPW9vb7zrRKc005mNGJixPJUzmqka0Jru/ggJaAf6M2HXdnzLpdUtE6VjEeB JbG5vjIdToCgxxNyHCtA3lonLF4qyRla13Pyqgsh8lCs3+B7f6KSlN9WAQySGIod0SWwsuRNl cgWP/5tgz6m6aCk8FJO5eyGFw92E1qlIedqU+33vYoIVmRKA8/xUL8tzSH4XmElSfckkw5thY SHpVXUXPO5gDjzFV7F6ceeizQJDsAaiDf6635nubY/YjoX2HnvjLIaZgBXxwOC7G/C2CAgyau Vwe5wXJeTrrCKMzeYrVM8S8NPMhfTGKEE4/AlbFVG46HmPYAIpOO3wdWqSv/wv8mWg184IxO0 VLe5DBuGwTsEwl5020sXNjPafyGBZXR3x7JFt5JFXbE6GuriVxYqaUf/6+cqHR16A4VYQcgUO eE5RxGbQ6ff8L3C/9TXNNaySbwAF+AghxVIbHwhHwxWetG6G4i1JC8X9+hKPhMOG2KuCdxMpC DYcDwP2Zt7UlUvGkUd2kXzlRo6F3s17Hkn7kSmOAu82x4+hkOpNlnDq5sYU20kOUtYb5MCm42 16cZEU7cir8K+HP+a8VAtE3yQGuBYCdPm7lskd8bJ+x0L3QsvrKpR7D0GQMtQfIt4oxpN+q06 JhAUDrhDj+By5iWL4j1IlKTloggsWi0qXIXdAehGPAp5+k3Fhn68215R2H6gP8SvKX4G+GXUo Z+mNiDgNHbHlx+W7FtOjcEK64zWHWwx3jKNGdptoxFjut8BQZLW3KHkc8= Hi Sander, Am 07.11.26 um 19:21 schrieb Sander Speetjens: > Braces are not needed around the single-statement arms of the > wait_for_completion_timeout() check. > > Signed-off-by: Sander Speetjens technically there is nothing wrong with this patch, but imho this=20 doesn't add any benefit. It makes it harder to backport possible patches= =20 in future. Best regards