From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08420C77B75 for ; Wed, 19 Apr 2023 22:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbjDSWcN (ORCPT ); Wed, 19 Apr 2023 18:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232941AbjDSWcH (ORCPT ); Wed, 19 Apr 2023 18:32:07 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F1DF7AA0 for ; Wed, 19 Apr 2023 15:31:39 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2a8a59daec5so1132121fa.3 for ; Wed, 19 Apr 2023 15:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681943389; x=1684535389; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wnUl4IvxpgP8DkY6lfjFLZ6luteXP2ASmroly5c9qjE=; b=SVwdxp+ky5JCUki7oK2o+3teHHJGTjria6nO3FdyppdPh6sGN9dhZrv5INSHxitpRk r73OOLijhCJT6KrnnlBV8HjAg0Rg/GBv1r+h9UMDEvyuiLfObeWepVJawixYSD3X9d75 btd9A0hRMZEMMRQPaFL1mNiobnx8l2JYVQSsyOL6eaLyCCL70ubRQjBkNE0AsN/vuHE+ DJvHohseRM4hYivwEsPWF+LqDd4n7v+S3hW5J4GOI+C9yhac+fpwpx36r5c+6pdD7z9t JiJOZRYFmyK2Uk+nETA6TNGkBJVBG6SQN9htuf8Tr5trUwjsX1jLVK4jkNWB9OILP6xq D0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681943389; x=1684535389; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wnUl4IvxpgP8DkY6lfjFLZ6luteXP2ASmroly5c9qjE=; b=HFv9gvZwR1QNV5PhisP1nVOAchHlgpu2SsBlKVoEV6cl26XXXvEQAiftS6tDmbnxRU 0roUN1sJCu5RYVPdMChrtd/1Yy6FLdti1cbP/SKTy74QJ1jXxZO3SYM4MHI2c+888TvQ 1KncEOlBty0UCMkIAzd8Yw1oZGOuaCW3bNQEUJ521HexEbAoxgN1vvjmmQuPTniIj9I4 hDBLYb2KWx40gXSa9fsPEccXsjB4YPVU/SAn4WBqrOX7fSucbLsDQudUl9jaOaOAXRzc flis1DVzl/07l0W2+R+4yrZhMZq0x5mcuAjqEFAoQhtL0VHr4x1vtI7hscv8vBgtAa5N POzA== X-Gm-Message-State: AAQBX9f/eLxbKsEhZf7Z9Cj0l7ifRmYZY7iNpv4/M5iYiIfcLbgRDQXi 9KbG1vDVZ4eUIr8VGtdN5A1+2A== X-Google-Smtp-Source: AKy350bDD4XjwcvExRRoJ5+0NvZCFjjQslWtFy0JMnteMIx2R2h3N5mhLZ24ntxA7gFS31mWN13CoA== X-Received: by 2002:a19:700f:0:b0:4dc:84dd:eb91 with SMTP id h15-20020a19700f000000b004dc84ddeb91mr3686733lfc.22.1681943389462; Wed, 19 Apr 2023 15:29:49 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id 13-20020a05651c00cd00b002a79c2e45b4sm2973260ljr.109.2023.04.19.15.29.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 15:29:49 -0700 (PDT) Message-ID: <2ef93811-3716-a259-538c-08e7b5476f7d@linaro.org> Date: Thu, 20 Apr 2023 01:29:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 03/11] drm/msm/dpu: use hsync/vsync polarity set by the encoder Content-Language: en-GB To: Arnaud Vrac , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230419-dpu-tweaks-v1-0-d1bac46db075@freebox.fr> <20230419-dpu-tweaks-v1-3-d1bac46db075@freebox.fr> From: Dmitry Baryshkov In-Reply-To: <20230419-dpu-tweaks-v1-3-d1bac46db075@freebox.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2023 17:41, Arnaud Vrac wrote: > Do not override the hsync/vsync polarity passed by the encoder when > setting up intf timings. The same logic was used in both the encoder and > intf code to set the DP and DSI polarities, so those interfaces are not > impacted. However for HDMI, the polarities were overriden to static > values based on the vertical resolution, instead of using the actual > mode polarities. > > Signed-off-by: Arnaud Vrac > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) Reviewed-by: Dmitry Baryshkov As a side note: I think at some point we should get rid of the override in dpu_encoder too and move it to dsi bridge code. -- With best wishes Dmitry