From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Santosh Shilimkar" <ssantosh@kernel.org>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] memory: emif: Drop usage of platform_driver_probe()
Date: Tue, 23 Jan 2024 16:17:28 +0100 [thread overview]
Message-ID: <2efb58f8-062b-4790-9fe9-9582196b5391@linaro.org> (raw)
In-Reply-To: <af2931bbb536349a1f9ca637b5aa1094bc354dcc.1702829744.git.u.kleine-koenig@pengutronix.de>
On 17/12/2023 20:31, Uwe Kleine-König wrote:
> There are considerations to drop platform_driver_probe() as a concept
> that isn't relevant any more today. It comes with an added complexity
> that makes many users hold it wrong. (E.g. this driver should have
> better used __init instead of __init_or_module to mark functions only
> relevant to .probe() and mark the driver struct with __refdata.)
>
> This fixes a W=1 build warning:
>
> WARNING: modpost: drivers/memory/emif: section mismatch in reference: emif_driver+0x4 (section: .data) -> emif_remove (section: .exit.text)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/memory/emif.c | 23 ++++++++++++-----------
I applied #1 and #2. This does not apply. Please rebase and resend.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-23 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 19:31 [PATCH 0/3] memory: emif: ifdefs and platform_driver_probe() Uwe Kleine-König
2023-12-17 19:31 ` [PATCH 1/3] memory: emif: Simplify code handling CONFIG_DEBUG_FS Uwe Kleine-König
2024-01-23 15:18 ` Krzysztof Kozlowski
2023-12-17 19:31 ` [PATCH 2/3] memory: emif: Simplify code handling CONFIG_OF Uwe Kleine-König
2024-01-23 15:18 ` Krzysztof Kozlowski
2023-12-17 19:31 ` [PATCH 3/3] memory: emif: Drop usage of platform_driver_probe() Uwe Kleine-König
2024-01-23 15:17 ` Krzysztof Kozlowski [this message]
2023-12-21 20:46 ` [PATCH 0/3] memory: emif: ifdefs and platform_driver_probe() Krzysztof Kozlowski
2023-12-21 21:25 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2efb58f8-062b-4790-9fe9-9582196b5391@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®