From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCBA93F0AA7 for ; Mon, 29 Jun 2026 08:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782721622; cv=none; b=IJN8JnN7obQR4lXee9/0OUkI+/9frqcPCH41r+cFpwqrSpKPpnFRCxZNV6AcxOA2JWiPwKEk2na4XwxMRfO+P7E7QOAYlTUrjbbAQhpuiftuSmP51q1CRFCk9ooJHzKPxPOJaLGW3xOF0+oZ10SvjukzsVSIIJyB4qQPEhshFLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782721622; c=relaxed/simple; bh=/FQMZ8PTl30qhjjreoBbFa/jRq7gSWz9M4S5QD2OzHk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T/LDS3doRwy49tHgcP92DV2Ngjd4tmuDYP8d1ESwG8dNzD+P1Aii9sGsOZw7TOuwoZOskto8LV8H75sRJgP0VAOwl/2JHJJmTv86l115wPRHD//jFd0g+dntGI4ppTtD2brb1hB5oDcGLwzP3dosj30w2cbVQR/etll3NEWkqRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hoUzKdaR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kNkvPAeR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hoUzKdaR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kNkvPAeR" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T6ra6X2077441 for ; Mon, 29 Jun 2026 08:26:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N8ug/TssIPJ7efv2D8UanZxQcJDn+5rN972tF6NNCZs=; b=hoUzKdaRD6FMyLd3 M5ZZ7fE2hT71BQnuEBDeEaG0wry1c4ziwOnRI03A1/0HaRBbae4JBdkruniNK4eM YLWBgWuu9FGXsY19/IHzIF2R9gL55gtYRpookPDcGH7wv7c8DW+L2TZzSPiF7qiX NdY7GjyrMqAKPeDk9t/aT5fqvvs9yJ4s3mySlviZSDES7fD/xwNdGxJjCisYQEqD bn1drDvr+fUVtdncoR748FGxgqx+wJJ+HBVCfrzFJUCdCxPz4KX954BLwIomO13U Jmh+MWCKIptoD8hg0G0NujT87IEYDxsZ2swI2jUGBzJM84LpqJGlb036j7JljI0K kYrPaA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3kp7gd5v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 08:26:57 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8ebb599e528so3980686d6.1 for ; Mon, 29 Jun 2026 01:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782721617; x=1783326417; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N8ug/TssIPJ7efv2D8UanZxQcJDn+5rN972tF6NNCZs=; b=kNkvPAeRV+7HKdbXvRHMIvdr5vkkExwPnkDLkeZyzvOsPrcFc4NxUGPqUWAPvlITqq FBWn9Fp4nBjEfjyArdAHufnYhHfiNyHVC8Wva6kj6tgJuhbgW7do0/bvMIul22XgdprQ vqPNyDBRfrbWfBY1dyTcdYgNZH9hBSxkNY0dJmnOX+PZnI2uGAzbI1pvMsHL1NQQhT+0 CjNqU03soUClUxgiSmduK9eTpQ1RbIYz3zDydXJDZMzEpnjNia2N2yVTYqTrsGTiQpsN JkgD5QTUOmSgKyslJXCvwVNEKP+vThuFOt6Upiv9DFKPXRllT88ojoEpQHGQiBUr+oHm TmoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782721617; x=1783326417; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=N8ug/TssIPJ7efv2D8UanZxQcJDn+5rN972tF6NNCZs=; b=UZMGx0hpw8Alh9Y49HYuvMU7zQI2N52sS9RNUGHUuePwgxi33dTJxz4jDUN2fyIvzn VaIK8Tpkk3xIt0eE1WvKxbgd/ASXlqY2uX8djNdPV/SVzVpQIsDRWvr1jP+xshrzacwc c2YxnIfPtWlo4NQmJlEMJLSbU+3SHoAEGP/nY0iKomHMufvXKGfHrJmqPnRmAFF5jluD joFpP1daGoLPVFwesjLv6eSBIYoJYKWIOJ2/cwAEe7H0scpsSo/8DPsrvbzS3dqzYorY H9ZeYbcIuIGhXX3vmEOo9QFFkkvBVuRR0d6WzgGC4iOmIVQNiyHjGNKHLwwx9MKepC8+ tYfA== X-Forwarded-Encrypted: i=1; AFNElJ+1jeOwhvR+VDMAQRHi4XHO4+wsuGAJ689kmK2oPHNZ3bcipmZ+g8/LRFH54tx5AfcZud8AS7QF3QHeosg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6ZBgrk7KxcbnBiH16m+UxcBJo0boXbx94kB9Ak66Tt/PIicZs p9sqczrvrkpNtXweyYXENAuKLGc12zWnFa5jHf6TLq5afemDPQfjnegj8ogyCMcYJKVWjbU3VBi fEXFdwY4KzpUnUmB1W2xy8QDIw5QzFV0ug0QkTrkvxVpmVO3a7r+hjgS8cW5keTMTEbk= X-Gm-Gg: AfdE7cmR57jwQLOyeS/FQh6xeX1cnUQCoTDoSkkStjpJjvrbBkv3P71gU/St6PacVle oS1C0pLbX3p+Z5GgA6SNBp5KxU318t4G0BKEWlQErOiph6X08rcroi0BPvRNdCDCMpHOUsRqxKi 1WaY3kFSIpJg8pYqN1cls0GYHfE+iAl+t6kwtBjJcEIHzaxri6TMviJDaeP4rhsVZjk2TlBxhD7 AW5FqbPOHHBnIj5sFV0dmB67HDMwEwpyBl9xsRfgQZ4ehutZgxf4Eg1eSfXe7KcaPd0yX9GEltR H3yrk1Wh1zyZbwtGdWbbjk0GJXk92wDW45XcoKZ/Y3sZW9jC3w8WzYbuuZWn8DYU2U0cOcbvgA5 4XYWPYzHeLrOS4qQqDDjfSD9hwvuM/M/lfDc= X-Received: by 2002:a05:622a:50d:b0:51a:8c9c:7de1 with SMTP id d75a77b69052e-51a8c9c830fmr85187021cf.11.1782721616941; Mon, 29 Jun 2026 01:26:56 -0700 (PDT) X-Received: by 2002:a05:622a:50d:b0:51a:8c9c:7de1 with SMTP id d75a77b69052e-51a8c9c830fmr85186741cf.11.1782721616546; Mon, 29 Jun 2026 01:26:56 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c124e79af45sm234316866b.25.2026.06.29.01.26.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 01:26:55 -0700 (PDT) Message-ID: <2efc0f6b-3dd6-4267-b587-88c638f02be6@oss.qualcomm.com> Date: Mon, 29 Jun 2026 10:26:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] drivers/platform: lenovo-t14s-ec: Add hwmon support for temperatures and fan speed To: Guenter Roeck , Sebastian Reichel , Daniel Lezcano Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, bryan.odonoghue@linaro.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20260624210825.264454-1-daniel.lezcano@oss.qualcomm.com> <20260624210825.264454-2-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA2NiBTYWx0ZWRfX84CSwuDzrZ8I QyjTv1m/5IrDL9aC2RLf1SmlCWu6gHLAF2Dy1yGrHJW7OPj+owSXGBsvkJUrk5PoxlBimRRnLMq 00RUtalptwjrSA/3bL6Nmv9tVIsHLi0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA2NiBTYWx0ZWRfXz4oZWm/Iht9f 8sS1Z/Ye8ABIVDdHhzw5Qy+5Ib/jckDy+eR2GwjoviRvaSVnmskKeP284nIHhhbgAWeSTdv+Mf1 qtArzST3BYh7ET9Qf2Chx24ONvirTElL0s2h9TNEokOBOgACyBkXUQHSltzAlmatzTnW0ZKuaaj c5wW22rRZeIfbmdsgdc7S3MAclm/BxBTCfFinPC9jq83HtPjSBksZ3UaK3uC8nzkBu+ar3ElZa4 c6t6Jw13aoCzCgXBh6yGGy+AMhPexOJZ5WM5F/aeKo8e5PVfJy+ZmO7mUcJ7kU0APRuP92k5oNL RsDirThqhGXtf5PA00w/qJkVSE9rWSbs429sXx43QEtGdzFKVd2qfYg/j3e1GyjycNe0D7LTNtX 9DlBYxcRSnFBRuMiPj1cT1Lbb2osriE7k0l8SmlO0ZOfFJs97AIFoaO6p0B7uxnR7re4T9HD7Av a5R9c1u6krGWit/vWWg== X-Proofpoint-ORIG-GUID: bpZgfyNxaNWXLT-t1qo4JN-lI-Jxyqil X-Authority-Analysis: v=2.4 cv=MZJcfZ/f c=1 sm=1 tr=0 ts=6a422c51 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=zEmzfJwlJ8pfclmQ7WMA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: bpZgfyNxaNWXLT-t1qo4JN-lI-Jxyqil X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290066 On 6/28/26 4:02 PM, Guenter Roeck wrote: > On 6/28/26 06:50, Sebastian Reichel wrote: >> Hi, >> >> On Wed, Jun 24, 2026 at 11:08:23PM +0200, Daniel Lezcano wrote: >>> Expose the Lenovo ThinkPad T14s EC environmental sensors through >>> the hwmon subsystem. >>> >>> The driver now registers a hwmon device providing access to six EC >>> temperature sensors corresponding to the SoC, keyboard area, base >>> cover, PMIC/charging circuitry, QTM module and SSD. Sensor labels >>> are exported to allow user space to identify each measurement. >>> >>> Additionally, expose the system fan speed by reading the fan RPM >>> registers from the embedded controller. >>> >>> This allows standard monitoring tools such as lm-sensors to report >>> platform temperatures and fan speed. >>> >>> Signed-off-by: Daniel Lezcano daniel.lezcano@oss.qualcomm.com >>> --- >> >> I gave this a try and for me the fan data is always 65535 (i.e. -1): >> >> $ cat /sys/class/hwmon/hwmon66/{name,fan1_input} >> t14s_ec >> 65535 >> >> This is with the fan running: >> >> $ cat /sys/class/hwmon/hwmon57/{name,fan1_input} >> fan-controller >> 2564 >> > > Not really my concern, but those names really add zero value, > and I would argue that they do not "allow user space to identify > each measurement". > > Also, do you really have 66 hwmon devices on those systems ? > Seems unusual. There's a couple dozen thermal sensors on the SoC and each one is registered with a thermal zone, plus a couple here and there for other onboard peripherals (PMICs and whatnot) Konrad