Re: [PATCH v4 2/2] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon Q6A

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/24/25 5:07 PM, Xilin Wu wrote:
> Radxa Dragon Q6A is a single board computer, based on the Qualcomm
> QCS6490 platform.
> 
> Features enabled and working:
> 
> - Configurable I2C/SPI/UART from 40-Pin GPIO
> - Three USB-A 2.0 ports
> - RTL8111K Ethernet connected to PCIe0
> - eMMC module
> - SD card
> - M.2 M-Key 2230 PCIe 3.0 x2
> - Headphone jack
> - Onboard thermal sensors
> - QSPI controller for updating boot firmware
> - ADSP remoteproc (Type-C and charging features disabled in firmware)
> - CDSP remoteproc (for AI applications using QNN)
> - Venus video encode and decode accelerator
> 
> Signed-off-by: Xilin Wu <sophon@radxa.com>
> ---

[...]

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		pinctrl-0 = <&user_led>;
> +		pinctrl-names = "default";
> +
> +		user-led {
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_HEARTBEAT;
> +			gpios = <&tlmm 42 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";

"panic-indicator"?

[...]

> +&qspi {
> +	/* It's not possible to use QSPI with iommu */
> +	/* due to an error in qcom_smmu_write_s2cr */
> +	/delete-property/ iommus;

I would assume this is going to apply to all non-Chrome kodiak devices

[...]

> +&sound {
> +	compatible = "qcom,qcs6490-rb3gen2-sndcard";
> +	model = "QCS6490-Radxa-Dragon-Q6A";
> +
> +	audio-routing =
> +		"IN1_HPHL", "HPHL_OUT",
> +		"IN2_HPHR", "HPHR_OUT",
> +		"AMIC2", "MIC BIAS2",
> +		"TX SWR_ADC1", "ADC2_OUTPUT";

odd line break

[...]

> +&usb_2_hsphy {
> +	status = "okay";

odd status-not-last

lgtm otherwise, thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad