mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hans@jjverkuil.nl>
To: Maxime Ripard <mripard@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mats Randgaard <matrandg@cisco.com>,
	Alain Volmat <alain.volmat@foss.st.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 0/4] media: Fix CSI2 RGB vs BGR pixel order
Date: Mon, 16 Jun 2025 10:02:57 +0200	[thread overview]
Message-ID: <2f0028ac-e94f-4f35-afda-8b53ce231b3f@jjverkuil.nl> (raw)
In-Reply-To: <20250612-csi-bgr-rgb-v1-0-dc8a309118f8@kernel.org>

On 12/06/2025 14:53, Maxime Ripard wrote:
> Hi,
> 
> Here's an(other [1]) attempt at fixing the current mess due to the
> opposite meaning of what v4l2 and the MIPI-CSI2 spec call "RGB". By v4l2
> nomenclature, the format CSI calls RGB is actually BGR.
> 
> Unfortunately, a handful of CSI transceivers report through RGB media
> bus pixel code, which is then understood as V4L2_PIX_FMT_RGB24 by CSI
> receivers.
> 
> This is made somewhat worse the fact that media bus codes have been made
> mostly with parallel busses in mind, and thus the order of pixels wasn't
> clearly defined anywhere.
> 
> So the v4l2 vs CSI mismatch was confusing (but there's nothing we can do
> about it), but the doc didn't really make an attempt at clearing it up
> either.
> 
> We did have a convention so far though, that about half the affected
> drivers were following. 
> 
> This series improves the doc, adds the missing media bus codes, and
> converts the transceiver drivers to the rightful media bus format.
> 
> We'll also need that series [2] from Laurent to fix all the affected
> transceivers. 
> 
> Let me know what you think,
> Maxime
> 
> 1: https://lore.kernel.org/r/20250606-rpi-unicam-rgb-bgr-fix-v1-1-9930b963f3eb@kernel.org
> 2: https://lore.kernel.org/r/20250611181528.19542-1-laurent.pinchart@ideasonboard.com

This link seems to be wrong. Can you give the correct URL?

Regards,

	Hans

> 
> ---
> Maxime Ripard (4):
>       media: uapi: Clarify MBUS color component order for serial buses
>       media: uapi: Introduce MEDIA_BUS_FMT_BGR565_1X16
>       media: tc358743: Fix the RGB MBUS format
>       media: gc2145: Fix the RGB MBUS format
> 
>  .../userspace-api/media/v4l/subdev-formats.rst     | 51 +++++++++++++++++++---
>  drivers/media/i2c/gc2145.c                         |  4 +-
>  drivers/media/i2c/tc358743.c                       | 10 ++---
>  include/uapi/linux/media-bus-format.h              |  3 +-
>  4 files changed, 54 insertions(+), 14 deletions(-)
> ---
> base-commit: 6e417fb287553495e43135125d099daf80b63fe1
> change-id: 20250612-csi-bgr-rgb-b837980c00b3
> 
> Best regards,


  parent reply	other threads:[~2025-06-16  8:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 12:53 Maxime Ripard
2025-06-12 12:53 ` [PATCH 1/4] media: uapi: Clarify MBUS color component order for serial buses Maxime Ripard
2025-06-12 12:53 ` [PATCH 2/4] media: uapi: Introduce MEDIA_BUS_FMT_BGR565_1X16 Maxime Ripard
2025-06-12 12:53 ` [PATCH 3/4] media: tc358743: Fix the RGB MBUS format Maxime Ripard
2025-06-12 17:01   ` Dave Stevenson
2025-06-16  8:02     ` Hans Verkuil
2025-06-18 14:54       ` Maxime Ripard
2025-07-31 10:14         ` Maxime Ripard
2025-07-31 10:38           ` Hans Verkuil
2025-07-31 13:02             ` Maxime Ripard
2025-06-12 12:53 ` [PATCH 4/4] media: gc2145: " Maxime Ripard
2025-06-16  7:42   ` Hans Verkuil
2025-06-16  8:02 ` Hans Verkuil [this message]
2025-06-18  8:48   ` [PATCH 0/4] media: Fix CSI2 RGB vs BGR pixel order Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f0028ac-e94f-4f35-afda-8b53ce231b3f@jjverkuil.nl \
    --to=hans@jjverkuil.nl \
    --cc=alain.volmat@foss.st.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=matrandg@cisco.com \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®