From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AA5C282CC for ; Thu, 7 Feb 2019 15:10:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AA5521904 for ; Thu, 7 Feb 2019 15:10:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="UAdPGrQj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbfBGPKS (ORCPT ); Thu, 7 Feb 2019 10:10:18 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39161 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbfBGPKS (ORCPT ); Thu, 7 Feb 2019 10:10:18 -0500 Received: by mail-wr1-f65.google.com with SMTP id t27so188526wra.6 for ; Thu, 07 Feb 2019 07:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=h5y4FDODq872pLT04GyZ8UAR5pFINUnNPPRuvtTI9MA=; b=UAdPGrQj/s2L6OGgGR700XCgw2OTQBDJ99f36Gke7+JFlUhBX5xakn2DMYKwlJvnTR KFUvWjJEgYwHrcGjUZVHvDdhVC38ZdlrQnhQNjyqYicS4/eXCU7DKsXUI6S50tc5bWlx ANMRuMXqxBACmrpvcuqsFNU/ZMNMByOKhhUohHw03RycsDfHW1XzwNbbpxrfBGaxtfXq eKbSlfPOKa8HVeNuFGdvg2XF2Fps6HJBglWncWEJ0aAb+7kHcLc01B2dgEy0Q9nD5Dm2 sF0xqbUoMnfSVcoAdmIlgmUBU28zXwg+IjvG1CsKL90MkpUn/6oZRkszSI9FA3xmuqYM XDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=h5y4FDODq872pLT04GyZ8UAR5pFINUnNPPRuvtTI9MA=; b=iOY9nBh2x6tNzBQu2Hf8roWQtodgIQUcK0De79F9aYysbR0ps3YvaYJdc9myC3VphU L0Oa8iKhOiIk7kHwlAJwN3lXpD/5/etZ/fLvNDbbJOer26rQIDiH5k6AUnVkHO5dd+xA Ml5Jz0tumsePMslDIIdVRX6H2GVHgahMxJcuA+CZNwDmJGgKNfYmqFvAYEQZl/TBskUf XT61rgQoeHV4rlpfq2CKece3adpfl/Pg2On/waBmTQr7qtHWAIMudJrRT76uKtF8lO0y 7oCizv+fYiqzZESjWhBZMopYsN6TO8ik3E8gUPWSTv8xSN2iHLv3DcIUd73cKApwsRky UtNA== X-Gm-Message-State: AHQUAubmcWEGBOauIfVdq2OepOTQBlE88y7rcRUkTLzemypwZ7TJYT3W 8ashafzQoKRHvmKUvzComgR7Sg== X-Google-Smtp-Source: AHgI3IY4Hde8uCVrST3qqGUSTIECToaeQzPsgPSz1Sg4cXrjB7VguBuyvXTKgeH2AXnnpIZ0CAn7Hg== X-Received: by 2002:adf:a58a:: with SMTP id g10mr12625907wrc.3.1549552215547; Thu, 07 Feb 2019 07:10:15 -0800 (PST) Received: from boomer.baylibre.com ([2a04:cec0:1103:b081:462c:a008:349b:2f3a]) by smtp.gmail.com with ESMTPSA id f134sm20032540wme.31.2019.02.07.07.10.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 07 Feb 2019 07:10:14 -0800 (PST) Message-ID: <2f03298e4d1ca0aa08d683d6db14bc194607b974.camel@baylibre.com> Subject: Re: [PATCH 1/2] dt-bindings: clk: add G12A AO Clock and Reset Bindings From: Jerome Brunet To: Neil Armstrong , devicetree@vger.kernel.org Cc: linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 07 Feb 2019 16:10:12 +0100 In-Reply-To: <20190204091331.9298-2-narmstrong@baylibre.com> References: <20190204091331.9298-1-narmstrong@baylibre.com> <20190204091331.9298-2-narmstrong@baylibre.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-02-04 at 10:13 +0100, Neil Armstrong wrote: > Add bindings for the Amlogic G12A AO Clock and Reset controllers. > > Signed-off-by: Neil Armstrong > --- > .../bindings/clock/amlogic,gxbb-aoclkc.txt | 1 + > include/dt-bindings/clock/g12a-aoclkc.h | 43 +++++++++++++++++++ > include/dt-bindings/reset/g12a-aoclkc.h | 18 ++++++++ > 3 files changed, 62 insertions(+) > create mode 100644 include/dt-bindings/clock/g12a-aoclkc.h > create mode 100644 include/dt-bindings/reset/g12a-aoclkc.h > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt > b/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt > index 79511d7bb321..c41f0be5d438 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt > @@ -10,6 +10,7 @@ Required Properties: > - GXL (S905X, S905D) : "amlogic,meson-gxl-aoclkc" > - GXM (S912) : "amlogic,meson-gxm-aoclkc" > - AXG (A113D, A113X) : "amlogic,meson-axg-aoclkc" > + - G12A (S905X2, S905D2, S905Y2) : "amlogic,meson-g12a-aoclkc" > followed by the common "amlogic,meson-gx-aoclkc" > - clocks: list of clock phandle, one for each entry clock-names. > - clock-names: should contain the following: > diff --git a/include/dt-bindings/clock/g12a-aoclkc.h b/include/dt- > bindings/clock/g12a-aoclkc.h > new file mode 100644 > index 000000000000..997aca16c94f > --- /dev/null > +++ b/include/dt-bindings/clock/g12a-aoclkc.h > @@ -0,0 +1,43 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ > +/* > + * Copyright (c) 2016 BayLibre, SAS > + * Author: Neil Armstrong > + * > + * Copyright (c) 2018 Amlogic, inc. > + * Author: Qiufang Dai > + */ > + > +#ifndef DT_BINDINGS_CLOCK_AMLOGIC_MESON_G12A_AOCLK > +#define DT_BINDINGS_CLOCK_AMLOGIC_MESON_G12A_AOCLK > + > +#define CLKID_AO_AHB 0 > +#define CLKID_AO_IR_IN 1 > +#define CLKID_AO_I2C_M0 2 > +#define CLKID_AO_I2C_S0 3 > +#define CLKID_AO_UART 4 > +#define CLKID_AO_PROD_I2C 5 > +#define CLKID_AO_UART2 6 > +#define CLKID_AO_IR_OUT 7 > +#define CLKID_AO_SAR_ADC 8 > +#define CLKID_AO_MAILBOX 9 > +#define CLKID_AO_M3 10 > +#define CLKID_AO_AHB_SRAM 11 > +#define CLKID_AO_RTI 12 > +#define CLKID_AO_M4_FCLK 13 > +#define CLKID_AO_M4_HCLK 14 > +#define CLKID_AO_CLK81 15 > +#define CLKID_AO_SAR_ADC_SEL 16 > +#define CLKID_AO_SAR_ADC_DIV 17 Do we need to export the internal part of these composite clock ? I know the other AO controller do it but it would be nice to avoid it, like for the EE controllers ... unless there is good reason of course. Same for the others below. > +#define CLKID_AO_SAR_ADC_CLK 18 > +#define CLKID_AO_CTS_OSCIN 19 > +#define CLKID_AO_32K_PRE 20 > +#define CLKID_AO_32K_DIV 21 > +#define CLKID_AO_32K_SEL 22 > +#define CLKID_AO_32K 23 > +#define CLKID_AO_CEC_PRE 24 > +#define CLKID_AO_CEC_DIV 25 > +#define CLKID_AO_CEC_SEL 26 > +#define CLKID_AO_CEC 27 > +#define CLKID_AO_CTS_RTC_OSCIN 28 > + > +#endif > diff --git a/include/dt-bindings/reset/g12a-aoclkc.h b/include/dt- > bindings/reset/g12a-aoclkc.h > new file mode 100644 > index 000000000000..bd2e2337135c > --- /dev/null > +++ b/include/dt-bindings/reset/g12a-aoclkc.h > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ > +/* > + * Copyright (c) 2016 BayLibre, SAS > + * Author: Neil Armstrong > + */ > + > +#ifndef DT_BINDINGS_RESET_AMLOGIC_MESON_G12A_AOCLK > +#define DT_BINDINGS_RESET_AMLOGIC_MESON_G12A_AOCLK > + > +#define RESET_AO_IR_IN 0 > +#define RESET_AO_UART 1 > +#define RESET_AO_I2C_M 2 > +#define RESET_AO_I2C_S 3 > +#define RESET_AO_SAR_ADC 4 > +#define RESET_AO_UART2 5 > +#define RESET_AO_IR_OUT 6 > + > +#endif