From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C443E45D1A4 for ; Tue, 25 Aug 2026 14:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667595; cv=none; b=M3aWtSUGI/VRg999fkBFJ9fWYhYKCer6qYHlv7igGuEALNJIgPtJLQHOgFOM/9NqCyLTL6SmiJ1Qj1kAWB08175n/UEU1/K8Y0HdQTWQ18H+iq0o0GeIkS6ZFJCZtolzL9R6qmEeY83lWan/pfbnU3WAESqAeYaFqfdMbk10IDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667595; c=relaxed/simple; bh=5hUNZDQWKJpKHv9XdIuO3dKhDkzgrvKIiU+TlyvgRVU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l5PuuCO6wPh+cCMFnNZ6ibFSn3RDRjcqp07yXBU6b3RwEfXJvK6/zjPL24gNlUCu1Wm6kPIIuhpW0kIi4HKt3GEOd9hc6+FrYNS1jS5J8FH+vuZ0ly1aQGpsiwF1wNCKMLrGBxjpKqUCxGISlseO25kyqnO8MOdQ5DSCTQV/rs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T8FH5/qA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T8FH5/qA" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id DE74A1F000E9; Tue, 25 Aug 2026 14:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787667594; bh=Xk0dNc7B36bwDKmRn5sL8ALUnv0/054lZYNtGFvdOpY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=T8FH5/qAdqSaoDKKlg1O4VOOa89peEvvy+zljYLuWMBj6KoTlmU7+ZD2X0nEWDNzz NLAYF3dbezVhevy41KhV1TV9LMyWt5a6NlsiuksVIFsXTmpgAXFkQ7Y5NAmCe973+0 R3B428/U82AHynqe2e4xG7+XzQAhGpoX9OVXDeprunA4RwLnznqKaQv4X/2CwT+myJ NmFc4mqZQ6O0TVUQpLiluENK4ThWlgIWJSF0hno4b+4ASYJO/jfBnKD1S4gsWjMvmH 4Wu7P3OyeTv9YZSlThnX2A5P7ugzD0kmCIpsjTLLXbUSKrtDgj/KH1E++Af0rbgP6k a5TFXdVGtwBGA== From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jassi Brar , Heiko Stuebner Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v1 1/3] mailbox: rockchip: Add a prefix for register defines Date: Tue, 25 Aug 2026 16:19:24 +0200 Message-ID: <2f057b0a7fdec721457962e0f1ca37b07e2b592c.1787667315.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=3104; i=ukleinek@kernel.org; h=from:subject:message-id; bh=RMzhspIF+h3rHuDcRebgUTq0TyN/+X/y3aEHxu6zPE8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqjaR3yVdKAwmmTzuja8pG1pzDOzm2ZrxQm7tzY 5E7/VLaEkeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCao2kdwAKCRCPgPtYfRL+ ThKvB/4nFnH4yltKXhUbewS1SoYJsI4JqtpGaeKg0bmkvJss++HQhjjEviTV6tX+PN80bmPpBbU PtcOd06OsihwXSpXxwCsRJ+5ZvV+oOnztCon1PTKQ4B/82v9F0ucMKCcH/+7EJdVEcbDWyCt5dq 8SCtCnSQdweUyI4vhsjj1tv70j2SkkXTUzC10xYgRV0/3sH3tMDuhDtgZG80yXpoTgKnoojfQqk pqVGO6ag+YVn/726w8KCB2XY0uckGxGduteZROn/Dz3d+BrJpO4HeN4tCorUIj7kIHlOz+J16Xv n9I0cPytuNTGtWyL9HTEFFyt6zBDrSdtIiyvVlezdQfjpjRy X-Developer-Key: i=ukleinek@kernel.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit From: Uwe Kleine-König This way the defines don't make the impression to be more generic than they actually are. Signed-off-by: Uwe Kleine-König --- drivers/mailbox/rockchip-mailbox.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c index bc2f9dd798dd..7ebe5f0d0233 100644 --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -12,15 +12,15 @@ #include #include -#define MAILBOX_A2B_INTEN 0x00 -#define MAILBOX_A2B_STATUS 0x04 -#define MAILBOX_A2B_CMD(x) (0x08 + (x) * 8) -#define MAILBOX_A2B_DAT(x) (0x0c + (x) * 8) +#define ROCKCHIP_MAILBOX_A2B_INTEN 0x00 +#define ROCKCHIP_MAILBOX_A2B_STATUS 0x04 +#define ROCKCHIP_MAILBOX_A2B_CMD(x) (0x08 + (x) * 8) +#define ROCKCHIP_MAILBOX_A2B_DAT(x) (0x0c + (x) * 8) -#define MAILBOX_B2A_INTEN 0x28 -#define MAILBOX_B2A_STATUS 0x2C -#define MAILBOX_B2A_CMD(x) (0x30 + (x) * 8) -#define MAILBOX_B2A_DAT(x) (0x34 + (x) * 8) +#define ROCKCHIP_MAILBOX_B2A_INTEN 0x28 +#define ROCKCHIP_MAILBOX_B2A_STATUS 0x2C +#define ROCKCHIP_MAILBOX_B2A_CMD(x) (0x30 + (x) * 8) +#define ROCKCHIP_MAILBOX_B2A_DAT(x) (0x34 + (x) * 8) struct rockchip_mbox_msg { u32 cmd; @@ -68,9 +68,10 @@ static int rockchip_mbox_send_data(struct mbox_chan *chan, void *data) mb->chans[chans->idx].msg = msg; - writel_relaxed(msg->cmd, mb->mbox_base + MAILBOX_A2B_CMD(chans->idx)); + writel_relaxed(msg->cmd, mb->mbox_base + + ROCKCHIP_MAILBOX_A2B_CMD(chans->idx)); writel_relaxed(msg->rx_size, mb->mbox_base + - MAILBOX_A2B_DAT(chans->idx)); + ROCKCHIP_MAILBOX_A2B_DAT(chans->idx)); return 0; } @@ -81,7 +82,7 @@ static int rockchip_mbox_startup(struct mbox_chan *chan) /* Enable all B2A interrupts */ writel_relaxed((1 << mb->mbox.num_chans) - 1, - mb->mbox_base + MAILBOX_B2A_INTEN); + mb->mbox_base + ROCKCHIP_MAILBOX_B2A_INTEN); return 0; } @@ -92,7 +93,7 @@ static void rockchip_mbox_shutdown(struct mbox_chan *chan) struct rockchip_mbox_chan *chans = mb->chans; /* Disable all B2A interrupts */ - writel_relaxed(0, mb->mbox_base + MAILBOX_B2A_INTEN); + writel_relaxed(0, mb->mbox_base + ROCKCHIP_MAILBOX_B2A_INTEN); mb->chans[chans->idx].msg = NULL; } @@ -107,13 +108,13 @@ static irqreturn_t rockchip_mbox_irq(int irq, void *dev_id) { int idx; struct rockchip_mbox *mb = (struct rockchip_mbox *)dev_id; - u32 status = readl_relaxed(mb->mbox_base + MAILBOX_B2A_STATUS); + u32 status = readl_relaxed(mb->mbox_base + ROCKCHIP_MAILBOX_B2A_STATUS); for (idx = 0; idx < mb->mbox.num_chans; idx++) { if ((status & (1 << idx)) && (irq == mb->chans[idx].irq)) { /* Clear mbox interrupt */ writel_relaxed(1 << idx, - mb->mbox_base + MAILBOX_B2A_STATUS); + mb->mbox_base + ROCKCHIP_MAILBOX_B2A_STATUS); return IRQ_WAKE_THREAD; } } -- 2.55.0.11.g153666a7d9bb