From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Subject: Re: [PATCH 2/4] KVM: VMX: Move x86_ops wrappers under CONFIG_KVM_INTEL_TDX
Date: Fri, 14 Mar 2025 15:47:49 +0000 [thread overview]
Message-ID: <2f0e07c5cb49a50757315f330e26a5c7517116fa.camel@intel.com> (raw)
In-Reply-To: <d4c19589-baa4-47a8-8d3d-bff10ba6aa64@linux.intel.com>
On Fri, 2025-03-14 at 10:42 +0800, Binbin Wu wrote:
>
> On 3/14/2025 3:30 AM, Vishal Verma wrote:
> > Rather than have a lot of stubs for x86_ops helpers, simply omit
> > the
> > wrappers when CONFIG_KVM_INTEL_TDX=n. This allows nearly all of
> > vmx/main.c to go under a single #ifdef. That eliminates all the
> > trampolines in the generated code, and almost all of the stubs.
>
> In this patch, these vt_xxx() functions still are common code.
> Move these functions inside CONFIG_KVM_INTEL_TDX will break the build
> for
> kvm-intel when CONFIG_KVM_INTEL_TDX=n.
>
> Maybe just squash this patch into 4/4?
You're right, yes I can squash this into Patch 4.
next prev parent reply other threads:[~2025-03-14 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 19:30 [PATCH 0/4] KVM: TDX: Cleanup the kvm_x86_ops structure for vmx/tdx Vishal Verma
2025-03-13 19:30 ` [PATCH 1/4] KVM: TDX: Move apicv_pre_state_restore to posted_intr.c Vishal Verma
2025-03-14 2:36 ` Binbin Wu
2025-03-13 19:30 ` [PATCH 2/4] KVM: VMX: Move x86_ops wrappers under CONFIG_KVM_INTEL_TDX Vishal Verma
2025-03-14 2:42 ` Binbin Wu
2025-03-14 15:47 ` Verma, Vishal L [this message]
2025-03-13 19:30 ` [PATCH 3/4] KVM: VMX: Make naming consistent for kvm_complete_insn_gp via define Vishal Verma
2025-03-13 19:30 ` [PATCH 4/4] KVM: VMX: Clean up and macrofy x86_ops Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0e07c5cb49a50757315f330e26a5c7517116fa.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®