From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7053C433E0 for ; Wed, 24 Mar 2021 22:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8FC361A1B for ; Wed, 24 Mar 2021 22:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232373AbhCXWQq (ORCPT ); Wed, 24 Mar 2021 18:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231854AbhCXWQZ (ORCPT ); Wed, 24 Mar 2021 18:16:25 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD3FC06174A for ; Wed, 24 Mar 2021 15:16:22 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id i26so18432200lfl.1 for ; Wed, 24 Mar 2021 15:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4D/l2+6KHDLLWR4B5U/x02N6vRyCwEwFRlTNp/wGF4o=; b=hAFDLHj6fjyaz0CpQe/wXAhQdPZckXiCaly/4AYL3Dkx1KVFOPLy4FRdE1mDiYCTpF yfW0W9jRDl2zTI22o9I5dHPuagw96xyQp+zTVWkBTytBNS8TQNXNgUlwQkoceqeQILVR P5ClI8+EZkN5tviNLnEJ4lhm6jQUfYpmKdKEBHQcl//djc6qPej2uFNG+nDsFxYWBW01 2fx5txdgB1E34M2U0XMCIk/Sc7BNqjD8OJXAaxkKlrp7ESUJTxAhgind5phCWk4veEow D3Syzgg0W914P2swEoOaKJ0LQ3DJABKOzBgG6sIXH+3575llrzivPjZTuK4sMTc6afgp XJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4D/l2+6KHDLLWR4B5U/x02N6vRyCwEwFRlTNp/wGF4o=; b=TU6huWZlR7GKyn/wXwYvWffJgQrKmdYxRBLIQcMfS7vhHjHS3E0OgMMeKNFWAOHZQE nAHLT1+6Y3l0vUcGw2O5faynk0egyARX95mNbGVvDK0HaNfdLilf0we6m0haNUCTnUUP hZ78W7bCdFmGu7GAfnoZaukFTg93DzI2jEAittWqHG1aOcQ+754lAf0pIFRWy35QJRkn HHlNAlm2oyBnLKHKDUBPbXjAWJdNA9Yu903LynlQFhxzW46MVOVuGJCJ+7ATxiTwrbYH JvQczyUDrvbGU8piv20iMOh5VOqshQ81Ekg1ARHzTEYs/thRXmeQ0cL1QCXVwJLTqezr W79A== X-Gm-Message-State: AOAM533+9PoRb+tCTMb0Kh3tXB5HVqDlirnS51PzTCAp6TnMjCtI5B3/ XiP+gkWov8Nlf9Cf5rMkc1Y= X-Google-Smtp-Source: ABdhPJyLzK+FeyTdpQAmnRkTno5Ed66uyJHebfewgpXrtWAANvZx9jXP99UStgJ5fgD9ElQQlC36lA== X-Received: by 2002:ac2:4ac1:: with SMTP id m1mr3192377lfp.446.1616624181470; Wed, 24 Mar 2021 15:16:21 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-60.dynamic.spd-mgts.ru. [109.252.193.60]) by smtp.googlemail.com with ESMTPSA id t5sm421099ljc.78.2021.03.24.15.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 15:16:21 -0700 (PDT) Subject: Re: [PATCH v7] mm: cma: support sysfs To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org, Colin Ian King References: <20210324205503.2132082-1-minchan@kernel.org> <65840bfd-4471-7c8d-ce71-c4705baf3bfe@gmail.com> From: Dmitry Osipenko Message-ID: <2f0ef658-9848-b655-f7c0-fee6aadb9846@gmail.com> Date: Thu, 25 Mar 2021 01:16:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 25.03.2021 00:55, Minchan Kim пишет: >>> +static ssize_t alloc_pages_success_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >>> +{ >>> + struct cma *cma = cma_from_kobj(kobj); >>> + >>> + return sysfs_emit(buf, "%llu\n", >>> + atomic64_read(&cma->nr_pages_succeeded)); >> nit: Algnment isn't right, should be better to write it as single line, IMO. > Let me make it align rather than single line since I know someone > who keep asking us to not overflow 80 columns unless it's special. > I'm actually one of those guys who complains about 80 chars (where necessary), but in this particular case it only hurts readability of the code, IMO.