From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: linux-sh@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux Kernel Functional Testing <lkft@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] maple: remove unneeded maple_bus_uevent() callback.
Date: Wed, 01 Feb 2023 20:05:21 +0100 [thread overview]
Message-ID: <2f10003fcf3671ccdd285952ba76153f5c2d5307.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20230201125642.624255-1-gregkh@linuxfoundation.org>
Hi Greg!
On Wed, 2023-02-01 at 13:56 +0100, Greg Kroah-Hartman wrote:
> The driver core recently changed the uevent bus callback to take a const
> pointer, and the maple_bus_uevent() was not correctly fixed up. Instead
> of fixing the function parameter types, just remove the callback
> entirely as it does not do anything, so it is not necessary.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> sh maintainers, I'll take this through my tree as that's where the
> offending commit is that causes the build breakage.
>
> drivers/sh/maple/maple.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c
> index e24e220e56ee..e05473c5c267 100644
> --- a/drivers/sh/maple/maple.c
> +++ b/drivers/sh/maple/maple.c
> @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr,
> return 0;
> }
>
> -static int maple_bus_uevent(struct device *dev,
> - struct kobj_uevent_env *env)
> -{
> - return 0;
> -}
> -
> static void maple_bus_release(struct device *dev)
> {
> }
> @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = {
> struct bus_type maple_bus_type = {
> .name = "maple",
> .match = maple_match_bus_driver,
> - .uevent = maple_bus_uevent,
> };
> EXPORT_SYMBOL_GPL(maple_bus_type);
Through which tree is this supposed to be picked up?
FWIW, we have set up a new SH tree now, but I am not designated as an official
SH maintainer yet which is what I would like to become in order to support
Rich Felker.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2023-02-01 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 12:56 Greg Kroah-Hartman
2023-02-01 14:08 ` Anders Roxell
2023-02-01 19:05 ` John Paul Adrian Glaubitz [this message]
2023-02-01 19:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f10003fcf3671ccdd285952ba76153f5c2d5307.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=rafael@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®