From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: "Dhaval Giani" <dhaval@linux.vnet.ibm.com>
Cc: containers@lists.osdl.org, LKML <linux-kernel@vger.kernel.org>,
"Li Zefan" <lizf@cn.fujitsu.com>,
"Paul Menage" <menage@google.com>
Subject: Re: [RFC][PATCH] introduce task cgroup (#task restrictioon for prevent fork bomb by cgroup)
Date: Thu, 5 Jun 2008 19:51:35 +0900 [thread overview]
Message-ID: <2f11576a0806050351o60dc1351q35f74d4e9836e20d@mail.gmail.com> (raw)
In-Reply-To: <20080605092745.GA3734@linux.vnet.ibm.com>
Hi
Thank you for careful review.
>> + struct task_cgroup *taskcg;
>> +
>> + if ((max_tasks > INT_MAX) ||
>> + (max_tasks < INT_MIN))
>
> It should be < -1 I think.
OK.
I'll fix it at next post.
>> + spin_lock(&taskcg->lock);
>> + if (max_tasks < taskcg->nr_tasks)
>> + return -EBUSY;
>
> Shouldn't you drop the lock here?
you are right.
Thanks.
> How does this controller affect performance? Do you have some numbers?
No.
but I have plan to mesure it at nearly future.
Thanks.
next prev parent reply other threads:[~2008-06-05 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 4:43 KOSAKI Motohiro
2008-06-05 5:13 ` KAMEZAWA Hiroyuki
2008-06-05 5:23 ` Daisuke Nishimura
2008-06-05 10:56 ` KOSAKI Motohiro
2008-06-05 5:47 ` Li Zefan
2008-06-05 10:53 ` KOSAKI Motohiro
2008-06-05 9:27 ` Dhaval Giani
2008-06-05 10:51 ` KOSAKI Motohiro [this message]
2008-06-05 21:52 ` Daniel Hokka Zakrisson
2008-06-07 7:41 ` KOSAKI Motohiro
2008-06-07 9:12 ` Paul Menage
2008-06-05 22:04 ` Paul Menage
2008-06-07 6:46 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0806050351o60dc1351q35f74d4e9836e20d@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=containers@lists.osdl.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®