mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Yinghai Lu" <yhlu.kernel@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>
Subject: Re: [mmotm and linux-next][PATCH] irq: enclose irq_desc_lock_class in CONFIG_LOCKDEP
Date: Tue, 16 Dec 2008 21:58:52 +0900	[thread overview]
Message-ID: <2f11576a0812160458y1c376878vc5fc7f3d208aa344@mail.gmail.com> (raw)
In-Reply-To: <20081216121815.GA25019@elte.hu>

>> or, following #ifdef ?
>>
>> #if defined(CONFIG_SPARSE_IRQ) || defined(CONFIG_TRACE_IRQFLAGS)
>>
>>  /*
>>  * lockdep: we want to handle all irq_desc locks as a single lock-class:
>>  */
>>  static struct lock_class_key irq_desc_lock_class;
>
> instead of increasing the #ifdef jungle, how about removing some? For
> example is this distinction:
>
>> >  #ifndef CONFIG_SPARSE_IRQ
>
> really needed? We should use symmetric lock class annotations, regardless
> of how irq_desc[] is laid out.

it seems make much sense. I'll test your idea tommorow.

thanks.

  reply	other threads:[~2008-12-16 12:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16  8:08 KOSAKI Motohiro
2008-12-16  8:34 ` Andrew Morton
2008-12-16 10:18   ` Ingo Molnar
2008-12-16 10:23     ` Ingo Molnar
2008-12-16 11:15       ` KOSAKI Motohiro
2008-12-16 11:20         ` Ingo Molnar
2008-12-16 11:45           ` KOSAKI Motohiro
2008-12-16 12:18             ` Ingo Molnar
2008-12-16 12:58               ` KOSAKI Motohiro [this message]
2008-12-17 10:40                 ` KOSAKI Motohiro
2008-12-18 13:36                   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f11576a0812160458y1c376878vc5fc7f3d208aa344@mail.gmail.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®