From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: "Hidehiro Kawai" <hidehiro.kawai.ez@hitachi.com>
Cc: "Roland McGrath" <roland@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, yumiko.sugita.yf@hitachi.com,
satoshi.oshima.fk@hitachi.com
Subject: Re: [PATCH] coredump_filter: enable to change the default filter
Date: Fri, 26 Dec 2008 20:46:03 +0900 [thread overview]
Message-ID: <2f11576a0812260346j2df02362q52c8f813981a7773@mail.gmail.com> (raw)
In-Reply-To: <4954A7BE.6080204@hitachi.com>
>>>>>However, we would need a special care for PID namespace if we use
>>>>>init's coredump_filter as default. For a process with new PID
>>>>>namespace and new /proc, writing to /proc/1/coredump_filter doesn't
>>>>>mean changing default, although it's not a usual operation.
>>>>
>>>>I'd figured that private PID namespaces with their own init would want
>>>>their own private settings for this default too.
>>>
>>>Probably it's true, but I'm not sure if having coredump_filter have
>>>two means is acceptable. init in a private PID namespace can die
>>>and dump a core file. So its coredump_filter has two means; default
>>>setting for the namespace and setting for itself.
>>
>> FWIW, I think private namespace should have private settings framework.
>> I don't like to make special private settings code in this patch.
>>
>> Yeah, defenitely we need to private settings for various reason, I agreed.
>> but we also need consistent private settings rule and framework.
>> otherwise, we will make various non consistent crap. maybe..
>
> Anyway, as Andrew pointed out, current coredump filter doesn't
> care for user mode helpers. So we need some sort of changes in
> coredump filter so that users can change user mode helpers'
> settings; use child_reapers setting as default (Roland's
> suggestion) or use a boot parameter.
hm, ok.
I agreed your patch is nice.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
prev parent reply other threads:[~2008-12-26 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 6:33 Hidehiro Kawai
2008-12-11 6:46 ` KOSAKI Motohiro
2008-12-11 23:10 ` Andrew Morton
2008-12-11 23:22 ` Roland McGrath
2008-12-19 10:05 ` Hidehiro Kawai
2008-12-19 19:53 ` Roland McGrath
2008-12-26 6:22 ` Hidehiro Kawai
2008-12-26 6:49 ` KOSAKI Motohiro
2008-12-26 9:45 ` Hidehiro Kawai
2008-12-26 11:46 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0812260346j2df02362q52c8f813981a7773@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®