From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Steven Rostedt <srostedt@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Don't use tracing_record_cmdline() in workqueue tracer
Date: Tue, 10 Mar 2009 21:18:48 +0900 [thread overview]
Message-ID: <2f11576a0903100518i640a5cefgb359cc3ab81688db@mail.gmail.com> (raw)
In-Reply-To: <20090310121125.GC5794@elte.hu>
>> Doh!
>> My last mail's cc list didn't include lkml. that's unintensional silly
>> my mistake. very sorry.
>>
>> and Yes, memcpy(buf, task->comm, 16) mean two movq
>> instruction. that is worthless for caching. I think we can
>> remove this cache completely.
>
> ok, agreed - mind sending a patch for that?
ok, I'll do that.
>> and, I find my last patch has one race window. fixing below.
>
> Could you please send a delta patch against tip:master? Thanks,
maybe, I can send it tommorow.
thanks.
prev parent reply other threads:[~2009-03-10 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090309175330.CF63.A69D9226@jp.fujitsu.com>
[not found] ` <20090309092817.GA2184@elte.hu>
2009-03-10 0:57 ` KOSAKI Motohiro
2009-03-10 12:11 ` Ingo Molnar
2009-03-10 12:18 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0903100518i640a5cefgb359cc3ab81688db@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®