From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable <stable@kernel.org>, Rik van Riel <riel@redhat.com>,
David Howells <dhowells@redhat.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Define a UNIQUE value for AS_UNEVICTABLE flag
Date: Fri, 3 Apr 2009 03:02:41 +0900 [thread overview]
Message-ID: <2f11576a0904021102r19165d89le45563b438621e08@mail.gmail.com> (raw)
In-Reply-To: <20090402095315.1098b6c3.akpm@linux-foundation.org>
(cc to Avi)
>> [PATCH] Define UNIQUE value of AS_UNEVICTABLE
>>
>> Needed in 2.6.28, 2.6.29, ...
>>
>> A new "address_space flag"--AS_MM_ALL_LOCKS--was defined to use the next
>> available AS flag while the Unevictable LRU was under development. The
>> Unevictable LRU was using the same flag and "no one" noticed. Current
>> mainline, since 2.6.28, has same value for two symbolic flag names.
>
> argh.
>
> What are the user-observable effects of the bug, and why didn't anyone
> notice it until now?
AS_MM_ALL_LOCKS is used by mmu_notifier. it mean it is used by only kvm.
In the other hand, AS_UNEVICTABLE mean unevictable shmem or ramfs.
Then, if shmem opend process use ioctl(KVM_CREATE_VM), unevictable
flag on the shmem accidentally turn off.
but, fortunatelly, In modern desktop environment, only KVM control
program use above ioctl. then, we can assume this doesn't use shmem
and ramfs.
Am I missing anything?
next prev parent reply other threads:[~2009-04-02 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 16:47 Lee Schermerhorn
2009-04-02 16:53 ` Andrew Morton
2009-04-02 18:02 ` KOSAKI Motohiro [this message]
2009-04-02 19:13 ` Avi Kivity
2009-04-02 18:08 ` Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0904021102r19165d89le45563b438621e08@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®