From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Greg KH <greg@kroah.com>, Ingo Molnar <mingo@elte.hu>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Ben Slusky <sluskyb@paranoiacs.org>,
Dave Jones <davej@redhat.com>, Chris Wright <chrisw@sous-sol.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: lockdep warnings: cpufreq ondemand gorvernor possibly circular locking
Date: Mon, 11 May 2009 00:22:26 +0900 [thread overview]
Message-ID: <2f11576a0905100822y5507a9f7m6f9aa0fcc05ac18@mail.gmail.com> (raw)
Hi
my box output following warnings.
it seems regression by commit 7ccc7608b836e58fbacf65ee4f8eefa288e86fac.
A: work -> do_dbs_timer() -> cpu_policy_rwsem
B: store() -> cpu_policy_rwsem -> cpufreq_governor_dbs() -> work
=======================================================
nd cpu frequency[ INFO: possible circular locking dependency detected ]
scaling: 2.6.30-rc4-mm1 #26
-------------------------------------------------------
K99cpuspeed/227488 is trying to acquire lock:
(&(&dbs_info->work)->work){+.+...}, at: [<ffffffff81055bfd>]
__cancel_work_timer+0xde/0x227
but task is already holding lock:
(dbs_mutex){+.+.+.}, at: [<ffffffffa0081af3>]
cpufreq_governor_dbs+0x241/0x2d2 [cpufreq_ondemand]
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (dbs_mutex){+.+.+.}:
[<ffffffff8106a15a>] __lock_acquire+0xa9d/0xc33
[<ffffffff8106a3b1>] lock_acquire+0xc1/0xe5
[<ffffffff81303aa5>] __mutex_lock_common+0x4d/0x34c
[<ffffffff81303e5c>] mutex_lock_nested+0x3a/0x3f
[<ffffffffa008193d>] cpufreq_governor_dbs+0x8b/0x2d2 [cpufreq_ondemand]
[<ffffffff812678bd>] __cpufreq_governor+0xa7/0xe4
[<ffffffff81267acf>] __cpufreq_set_policy+0x19a/0x216
[<ffffffff81268572>] store_scaling_governor+0x1ec/0x228
[<ffffffff812691fb>] store+0x67/0x8c
[<ffffffff81129091>] sysfs_write_file+0xe9/0x11e
[<ffffffff810e64d8>] vfs_write+0xb0/0x10a
[<ffffffff810e6600>] sys_write+0x4c/0x74
[<ffffffff8100bc1b>] system_call_fastpath+0x16/0x1b
[<ffffffffffffffff>] 0xffffffffffffffff
-> #1 (&per_cpu(cpu_policy_rwsem, cpu)){+++++.}:
[<ffffffff8106a15a>] __lock_acquire+0xa9d/0xc33
[<ffffffff8106a3b1>] lock_acquire+0xc1/0xe5
[<ffffffff813040d8>] down_write+0x4d/0x81
[<ffffffff81268ad3>] lock_policy_rwsem_write+0x4d/0x7d
[<ffffffffa0081692>] do_dbs_timer+0x64/0x284 [cpufreq_ondemand]
[<ffffffff81055395>] worker_thread+0x205/0x318
[<ffffffff8105933f>] kthread+0x8d/0x95
[<ffffffff8100ccfa>] child_rip+0xa/0x20
[<ffffffffffffffff>] 0xffffffffffffffff
-> #0 (&(&dbs_info->work)->work){+.+...}:
[<ffffffff8106a04e>] __lock_acquire+0x991/0xc33
[<ffffffff8106a3b1>] lock_acquire+0xc1/0xe5
[<ffffffff81055c36>] __cancel_work_timer+0x117/0x227
[<ffffffff81055d58>] cancel_delayed_work_sync+0x12/0x14
[<ffffffffa0081b06>] cpufreq_governor_dbs+0x254/0x2d2
[cpufreq_ondemand]
[<ffffffff812678bd>] __cpufreq_governor+0xa7/0xe4
[<ffffffff81267ab9>] __cpufreq_set_policy+0x184/0x216
[<ffffffff81268572>] store_scaling_governor+0x1ec/0x228
[<ffffffff812691fb>] store+0x67/0x8c
[<ffffffff81129091>] sysfs_write_file+0xe9/0x11e
[<ffffffff810e64d8>] vfs_write+0xb0/0x10a
[<ffffffff810e6600>] sys_write+0x4c/0x74
[<ffffffff8100bc1b>] system_call_fastpath+0x16/0x1b
[<ffffffffffffffff>] 0xffffffffffffffff
other info that might help us debug this:
3 locks held by K99cpuspeed/227488:
#0: (&buffer->mutex){+.+.+.}, at: [<ffffffff81128fe5>]
sysfs_write_file+0x3d/0x11e
#1: (&per_cpu(cpu_policy_rwsem, cpu)){+++++.}, at:
[<ffffffff81268ad3>] lock_policy_rwsem_write+0x4d/0x7d
#2: (dbs_mutex){+.+.+.}, at: [<ffffffffa0081af3>]
cpufreq_governor_dbs+0x241/0x2d2 [cpufreq_ondemand]
stack backtrace:
Pid: 227488, comm: K99cpuspeed Not tainted 2.6.30-rc4-mm1 #26
Call Trace:
[<ffffffff81069347>] print_circular_bug_tail+0x71/0x7c
[<ffffffff8106a04e>] __lock_acquire+0x991/0xc33
[<ffffffff8104e2f6>] ? lock_timer_base+0x2b/0x4f
[<ffffffff8106a3b1>] lock_acquire+0xc1/0xe5
[<ffffffff81055bfd>] ? __cancel_work_timer+0xde/0x227
[<ffffffff81055c36>] __cancel_work_timer+0x117/0x227
[<ffffffff81055bfd>] ? __cancel_work_timer+0xde/0x227
[<ffffffff81068a22>] ? mark_held_locks+0x4d/0x6b
[<ffffffff81303d5a>] ? __mutex_lock_common+0x302/0x34c
[<ffffffffa0081af3>] ? cpufreq_governor_dbs+0x241/0x2d2 [cpufreq_ondemand]
[<ffffffff81068a22>] ? mark_held_locks+0x4d/0x6b
[<ffffffffa0081af3>] ? cpufreq_governor_dbs+0x241/0x2d2 [cpufreq_ondemand]
[<ffffffff8100b956>] ? ftrace_call+0x5/0x2b
[<ffffffff81055d58>] cancel_delayed_work_sync+0x12/0x14
[<ffffffffa0081b06>] cpufreq_governor_dbs+0x254/0x2d2 [cpufreq_ondemand]
[<ffffffff8105ce4d>] ? up_read+0x2b/0x2f
[<ffffffff812678bd>] __cpufreq_governor+0xa7/0xe4
[<ffffffff81267ab9>] __cpufreq_set_policy+0x184/0x216
[<ffffffff81268572>] store_scaling_governor+0x1ec/0x228
[<ffffffff81269354>] ? handle_update+0x0/0x39
[<ffffffff812691fb>] store+0x67/0x8c
[<ffffffff81129091>] sysfs_write_file+0xe9/0x11e
[<ffffffff810e64d8>] vfs_write+0xb0/0x10a
[<ffffffff810e6600>] sys_write+0x4c/0x74
[<ffffffff8100bc1b>] system_call_fastpath+0x16/0x1b
[ OK ]
Sending all processes th
next reply other threads:[~2009-05-10 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 15:22 KOSAKI Motohiro [this message]
2009-05-10 18:04 ` Andrew Morton
2009-05-10 23:13 ` KOSAKI Motohiro
2009-05-10 19:12 ` [RFC patch] cpufreq: fix circular locking in teardown Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0905100822y5507a9f7m6f9aa0fcc05ac18@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=davej@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=sluskyb@paranoiacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®