From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66D1396D25 for ; Tue, 24 Feb 2026 12:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771935786; cv=none; b=U5uYaKF6cjkKT4uz9IcWw2fYN5C1wOlixUyUNxOawglwbxYCBMiZvG4NXzMIaIUjHGJllBUn8bg0wG382h1+khL8Bup3Yz67AAgAgAqPcFGsBM0McU0oRXhT8uxA6IeUydEtmCt78TxQK2xgIxoE7H0FhfUocgSDKc43rpFEA8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771935786; c=relaxed/simple; bh=tS5a+Gcznr5+KGRAN6eb80AVTnEhD2VJxbtMcJ/cG1k=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=C0nbsUXtaM3lGLDlxOqsHrcaZ90TsgxCppLu1WUynWYNIYB2rrn9HjorFryNLBSJImYlPLiRceVAqbb6vQQTYuV7S/LNIWKCo1kvXFe1geMOaxq9R/+ijSf2gFZp5r7PSv6G4tVy9gLHl5cl/5idxaJVGTHv4iKXilLs7cTe6iI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CVcSPumo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=H/cdB3Of; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CVcSPumo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="H/cdB3Of" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771935784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1VU+UoY5nfa4KZiwPxzUFBpVpI9AbrMZQurHI87xYhg=; b=CVcSPumoKG7fbWxtbwH77dKMsleDRBolhs0TfgKp6MzJEeB6AGnvoHSc1GWgSCbesRuO+e ao/3mfm5fRKOEEdBXI4HOfM+5omTS3sNvHORkXyRAtUZJ5CC9dJhLM56mhWhGjWplwRYep bk5Q32RH8HfrailboqAJI42/YHNDggI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-LyaYKig5PLyKZ4CdOZmj2A-1; Tue, 24 Feb 2026 07:23:03 -0500 X-MC-Unique: LyaYKig5PLyKZ4CdOZmj2A-1 X-Mimecast-MFC-AGG-ID: LyaYKig5PLyKZ4CdOZmj2A_1771935782 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4836fbfa35cso36855595e9.1 for ; Tue, 24 Feb 2026 04:23:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771935782; x=1772540582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=1VU+UoY5nfa4KZiwPxzUFBpVpI9AbrMZQurHI87xYhg=; b=H/cdB3OfASqVcIe6Lkv6/NoTlW+Q5nY4jzBdqoqMf0vxNW13apJtkp1LuMYdyztmXV iDPNiB3IedBZKE7hDEwOaw86yBDccbcFk6b9zsLxZqbMOZEh2kI0sXye+xlPE6xEzuNm hwK3+8fZ4GLGxkr5IXF+oIFlk2xWsvWhSR/YIw4cudfJtAwlqV9C+WTu0cGHm06h8hcr 10V8J3mGRM+t8fvNfp7Zw0RwYxRPTmQzEZzvtg+hsPKE5BYCfeulhao8hvrj8pzuvA87 pBibs60gWeW5kj61Vx1zkpWqa1aed/sC/XjqMtRR05DV63qrfKYMD3QKUO8EYhtbE7Na 6UCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771935782; x=1772540582; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1VU+UoY5nfa4KZiwPxzUFBpVpI9AbrMZQurHI87xYhg=; b=s9wF19tLhyZ7bK3iVDv2YmY/bbuY6WOd35SHqYEoZjOHQMMV33WDVhJc+g509RdY8d t+jk9eiGrC+4tsWjVpsqknyHwMk9p7uiJ+dv4itKvT49KNKiTL6C50cOIlmqh08L483n zn/Ndb4AosP5wVVwAtAF0UpIhEiND3IZ5SO+kgNtpWWBJKX6R0l2mIw/piZH7QkHtvUb vAHfaS08BZwoZbrRWlCtsZOUl3aVcZc007RUfx2eHr1ONlLJE6AmAh+21xtlnSRda1YA d8EHLrYRorOm5RwZyJbE4PzxJu+7rf8SbYNofS/qNMnsX61hFmjTny1P8Ts9VrVz5oIc OrCA== X-Forwarded-Encrypted: i=1; AJvYcCUAl42cdaXZJ8PvBRsdjIVtGIeoc4BFJEsTpBMj/X7PsFR5Fuz5sD/JixtNOIR0FCQvNkULs/EbA39o7SU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy72oYKsf91/70cUOHT8iQckOwdBPPn0Pb9uIjIndpVLccM7YPP hkqxtbfbW0m8vMbfLedan0XYKHs/1+DeK/VjsyJ3GmVroko4+cLVNNxEq8O/i3r0Y8Jzl9Oavl1 PgnaX6hwxnWdq8bLrRmznG6JHuHAAsRjSfawC4M6dV9nzrttrPiKcafSgeVJnVS+yNQ== X-Gm-Gg: AZuq6aJimP9EPqHiIw8tkeF49LzPNS8SqAGFW0F5ULghaOdXI32lynyw+iIv0rsOaHN bOYmLdDt0N9+arBMNDxI9W8bkBaDl7Ba6Dt6Bu07vsIeaf+iXAcxYAhJttwv5qqIpy1dmR7DfGM c6af228S+KXtnPkHCm+PhBBq+J2EnTEGmuqb7tKfvzfEll90ae/uBCkefTYUrknKdcZvYmeLjKm H7vRVFmaYOVdb431I6PV1H2eBGZdeBz92EYad++CO8ylmf0nCdfJ8YoxCFkSYx3uhLf9NkCPZWq zIYeh/BDIGo3xksQJJVi8gfh/HYZLSPMT+yFNNAEyBbYlmbautje+GtWmmB7Ti4/vBD1c//BGES 2pIAWBHCs9MHsKtn+m44r X-Received: by 2002:a05:600c:3111:b0:483:612d:7a9a with SMTP id 5b1f17b1804b1-483a95622f5mr207112315e9.0.1771935782137; Tue, 24 Feb 2026 04:23:02 -0800 (PST) X-Received: by 2002:a05:600c:3111:b0:483:612d:7a9a with SMTP id 5b1f17b1804b1-483a95622f5mr207111825e9.0.1771935781643; Tue, 24 Feb 2026 04:23:01 -0800 (PST) Received: from [192.168.88.32] ([216.128.9.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31c56d8sm501015885e9.8.2026.02.24.04.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 04:23:00 -0800 (PST) Message-ID: <2f11ece1-cb85-4491-89d5-c8818666ff41@redhat.com> Date: Tue, 24 Feb 2026 13:22:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages To: Erni Sri Satya Vennela , Erni Sri Satya Vennela , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, dipayanroy@linux.microsoft.com, ssengar@linux.microsoft.com, shradhagupta@linux.microsoft.com, shirazsaleem@microsoft.com, gargaditya@linux.microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260223040826.750864-1-ernis@linux.microsoft.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260223040826.750864-1-ernis@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/23/26 5:08 AM, Erni Sri Satya Vennela wrote: > @@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, > tx_wr = &txq->msg_buf->reqs[msg_id]; > > if (req_len > tx_wr->buf_len) { > - dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len, > - tx_wr->buf_len); > + dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n", > + __func__, __LINE__, req_len, tx_wr->buf_len); I fail to see any relevant information added here ... > err = -EINVAL; > goto out; > } > @@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, > req_msg->req.hwc_msg_id = msg_id; > > tx_wr->msg_size = req_len; > + command = req_msg->req.msg_type; > > if (gc->is_pf) { > dest_vrq = hwc->pf_dest_vrq_id; > @@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, > > err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false); > if (err) { > - dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err); > + dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n", > + __func__, __LINE__, err); ... and here. The string message should be (and apparently is) enough to locate the relevant code inside the tree. Please don't included unneeded/irrelevant changes. Thanks, Paolo