From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mailbox: armada-37xx-rwtm: Remove duplicate error messages in armada_37xx_mbox_probe()
Date: Fri, 3 Apr 2020 21:45:21 +0200 [thread overview]
Message-ID: <2f136a63-72d5-43ef-2a73-67d6984b848d@web.de> (raw)
> In this function,we don't need dev_err() message because when something
> goes wrong,platform_get_irq() and devm_platform_ioremap_resource() have
> print an error message itself, so we should remove duplicate dev_err().
I suggest further fine-tuning also for this commit message.
Regards,
Markus
reply other threads:[~2020-04-03 19:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f136a63-72d5-43ef-2a73-67d6984b848d@web.de \
--to=markus.elfring@web.de \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®