mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Loehle <christian.loehle@arm.com>
To: Aboorva Devarajan <aboorvad@linux.ibm.com>,
	rafael@kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] cpuidle: haltpoll: Remove single state handling
Date: Tue, 17 Feb 2026 14:37:41 +0000	[thread overview]
Message-ID: <2f15b061-611e-4d1d-a0de-2f7ed62ca2d3@arm.com> (raw)
In-Reply-To: <20260216185005.1131593-3-aboorvad@linux.ibm.com>

On 2/16/26 18:50, Aboorva Devarajan wrote:
> cpuidle systems where the governor has no choice because there's only
> a single idle state are now handled by cpuidle core and bypass the
> governor, so remove the related handling.
> 
> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>

Good catch, thanks!
Reviewed-by: Christian Loehle <christian.loehle@arm.com>

> ---
>  drivers/cpuidle/governors/haltpoll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpuidle/governors/haltpoll.c b/drivers/cpuidle/governors/haltpoll.c
> index 663b7f164d20..ed3952df8526 100644
> --- a/drivers/cpuidle/governors/haltpoll.c
> +++ b/drivers/cpuidle/governors/haltpoll.c
> @@ -52,7 +52,7 @@ static int haltpoll_select(struct cpuidle_driver *drv,
>  {
>  	s64 latency_req = cpuidle_governor_latency_req(dev->cpu);
>  
> -	if (!drv->state_count || latency_req == 0) {
> +	if (latency_req == 0) {
>  		*stop_tick = false;
>  		return 0;
>  	}


  reply	other threads:[~2026-02-17 14:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 18:50 [PATCH v2 0/4] cpuidle: Fix crash with single idle state Aboorva Devarajan
2026-02-16 18:50 ` [PATCH v2 1/4] cpuidle: Skip governor when only one idle state is available Aboorva Devarajan
2026-02-17 14:36   ` Christian Loehle
2026-02-17 14:53     ` Rafael J. Wysocki
2026-03-05 16:53   ` Guenter Roeck
2026-03-05 17:06     ` Rafael J. Wysocki
2026-03-05 17:09       ` Guenter Roeck
2026-02-16 18:50 ` [PATCH v2 2/4] cpuidle: haltpoll: Remove single state handling Aboorva Devarajan
2026-02-17 14:37   ` Christian Loehle [this message]
2026-02-16 18:50 ` [PATCH v2 3/4] cpuidle: teo: " Aboorva Devarajan
2026-02-16 18:50 ` [PATCH v2 4/4] cpuidle: menu: " Aboorva Devarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f15b061-611e-4d1d-a0de-2f7ed62ca2d3@arm.com \
    --to=christian.loehle@arm.com \
    --cc=aboorvad@linux.ibm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®