From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
"sudheer.v" <open.sudheer@gmail.com>
Cc: jslaby@suse.com, joel@jms.id.au, andrew@aj.id.au,
benh@kernel.crashing.org, robh+dt@kernel.org,
mark.rutland@arm.com,
shivahshankar.shankarnarayanrao@aspeedtech.com,
shivahshankar@gmail.com, sudheer.veliseti@aspeedtech.com,
sudheer veliseti <sudheer.open@gmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org
Subject: Re: [patch v3 1/5] AST2500 DMA UART driver
Date: Wed, 03 Jul 2019 12:16:01 -0700 [thread overview]
Message-ID: <2f19693f2f720dcc037465d4ae517fb846c7eb4f.camel@perches.com> (raw)
In-Reply-To: <20190703174926.GA12813@kroah.com>
On Wed, 2019-07-03 at 19:49 +0200, Greg KH wrote:
> On Tue, Jun 25, 2019 at 04:14:32PM +0530, sudheer.v wrote:
> > +#define UART_TX_R_POINT(x) (0x40 + (x * 0x20))
> > +#define UART_TX_W_POINT(x) (0x44 + (x * 0x20))
> > +#define UART_TX_SDMA_ADDR(x) (0x48 + (x * 0x20))
> > +#define UART_RX_R_POINT(x) (0x50 + (x * 0x20))
> > +#define UART_RX_W_POINT(x) (0x54 + (x * 0x20))
> > +#define UART_RX_SDMA_ADDR(x) (0x58 + (x * 0x20))
>
> Please use a tab to line these up.
Also x should be surrounded by parentheses
#define UART_TX_R_POINT(x) (0x40 + ((x) * 0x20))
etc...
next prev parent reply other threads:[~2019-07-03 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 10:44 [patch v3 0/5] *** DMA based UART driver for AST2500 *** sudheer.v
2019-06-25 10:44 ` [patch v3 1/5] AST2500 DMA UART driver sudheer.v
2019-07-03 17:49 ` Greg KH
2019-07-03 19:16 ` Joe Perches [this message]
2019-07-03 23:04 ` Benjamin Herrenschmidt
2019-06-25 10:44 ` [patch v3 2/5] build configuration for " sudheer.v
2019-07-03 17:50 ` Greg KH
2019-06-25 10:44 ` [patch v3 3/5] DT nodes " sudheer.v
2019-07-03 17:50 ` Greg KH
2019-06-25 10:44 ` [patch v3 4/5] defconfig and MAINTAINERS updated " sudheer.v
2019-07-03 17:51 ` Greg KH
2019-06-25 10:44 ` [patch v3 5/5] Documentation: DT bindings " sudheer.v
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f19693f2f720dcc037465d4ae517fb846c7eb4f.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=jslaby@suse.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=open.sudheer@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shivahshankar.shankarnarayanrao@aspeedtech.com \
--cc=shivahshankar@gmail.com \
--cc=sudheer.open@gmail.com \
--cc=sudheer.veliseti@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®