From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C16C3A5A3 for ; Tue, 27 Aug 2019 14:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2058520828 for ; Tue, 27 Aug 2019 14:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728324AbfH0OeM (ORCPT ); Tue, 27 Aug 2019 10:34:12 -0400 Received: from foss.arm.com ([217.140.110.172]:46004 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbfH0OeM (ORCPT ); Tue, 27 Aug 2019 10:34:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5732D337; Tue, 27 Aug 2019 07:34:11 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7AF13F59C; Tue, 27 Aug 2019 07:34:09 -0700 (PDT) Subject: Re: [RFC PATCH 5/7] arm64: smp: use generic SMP stop common code To: Thomas Gleixner Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mark.rutland@arm.com, peterz@infradead.org, catalin.marinas@arm.com, takahiro.akashi@linaro.org, james.morse@arm.com, hidehiro.kawai.ez@hitachi.com, will@kernel.org, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org References: <20190823115720.605-1-cristian.marussi@arm.com> <20190823115720.605-6-cristian.marussi@arm.com> <20190826153236.GA9591@infradead.org> From: Cristian Marussi Message-ID: <2f1b7e1f-5ba2-37b4-193b-133a93a3f6ea@arm.com> Date: Tue, 27 Aug 2019 15:34:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 26/08/2019 23:26, Thomas Gleixner wrote: > On Mon, 26 Aug 2019, Cristian Marussi wrote: >> On 8/26/19 4:32 PM, Christoph Hellwig wrote: >>>> +config ARCH_USE_COMMON_SMP_STOP >>>> + def_bool y if SMP >>> >>> The option belongs into common code and the arch code shoud only >>> select it. >>> >> >> In fact that was my first approach, but then I noticed that in kernel/ topdir >> there was no generic Kconfig but only subsystem specific ones: >> >> Kconfig.freezer Kconfig.hz Kconfig.locks Kconfig.preempt > > arch/Kconfig > Ok I'll move it there in v2. Thanks for the review. Cristian > Thanks, > > tglx >