From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959571CEADB for ; Mon, 9 Feb 2026 10:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770631311; cv=none; b=fq1hq5gqC1x25c3hsKELgxkzbZR2iOgcVxmXYgJ8KmJ/mz7kTRnoNKmk98dJELNXAvLeVxYevNpFYEb+Y+TyNxn4VbmyyUNNKuLHvmWPs5yVaxtlWc1eyE9swYQhd20doNALopifPL0sSn+7SH/x80ai07Ama4bA9B5u4HjBX/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770631311; c=relaxed/simple; bh=92L8oTerNxwiJBJ5Y3oAL/m4tt7fM/2hqtMOf+F3OJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PJXC3Pjp2FZFwaPEMp9TV6nnzd+pJk6kUUWKwjBNcmKT6TO/Bc6wVWaAt78+XrqRVhyRNX8LsckuTk8zqTfgNv1VEuIQw9525nzLX3zI8E2m+d0+KCNt4RV25/n6/yWhY4ote+A/whac4ctw9xeHkiCdu3kgAQeX/dATZmPbsN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o+6YwqIR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o+6YwqIR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A224C16AAE; Mon, 9 Feb 2026 10:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770631311; bh=92L8oTerNxwiJBJ5Y3oAL/m4tt7fM/2hqtMOf+F3OJA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o+6YwqIRuDuLv6T1THpzWj7KbUUhI80bMEwjLWEnt4MeA0T3GoYf4LrmvLWPRfSc/ ma4xN/OAPLI/NITdSi/llXZixpAsOzPjVeJN4dkrkcJ8v/l9sMTyfM1aj7LHzjewcg eLFoYFL2Qt6ME8GwyuN3KY6dkKku1V+wzU6rX/vNvWhe7E2tYwefvIGnXIhVv3B2tf IpTbVfd/REBG1R67Z7gc5FG/w4b4Q0vevyv0iy5N+LbkgQHjtfaKFgeIEcdwPDLjju mbTHu1oG2NO9Smyuatqg+fteB/Y0RLOBGXHA/O1YoZWkC17ChxOvAtGK4VSrVkhWEx eYaSGZCb2C6Gg== Message-ID: <2f1bc7e6-a981-4467-89ef-609080436286@kernel.org> Date: Mon, 9 Feb 2026 11:01:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() To: Marek Szyprowski , Mark Brown , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Rob Herring (Arm)" , Oreoluwa Babatunde Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260128-cma-fix-stubs-v1-1-e07a077d5b33@kernel.org> <4fc5e312-b56a-4664-9722-81163ecef515@kernel.org> <67426771-7df6-4544-a77c-97f44ee08d99@samsung.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <67426771-7df6-4544-a77c-97f44ee08d99@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/9/26 10:59, Marek Szyprowski wrote: > On 09.02.2026 09:11, David Hildenbrand (Arm) wrote: >> On 1/28/26 17:28, Mark Brown wrote: >>> The stub for cma_skip_dt_default_reserved_mem() is not inlined so >>> triggers build warnings: >>> >>> In file included from /tmp/next/build/fs/proc/meminfo.c:18: >>> /tmp/next/build/include/linux/cma.h:68:13: warning: >>> 'cma_skip_dt_default_reserved_mem' defined but not used >>> [-Wunused-function] >>>     68 | static bool cma_skip_dt_default_reserved_mem(void) >>>        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> which are fatal with -Werror. >>> >>> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework >>> detect "cma=" kernel param") >>> Signed-off-by: Mark Brown >> >> $ git show 26332ae848f08 >> fatal: ambiguous argument '26332ae848f08': unknown revision or path >> not in the working tree. >> >> This is not upstream or against an mm tree. Against which tree is it? > > The fix for this issue has been squashed into commit 0fd17e598333 ("of: > reserved_mem: Allow reserved_mem framework detect "cma=" kernel param") > and merged to v6.19-rc8, so the above fix is not longer needed. Ah, that's just what I wanted to ask: can this be squashed :) Thanks! -- Cheers, David