From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933107AbcE3PQR (ORCPT ); Mon, 30 May 2016 11:16:17 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:43564 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754869AbcE3PQO (ORCPT ); Mon, 30 May 2016 11:16:14 -0400 From: Joao Pinto To: linux-kernel@vger.kernel.org Cc: ijc+devicetree@hellion.org.uk, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, liviu.dudau@arm.com, ryan.harkin@linaro.org, Joao Pinto Subject: [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails. Date: Mon, 30 May 2016 16:15:54 +0100 Message-Id: <2f242f545c99fc604fb70eeffcfd5d7703ace18d.1464619185.git.jpinto@synopsys.com> X-Mailer: git-send-email 1.8.1.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When using ffplay to reproduce video+sound it was noticed that sometimes the sound was disabled. The cause was an initial EDID checksum error that disabled the HDMI sound. By adding this tweak, it was noticed that the sound is not even when initial EDID checksum error ocurres. Signed-off-by: Joao Pinto --- drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 7020b50..fc7c1c3 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -587,6 +587,17 @@ static void tda998x_detect_work(struct work_struct *work) drm_kms_helper_hotplug_event(dev); } +/* handle HDMI connect/disconnect */ +static void tda998x_hpd(struct work_struct *work) +{ + struct delayed_work *dwork = to_delayed_work(work); + struct tda998x_priv *priv = + container_of(dwork, struct tda998x_priv, dwork); + + if (&priv->encoder && priv->encoder.dev) + drm_kms_helper_hotplug_event(priv->encoder.dev); +} + /* * only 2 interrupts may occur: screen plug/unplug and EDID read */ @@ -1313,6 +1324,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv) /* init read EDID waitqueue and HDP work */ init_waitqueue_head(&priv->wq_edid); + INIT_DELAYED_WORK(&priv->dwork, tda998x_hpd); /* clear pending interrupts */ reg_read(priv, REG_INT_FLAGS_0); -- 1.8.1.5