Re: [PATCH v4 4/4] arm64: dts: qcom: monaco-evk: Add sound card

[Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>]

On 9/8/2025 9:25 PM, Konrad Dybcio wrote:
> On 9/8/25 4:55 PM, Bjorn Andersson wrote:
>> On Sat, Sep 06, 2025 at 10:26:23PM +0300, Dmitry Baryshkov wrote:
>>> On Sat, Sep 06, 2025 at 12:53:50AM +0530, Umang Chheda wrote:
>>>> From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>>>>
>>>> Add the sound card for monaco-evk board and verified playback
>>>> functionality using the max98357a I2S speaker amplifier and I2S
>>>> microphones. The max98357a speaker amplifier is connected via
>>>> High-Speed MI2S HS0 interface, while the microphones utilize the
>>>> Secondary MI2S interface and also enable required pin controller
>>>> gpios for audio.
>>>>
>>>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>>>> Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
>>>> ---
>>>>   arch/arm64/boot/dts/qcom/monaco-evk.dts | 52 +++++++++++++++++++++++++
>>>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi   | 37 ++++++++++++++++++
>>>>   2 files changed, 89 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>>> index 93e9e5322a39..f3c5d363921e 100644
>>>> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>>> @@ -6,6 +6,7 @@
>>>>   /dts-v1/;
>>>>
>>>>   #include <dt-bindings/gpio/gpio.h>
>>>> +#include <dt-bindings/sound/qcom,q6afe.h>
>>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>>
>>>>   #include "qcs8300.dtsi"
>>>> @@ -24,6 +25,57 @@ aliases {
>>>>   	chosen {
>>>>   		stdout-path = "serial0:115200n8";
>>>>   	};
>>>> +
>>>> +	dmic: audio-codec-0 {
>>>> +		compatible = "dmic-codec";
>>>> +		#sound-dai-cells = <0>;
>>>> +		num-channels = <1>;
>>>> +	};
>>>> +
>>>> +	max98357a: audio-codec-1 {
>>>> +		compatible = "maxim,max98357a";
>>>> +		#sound-dai-cells = <0>;
>>>> +	};
>>>> +
>>>> +	sound {
>>>> +		compatible = "qcom,qcs8275-sndcard";
>>>
>>> qcs8300
>>>

ACK,

>>
>> If the Monaco EVK actually is QCS8300... But, I presume qcs8275 and
>> qcs8300 are identical when it comes to sound?
>>
>> @Mohammad, if this is the case can't we just support the
>> qcom,monaco-sndcard instead to avoid this confusion?
>

The Monaco-EVK board is based on Qualcomm's QCS8300 SoC.

Although the Monaco-EVK platform was previously associated with the 
QCS8275 sound card, the QCS8275 re-use was based on existing coverage. 
However, according to the naming guidelines, sound card compatibility 
should be based on the SoC rather than the board.

Therefore, it's necessary to use the SoC name in the sound card 
compatible string. I will update the DTS to use qcom,qcs8300-sndcard to 
align with the convention and avoid confusion.


> Commit 34d340d48e59 ("ASoC: qcom: sc8280xp: Add support for QCS8275")
> 
> Unless we choose to ignore that compatible and add "monaco", but I don't
> think dt maintainers will love that
> 

Agree. We used the existing qcom,qcs8275-sndcard compatible string 
instead of adding a new one, but this needs to be changed.

The sound card compatible should be SoC specific in this case, qcs8300.

I will update the patch with qcom,qcs8300-sndcard.


Thanks & Regards,
Rafi.


> Konrad