From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D83DBC32793 for ; Wed, 18 Jan 2023 16:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbjARQCJ (ORCPT ); Wed, 18 Jan 2023 11:02:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbjARQA3 (ORCPT ); Wed, 18 Jan 2023 11:00:29 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E10B04743D; Wed, 18 Jan 2023 07:57:42 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 873D35C00B5; Wed, 18 Jan 2023 10:57:40 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 18 Jan 2023 10:57:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674057460; x=1674143860; bh=lhuRRX4nZc nfSkbGPlEVZUMLxgtDCIH82Wit+HugQ7g=; b=b2CxJRGEHjEoDWeQlom2JGf8h0 41l/jbnvkIcudriFcooVZAf0ivh5eOrB9jxtJ4c+NNNQMPN5UnNHExr0rMziEL8u OMseJN5bw0h0zN1GYSntmxIf+qZ5zbm8F5GAPrubz9peeepYqaNr+vsJZLhJpw5R cryQB2/dfJvjD/vhCD0fPYXYYOR189gXhPein2aVA/QFCVskK2prifNUuQh/oOKs W2kP0b+LSTE3P6ViO2IliytcDFZduXUWKHXbTPNKvY4kBroDWbsIRiKt3lrJ9dqT 9uebUpJokTlr8bCSGAyQF5djz0NRg3EgC8nbhKXFFMZmLECssPKRZhSx2z4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674057460; x=1674143860; bh=lhuRRX4nZcnfSkbGPlEVZUMLxgtD CIH82Wit+HugQ7g=; b=UajZseswPDKAE+UaOIX3Vin5eOt/niePhLfhE7A5noZ9 1BybhBxUMVKV77VBF/FEQWjJZNPUDNbkDXK9iMQVy/bM/lqiNftlg5vOMgYPIm5H KgwUmSuIRjYEOniph19An0qv4BIFzpsdW8LHT8eFunMU277bVsIMJUIl668s7Uox jh5w8N2Au0xE/5gYS5V031zGKtXvT6duWALKtqd7ALiyPLtuzOf0d9/9qYU7BFm8 sRE1qGo6Y7IZwPynPeccgY39iV7pXpkkNl8/l62/b/GTHpQlNidHhqbbEc44OolZ G0nsQ4WYjRJFVAOO/rDX8XjoQm6pvoGX/Kb++lxeNw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtkedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4BBF2B60089; Wed, 18 Jan 2023 10:57:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1187-g678636ba0d-fm-20230113.001-g678636ba Mime-Version: 1.0 Message-Id: <2f310818-7b19-4c07-9948-d5e413989594@app.fastmail.com> In-Reply-To: References: <20230117171055.2714621-1-arnd@kernel.org> Date: Wed, 18 Jan 2023 16:57:19 +0100 From: "Arnd Bergmann" To: "Mike Isely at pobox" , "Arnd Bergmann" Cc: "Mauro Carvalho Chehab" , "Lecopzer Chen" , "Hans Verkuil" , =?UTF-8?Q?=C5=81ukasz_Stelmach?= , "laurent.pinchart" , "Jacopo Mondi" , "Andrzej Pietrasiewicz" , linux-media@vger.kernel.org, "Linux Kernel Mailing List" Subject: Re: [PATCH] media: pvrusb2: fix DVB_CORE dependency Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2023, at 16:39, Mike Isely wrote: > That doesn't seem right. The pvrusb2 module should reference that > symbol like any other. There is no special treatment of it within > pvrusb2 - so why is that requiring special treatment here? The problem is that VIDEO_PVRUSB2_DVB is a 'bool' symbol, not a 'tristate', so the existing 'depends on DVB_CORE' is not sufficient. Another way to do this would be to prevent VIDEO_PVRUSB2 from being built-in when DVB_CORE is a module: config VIDEO_PVRUSB2 tristate "Hauppauge WinTV-PVR USB2 support" depends on VIDEO_DEV && I2C + depends on DVB_CORE || !DVB_CORE select VIDEO_TUNER select VIDEO_TVEEPROM select VIDEO_CX2341X but that doesn't feel right for users that don't care about DVB support. > Is it possible that dvb_module_probe and dvb_module_release are not > exported? (Or that there are two corresponding different exported > symbol names that pvrusb2 should be using instead?) No. Arnd