From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbdHKHqz (ORCPT ); Fri, 11 Aug 2017 03:46:55 -0400 Received: from mout.web.de ([212.227.15.3]:52532 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbdHKHqy (ORCPT ); Fri, 11 Aug 2017 03:46:54 -0400 To: alsa-devel@alsa-project.org, "Gustavo A. R. Silva" , Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ASoC: kirkwood: Delete an error message for a failed memory allocation in kirkwood_i2s_dev_probe() Message-ID: <2f32b2cf-dcde-ccef-24a5-f7b6ad9beb83@users.sourceforge.net> Date: Fri, 11 Aug 2017 09:45:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:TSCokwg6PIcGzjZ/FefNishH6eHkshDTCpbcPb6AeskFR/5cibx bUaGpGK+X4qHgzLqqMvYCgb6VJ44cmaoCMDTZ4XKvLLHOV5+a01wHSuK2XrpuaXAnK716Xf A8TUYHVqVR7QUwNnCB02CtLPYc++rgkyhmSUi2LEDd4FtwCfi2cH9wD1Pk0xWV8ModqoARO L/Oku7QWSGXe40Bz3EkMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:c0RD5S3bva8=:uzGME74EaqD5TwpAMcPk05 VMJU+fFm6FS3NSPap91fcankXz3P1BJUMSjXSuRq22yP5ran3UwAeY8fSHRXuFFq7/PrCRfkt EZ+w35qMQpUO2nOx57XGqQayEjp9Q4DIEITIBPHCtJlbUBp+ylbTcNIp5mE+rHcnXqH2qV4k9 czUYH2K67vLlOsSx+2n374MWPT9CajD2dmBJVh+6KgWKZNZ7qQmlALOLIE8fI30VXiUmEpQFk GDe2d/DEevh9+NZXvpy/dS+A9qZLTeinj1odGtBQKWO6VMdLrfz3hOmue3FzNQ/ZnSN3loQ90 N2PnnyCTN8Qn5WB4C0MuN5zOso8HYcEGi+Rece2DqV8fQqKdX733N8+RiA+BALuMv+4P+b7ab UJXBYu3Oeh9js9zcrfnoKl2CXvwr/Je0rc+sLPxB7fj7WUbOtIC2blXUvZtxWqP5FZRfjBu4+ UAbMYCIaYh2Z2EzoSZen/3idjWjsKz90y1WvkGDI1qBbdIyAgFuuIgZfXzFTCh5zPqECkVeSF dAlIeXjXDved+RPiSVGwLiAzB0AO9GdUKo/iPe7j5TtN03qqEkStri+7t7pliywrwjlRVvtmG 423bl85ge9DFwcK+Bj+HhcC2r3T6WBp9N4UDFM6Uv3PIjgbeMquypvYDDg2cRCVumEO+Tso7o Z6WCLG3pngAbfinYInHlKxUMH4fi2iyUI8BZC5++FPEZeyuAo5vhDcb9jxaUI43B0uTCA34rP Sl0Uoct4e4ZDhpDVQ3r9QE3jltGHb5PvxXMO9p96hC48AbBrroz0DxPXUuOz5E+oM77uzTyNl 1Yzm5kBGzJBd28nkzaKDoGxtB5zzpLZmCG9vuDZXhbm7H/SqUM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 11 Aug 2017 09:35:33 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/kirkwood/kirkwood-i2s.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c index 3b09f71b9535..105a73cc5158 100644 --- a/sound/soc/kirkwood/kirkwood-i2s.c +++ b/sound/soc/kirkwood/kirkwood-i2s.c @@ -538,10 +538,9 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev) int err; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&pdev->dev, "allocation failed\n"); + if (!priv) return -ENOMEM; - } + dev_set_drvdata(&pdev->dev, priv); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.14.0